On Mon, Aug 29, 2016 at 09:36:32PM +, Don Brace wrote:
> > -Original Message-
[...]
> >
> > IIRC I asked you to introduce this timeout, as you're calling
> > pqi_flush_cache() from the driver's shutdown callback and I still
> > doubt users like their shutdown's to hang indefinitely b
On Mon, Aug 29, 2016 at 08:57:19PM +, Don Brace wrote:
> > -Original Message-
[...]
> >
> > This should be foldet into the next patch where you actually add the
> > documentation ;-).
>
> I squash smartpqi-add-smartpqi.txt and smartpqi-update-maintainers
Thanks,
Johannes
-
On Mon, Aug 29, 2016 at 08:29:20PM +, Don Brace wrote:
> > -Original Message-
> > From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
[...]
>
> The reason is that we want it run immediately (or close to immediately).
>
> The code could be restructured to avoid calling this function
On Mon, Aug 29, 2016 at 09:44:36PM +, Don Brace wrote:
> > -Original Message-
> > From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
[...]
> > > + while (1) {
> >
> > Is there any compelling reason why you didn't use scsi_for_each_sg()
> > here? I don't see a reason for the whi
We get 2 warnings about global functions without a declaration
in the scsi driver when building with W=1:
drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for
'scsi_requeue_run_queue' [-Wmissing-prototypes]
drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for
'scsi_evt_
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Tuesday, August 30, 2016 2:18 AM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
> elli...@hpe.com
From: Colin Ian King
port is deferenced before it is null sanity checked, hence
we potentially have a null pointer dereference bug. Instead,
initialise trl_enabled from port->fcs->bfa after we are sure
port is not null.
Signed-off-by: Colin Ian King
---
drivers/scsi/bfa/bfa_fcs_lport.c | 4 ++-
Hi Martin, (you're the last person to touch this? :)
If I create a local SCSI device using LIO's loopback fabric, and backed
by a file, /sys/block/sda/queue/max_hw_sectors_kb reports 32767. This
reflects the loopback scsi_host_template reporting 65536 max_sectors,
but that's the "controller" -
The workqueues "ioc->reset_work_q" and "ioc->fw_event_q" queue a single
work item &ioc->fault_reset_work and &fw_event->work, respectively and
hence don't require ordering. Hence, they have been converted to use
alloc_workqueue().
The WQ_MEM_RECLAIM flag has been set to ensure forward progress und
The workqueue "fc_rescan_work_q" queues multiple work items viz
&ioc->fc_rescan_work, &ioc->fc_lsc_work, &ioc->fc_setup_reset_work,
which require strict execution ordering.
Hence, an ordered dedicated workqueue has been used.
WQ_MEM_RECLAIM has been set since the workqueue is belongs to a storage
This patch set removes deprecated create_singlethread_workqueue
instances from drivers/message
Bhaktipriya Shridhar (2):
fusion/mptfc: Remove deprecated create_singlethread_workqueue
fusion: mptbase: Remove deprecated create_singlethread_workqueue
drivers/message/fusion/mptbase.c | 7 ---
On Mon, Aug 29, 2016 at 11:16 AM, Bart Van Assche
wrote:
> On 08/14/2016 10:21 AM, James Bottomley wrote:
>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
>> index d3e852a..222771d 100644
>> --- a/drivers/scsi/sd.c
>> +++ b/drivers/scsi/sd.c
>> @@ -3000,7 +3000,13 @@ static void sd_probe_asyn
On 08/30/2016 01:43 PM, Dan Williams wrote:
I tried running this, but it seems I'm failing to configure my test
environment correctly [1], but I'm worried that this "re-parenting the
scsi-disk" approach, even if the above warning is addressed, may not
be backwards compatible. We now have an orde
Hello Himanshu and Nicholas,
Enhancements to the tcm_debug code.
Added the possibility of blocking only specific SCSI data movement commands but
allowing TUR'S to pass.
This has been helpful for debugging many driver/array interoperabilty issues.
Two Patches, The first is to the driver code, sec
- Original Message -
> From: "Laurence Oberman"
> To: "himanshu madhani" , n...@linux-iscsi.org,
> "Linux SCSI Mailinglist"
>
> Sent: Tuesday, August 30, 2016 5:24:19 PM
> Subject: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to
> the tcm_qla2xxx module - enhancement
Hello Himanshu and Nicholas,
Enhancements to the tcm_debug code.
This is patch V2 (final) as V1 had issues.
Added the possibility of blocking only specific SCSI data movement commands
but allowing TUR'S to pass.
This has been helpful for debugging many driver/array interoperabilty
issues.
Folded
On 08/30/2016 10:54 AM, Andy Grover wrote:
Hi Martin, (you're the last person to touch this? :)
If I create a local SCSI device using LIO's loopback fabric, and backed
by a file, /sys/block/sda/queue/max_hw_sectors_kb reports 32767. This
reflects the loopback scsi_host_template reporting 65536 m
> "Andy" == Andy Grover writes:
Hey Andy,
Andy> ...because limits.max_hw_sectors internally seems to be just the
Andy> controller limit, but what users of queue_max_hw_sectors
Andy> (including sysfs) really want is the lesser of
Andy> limits.max_hw_sectors and limits.max_dev_sectors.
max_de
> "Paul" == Paul Burton writes:
Paul> Calculating the maximum timeout that a user can set via the
Paul> SG_SET_TIMEOUT ioctl involves multiplying INT_MAX by
Paul> USER_HZ/HZ. If USER_HZ is larger than HZ then this results in an
Paul> overflow when performed as a 32 bit integer calculation, re
> "Paul" == Paul Burton writes:
Paul> The MULDIV macro is essentially a duplicate of the more standard
Paul> mult_frac macro. Replace use of MULDIV with mult_frac & drop the
Paul> duplication.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe
> "Christophe" == Christophe JAILLET writes:
Christophe> The 2nd parameter of 'find_first_bit' is the number of bits
Christophe> to search. In this case, we are passing 'sizeof(unsigned
Christophe> long)' which is likely to be 4.
Christophe> It is likely that the number of bits in a long wa
> "Jitendra" == Jitendra Bhivare writes:
Jitendra> These patches address some auto built issues of 11.2.0.0
Jitendra> be2iscsi committed in 4.9/scsi-queue.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubs
On 08/30/2016 08:15 PM, Martin K. Petersen wrote:
"Andy" == Andy Grover writes:
Hey Andy,
Andy> ...because limits.max_hw_sectors internally seems to be just the
Andy> controller limit, but what users of queue_max_hw_sectors
Andy> (including sysfs) really want is the lesser of
Andy> limits.max
> "Johannes" == Johannes Thumshirn writes:
Hannes,
Johannes> I _think_ I already reviewed them (at least I do have a
Johannes> deja-vu when I read 'Revisit kref handling')
In v1 of the series patches 7, 11, 15 and 22 needed changes, everything
else had been reviewed. 15 appears to have been
> "Jens" == Jens Axboe writes:
Jens,
>> It is a requirement for SG_IO, firmware updates, tape drives,
>> etc. that the controller limits are reported correctly since they do
>> I/Os that are much bigger than typical filesystem requests. When we
>> tried to conflate the two things broke in in
> "Tyrel" == Tyrel Datwyler writes:
Tyrel> On 07/22/2016 07:03 AM, Wei Yongjun wrote:
>> Using list_move_tail() instead of list_del() + list_add_tail().
>>
>> Signed-off-by: Wei Yongjun
Tyrel> Reviewed-by: Tyrel Datwyler
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linu
> "Finn" == Finn Thain writes:
Finn> Miscellaneous small patches for an interrupt latency issue, a
Finn> compiler warning and a documentation cleanup.
Applied patches 1 and 2 to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the l
> "Baoyou" == Baoyou Xie writes:
Baoyou> We get 2 warnings about global functions without a declaration
Baoyou> in the scsi driver when building with W=1:
Baoyou> drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype
Baoyou> for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
Baoyou>
Large PIO transfers are broken up into chunks to try to avoid disabling
local IRQs for long periods. But IRQs are still disabled for too long
and this causes SCC FIFO overruns during serial port transfers.
This patch reduces the PIO chunk size to reduce interrupt latency to
something on the order
29 matches
Mail list logo
