Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-06 Thread Johannes Thumshirn
On Thu, Jun 30, 2016 at 05:00:32PM +0200, Bruno Prémont wrote: > In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL > pointer dereference when rsp->msix is NULL: > > [5.622457] NULL pointer dereference at 0050 > [5.622457] IP: [] > qla24xx_process_response_q

[PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

2016-07-06 Thread Johannes Thumshirn
qla2xxx first calls request_irq() and then does the setup of the queue entry data needed in the interrupt handlers in when using MSI-X. This could lead to a NULL pointer dereference when an IRQ fires between the request_irq() call and the assignment of the qentry data structure to the rsp->msix fie

[PATCH] scsi:libsas: fix oops caused by assigning a freed task to ->lldd_task

2016-07-06 Thread Wei Fang
A freed task has been assigned to ->lldd_task when lldd_execute_task() failed in sas_ata_qc_issue(), and access of ->lldd_task will cause an oops: Call trace: [] sas_ata_post_internal+0x6c/0x150 [] ata_exec_internal_sg+0x32c/0x588 [] ata_exec_internal+0x88/0xe8 [] ata_dev_read_id+0x204/0x5e0 [] at

Re: [PATCH] scsi:libsas: fix oops caused by assigning a freed task to ->lldd_task

2016-07-06 Thread Hannes Reinecke
On 07/06/2016 10:28 AM, Wei Fang wrote: > A freed task has been assigned to ->lldd_task when lldd_execute_task() > failed in sas_ata_qc_issue(), and access of ->lldd_task will cause > an oops: > > Call trace: > [] sas_ata_post_internal+0x6c/0x150 > [] ata_exec_internal_sg+0x32c/0x588 > [] ata_exec

Re: [PATCH] scsi:libsas: fix oops caused by assigning a freed task to ->lldd_task

2016-07-06 Thread Wei Fang
Hi, Hannes, > This is most definitely wrong. > Sure you mean > > qc->lldd_task = NULL; > > in that line? My mistake. Thanks for pointing me out. Will resend soon. Please ignore this patch. Thanks, Wei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

[PATCH v2] scsi:libsas: fix oops caused by assigning a freed task to ->lldd_task

2016-07-06 Thread Wei Fang
A freed task has been assigned to ->lldd_task when lldd_execute_task() failed in sas_ata_qc_issue(), and access of ->lldd_task will cause an oops: Call trace: [] sas_ata_post_internal+0x6c/0x150 [] ata_exec_internal_sg+0x32c/0x588 [] ata_exec_internal+0x88/0xe8 [] ata_dev_read_id+0x204/0x5e0 [] at

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

2016-07-06 Thread Hannes Reinecke
On 07/06/2016 09:51 AM, Johannes Thumshirn wrote: > qla2xxx first calls request_irq() and then does the setup of the queue > entry data needed in the interrupt handlers in when using MSI-X. This > could lead to a NULL pointer dereference when an IRQ fires between the > request_irq() call and the as

Re: parisc late boot crash in 4.4-rc, scsi-related

2016-07-06 Thread John David Anglin
On 2016-07-06 2:59 AM, Meelis Roos wrote: What distro are you using? My pariscs are gentoo and still only the old versions are available on hppa. Several newer versions (4.9, 5.3) are in portage, maybe they just need to be unmasked. 4.9.3 and 5.3.0 were too old. Correct. 4.9.4 will include f

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-06 Thread Tejun Heo
On Wed, Jul 06, 2016 at 06:40:32AM +, Tom Yan wrote: > Um it's not mainly about in caps or not, but more about wrongly spelled as > cbd. Heh, right, so please just note it in the description. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

[Bug 121531] New: Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 Bug ID: 121531 Summary: Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once Product: IO/Storage Version: 2.5 Kernel Version: 3.16.0-4-amd64 Hardware: All

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #1 from Martin von Wittich --- Created attachment 222181 --> https://bugzilla.kernel.org/attachment.cgi?id=222181&action=edit dmidecode output -- You are receiving this mail because: You are the assignee for the bug. -- To unsubsc

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #5 from Martin von Wittich --- Created attachment 21 --> https://bugzilla.kernel.org/attachment.cgi?id=21&action=edit smartctl -a /dev/sdc output -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #4 from Martin von Wittich --- Created attachment 11 --> https://bugzilla.kernel.org/attachment.cgi?id=11&action=edit smartctl -a /dev/sdb output -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #3 from Martin von Wittich --- Created attachment 01 --> https://bugzilla.kernel.org/attachment.cgi?id=01&action=edit modinfo pm80xx output -- You are receiving this mail because: You are the assignee for the bug. -- To un

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #2 from Martin von Wittich --- Created attachment 222191 --> https://bugzilla.kernel.org/attachment.cgi?id=222191&action=edit lspci -vnn output -- You are receiving this mail because: You are the assignee for the bug. -- To unsubs

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #6 from Martin von Wittich --- Created attachment 31 --> https://bugzilla.kernel.org/attachment.cgi?id=31&action=edit uname -a, cat /proc/version output -- You are receiving this mail because: You are the assignee for the

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #7 from Martin von Wittich --- Created attachment 41 --> https://bugzilla.kernel.org/attachment.cgi?id=41&action=edit dmesg output after booting, before writing to the disks -- You are receiving this mail because: You are

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #8 from Martin von Wittich --- Created attachment 51 --> https://bugzilla.kernel.org/attachment.cgi?id=51&action=edit dmesg output a few seconds after writing >128 MB to one disk -- You are receiving this mail because: You

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #9 from Martin von Wittich --- Created attachment 61 --> https://bugzilla.kernel.org/attachment.cgi?id=61&action=edit dmesg output another few seconds later, completely filled with pm80xx errors -- You are receiving this m

[PATCH 02/19] qla2xxx: Add ram area DDR for fwdump template entry T262.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 ++ drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- drivers/scsi/qla2xxx/qla_tmpl.c | 9 - 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/

[PATCH 04/19] qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode.

2016-07-06 Thread Himanshu Madhani
From: Giridhar Malavali When VP decoupling enabled, there could be a window where, FLOGI from initiators can be dropped before VP0 is enabled, causing link level recovery. Retry FLOGI to avoid link level recovery. Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/sc

[PATCH 08/19] qla2xxx: Properly reset firmware statistics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 28 drivers/scsi/qla2xxx/qla_bsg.c | 2 +- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xx

[PATCH 01/19] qla2xxx: Remove sysfs node fw_dump_template.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 89 - drivers/scsi/qla2xxx/qla_dbg.c | 1 + 2 files changed, 1 insertion(+), 89 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_a

[PATCH 00/19] qla2xxx: Patches for scsi "misc" branch.

2016-07-06 Thread Himanshu Madhani
Hi James, Martin, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, -Himanshu Giridhar Malavali (1): qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode. Himanshu Madhani (1): qla2xxx: Update driver version to 8

[PATCH 18/19] qla2xxx: Fix BBCR offset

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak Fixes: 969a619 ("qla2xxx: Add support for buffer to buffer credit value for ISP27XX.") Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_fw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/ql

[PATCH 03/19] qla2xxx: Shutdown board on thermal shutdown aen.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_isr.c | 7 +++ drivers/scsi/qla2xxx/qla_os.c | 10 ++ 4 files changed, 19 insertions(+), 1

[PATCH 14/19] qla2xxx: Correction to function qla26xx_dport_diagnostics().

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_isr.c | 8 +++- drivers/scsi/qla2xxx/qla_mbx.c | 5 - 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/qla2xx

[PATCH 07/19] qla2xxx: Properly initialize IO statistics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Properly initialize IO statistics to avoid initial 0xFFF (-1) values. Cleanup/simplify usage of pointer to statistics structure. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 50 +++

[PATCH 16/19] qla2xxx: Disable the adapter and skip error recovery in case of register disconnect.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak If there is error recovery going on due to command timeout and there is register disconnect, then disable the adapter. Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 3 +++ drivers/scsi/qla2xxx/qla_dbg.c | 2 +- driver

[PATCH 11/19] qla2xxx: Add bsg interface to support statistics counter reset.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 48 ++ drivers/scsi/qla2xxx/qla_bsg.h | 1 + 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_

[PATCH 12/19] qla2xxx: Let DPORT be enabled purely by nvram.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 12 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/q

[PATCH 10/19] qla2xxx: Add bsg interface to support D_Port Diagnostics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 44 drivers/scsi/qla2xxx/qla_bsg.h | 12 + drivers/scsi/qla2xxx/qla_dbg.c | 3 +-- drivers/scsi/qla2xxx/qla_gbl.h | 3 +++ drivers/sc

[PATCH 06/19] qla2xxx: Make debug buffer log easier to view.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 907a

[PATCH 09/19] qla2xxx: Check for device state before unloading the driver.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak During hot swap of PCI device, there can be PCI error on device, during normal driver unload. The race between normal driver unload and driver unload due to PCI error, can lead to system crash.Fix is to check if there is unload going on and allow that function to unload the dr

[PATCH 05/19] qla2xxx: Add module parameter alternate/short names.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index dc608ce..f1a2394 100644 --- a/drivers/scsi/qla2xxx/qla_o

[PATCH 19/19] qla2xxx: Update driver version to 8.07.00.38-k

2016-07-06 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0bc93fa..3cb1964 100644 --- a/drivers/scsi/ql

[PATCH 13/19] qla2xxx: Add support to handle Loop Init error Asynchronus event.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_isr.c | 11 +-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/ql

[PATCH 17/19] qla2xxx: Fix duplicate message id.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 7 +++ drivers/scsi/qla2xxx/qla_isr.c | 2 +- drivers/scsi/qla2xxx/qla_mbx.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/q

[PATCH 15/19] qla2xxx: Separate ISP type bits out from device type.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 6 -- drivers/scsi/qla2xxx/qla_os.c | 44 +- 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/scsi/qla2xxx

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #10 from Martin von Wittich --- I forgot to mention: the issue is also reproducible on a Ubuntu 16.04 live system with Linux 4.4, by running "dd if=/dev/zero of=/dev/sdX bs=1M count=128". -- You are receiving this mail because: You

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 Jack Wang changed: What|Removed |Added CC||xjtu...@gmail.com --- Comment #11 from Jack

[PATCH] qla2xxx: Fix compiler warning

2016-07-06 Thread Himanshu Madhani
Fixes: 7f939ab ("qla2xxx: Add bsg interface to support statistics counter reset.") Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_bsg.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/driv

Re: [PATCH 11/19] qla2xxx: Add bsg interface to support statistics counter reset.

2016-07-06 Thread kbuild test robot
Hi, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.7-rc6 next-20160706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Patches-for-scsi-misc

[PATCH v3 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

2016-07-06 Thread tom . ty89
From: Tom Yan Currently if a WRITE SAME (16) command is issued to the SATL with "number of blocks" that is larger than the "Maximum write same length" (which is the maximum number of blocks per TRIM command allowed in libata, currently 65535 * 512 / 8 blocks), the SATL will accept the command and

[PATCH v3 2/2] libata-scsi: avoid repeated calculation of number of TRIM ranges

2016-07-06 Thread tom . ty89
From: Tom Yan Currently libata statically allows only 1-block (512-byte) payload for each TRIM command. Each payload can carry 64 TRIM ranges since each range requires 8 bytes. It is silly to keep doing the calculation (512 / 8) in different places. Hence, define the new ATA_MAX_TRIM_RNUM for th

Re: [PATCH v3 2/2] libata-scsi: avoid repeated calculation of number of TRIM ranges

2016-07-06 Thread Tom Yan
Oops I missed the block limit VPD this time. Will send a v4. On 7 July 2016 at 00:44, wrote: > From: Tom Yan > > Currently libata statically allows only 1-block (512-byte) payload > for each TRIM command. Each payload can carry 64 TRIM ranges since > each range requires 8 bytes. > > It is silly

[PATCH v4 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

2016-07-06 Thread tom . ty89
From: Tom Yan Currently if a WRITE SAME (16) command is issued to the SATL with "number of blocks" that is larger than the "Maximum write same length" (which is the maximum number of blocks per TRIM command allowed in libata, currently 65535 * 512 / 8 blocks), the SATL will accept the command and

[PATCH v4 2/2] libata-scsi: avoid repeated calculation of number of TRIM ranges

2016-07-06 Thread tom . ty89
From: Tom Yan Currently libata statically allows only 1-block (512-byte) payload for each TRIM command. Each payload can carry 64 TRIM ranges since each range requires 8 bytes. It is silly to keep doing the calculation (512 / 8) in different places. Hence, define the new ATA_MAX_TRIM_RNUM for th

Re: [PATCH v4 2/2] libata-scsi: avoid repeated calculation of number of TRIM ranges

2016-07-06 Thread Tom Yan
I decided not to define a macro (e.g. ATA_MAX_TRIM_RSIZE) for all the 0x / 65535 in the various functions in libata-scsi.c / ata.h. Let me know if you think I should. On 7 July 2016 at 00:55, wrote: > From: Tom Yan > > Currently libata statically allows only 1-block (512-byte) payload > for

Re: [PATCH v3 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

2016-07-06 Thread Sergei Shtylyov
On 07/06/2016 07:44 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently if a WRITE SAME (16) command is issued to the SATL with "number of blocks" that is larger than the "Maximum write same length" (which is the maximum number of blocks per TRIM command allowed in libata, currently 65535 *

[PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-06 Thread tom . ty89
From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation code" instead. Signed-off-by: Tom Yan diff --gi

[PATCH resend 2/2] libata-scsi: correct cbd to CDB in comment

2016-07-06 Thread tom . ty89
From: Tom Yan It's Command Descriptor Block. Also capitalized it. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index f1125fd..c9cd216 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -304,7 +304,7 @@ static void ata_scsi_set

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

2016-07-06 Thread Varun Prakash
On Wed, Jul 06, 2016 at 12:24:43AM +0300, Or Gerlitz wrote: > On Thu, May 26, 2016 at 9:58 PM, Varun Prakash wrote: > > > Hi Or, Nicholas and Steve > > Thank you for the feedback and apologies for the delay in my response. > > > I agree that we can refactor initiator, target and iwarp drivers to

Re: [PATCH v3 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

2016-07-06 Thread Tom Yan
I am so sorry. Now I hate acronym. v5 coming. :-) On 7 July 2016 at 01:02, Sergei Shtylyov wrote: > On 07/06/2016 07:44 PM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> Currently if a WRITE SAME (16) command is issued to the SATL with >> "number of blocks" that is larger than the "Maximum

[PATCH v5 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

2016-07-06 Thread tom . ty89
From: Tom Yan Currently if a WRITE SAME (16) command is issued to the SATL with "number of blocks" that is larger than the "Maximum write same length" (which is the maximum number of blocks per TRIM command allowed in libata, currently 65535 * 512 / 8 blocks), the SATL will accept the command and

[PATCH v5 2/2] libata-scsi: avoid repeated calculation of number of TRIM ranges

2016-07-06 Thread tom . ty89
From: Tom Yan Currently libata statically allows only 1-block (512-byte) payload for each TRIM command. Each payload can carry 64 TRIM ranges since each range requires 8 bytes. It is silly to keep doing the calculation (512 / 8) in different places. Hence, define the new ATA_MAX_TRIM_RNUM for th

Re: [PATCH resend 2/2] libata-scsi: correct cbd to CDB in comment

2016-07-06 Thread Tejun Heo
On Thu, Jul 07, 2016 at 01:13:09AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > It's Command Descriptor Block. Also capitalized it. > > Signed-off-by: Tom Yan Applied to libata/for-4.8. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-06 Thread Tejun Heo
On Thu, Jul 07, 2016 at 01:13:08AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > It does not make sense and is confusing to respond with "Invalid > field in CDB" while we have no support at all implemented for > FORMAT UNIT. It is decent to let it go to the default, which > will respond wi

[PATCH 00/21] lpfc: Update to revision 11.2.0.0

2016-07-06 Thread James Smart
This patch set updates the lpfc driver to revision 11.2.0.00 The patches were cut against scsi-misc James Smart (21): Fix Transgression Flag of Optical Element descriptor for RDP on Linux Correct RDP response sizing issue Add recovery from adapter parity errors on some SLI4 adapters Corr

[PATCH 09/21] lpfc: Correct FCOE discovery to avoid loss of storage devices after system reboot

2016-07-06 Thread James Smart
Correct FCOE discovery to avoid loss of storage devices after system reboot Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init

[PATCH 04/21] lpfc: Correct Buffer credit descriptor values in RDP response

2016-07-06 Thread James Smart
Correct Buffer credit descriptor values in RDP response Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 74 +++- drivers/scsi/lpfc/lpfc_hw.h | 2 +- 2 files changed, 32 insertions(+), 44 deletions(-) diff --gi

[PATCH 16/21] lpfc: Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode

2016-07-06 Thread James Smart
Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- drivers/scsi/lpfc/lpfc_crtn.h | 1 - drivers/scsi/lpfc/lpfc_sli.c | 12

[PATCH 05/21] lpfc: Reject RDP ELS if port has no login

2016-07-06 Thread James Smart
Reject RDP ELS if port has no login Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 02e3a1f..861270e 100644 --- a/drivers/scsi/lpf

[PATCH 02/21] lpfc: Correct RDP response sizing issue

2016-07-06 Thread James Smart
Correct RDP response sizing issue Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 113 --- drivers/scsi/lpfc/lpfc_hw.h | 26 +++--- 2 files changed, 81 insertions(+), 58 deletions(-) diff --git a/drivers/s

[PATCH 01/21] lpfc: Fix Transgression Flag of Optical Element descriptor for RDP on Linux

2016-07-06 Thread James Smart
Fix Transgression Flag of Optical Element descriptor for RDP on Linux Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 12 + drivers/scsi/lpfc/lpfc_els.c | 101 +- drivers/scsi/lpfc/lpfc_hw.h | 6 +++ d

[PATCH 14/21] lpfc: Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv

2016-07-06 Thread James Smart
Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- drivers/scsi/lpfc/lpfc_crtn.h | 1 - drivers/scsi/lpfc/lpfc_init.c | 24 +--- 3 files change

[PATCH 13/21] lpfc: Correct Port reset resulting in FC port going offline

2016-07-06 Thread James Smart
Correct Port reset resulting in FC port going offline Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 6e11574..f4b3

[PATCH 03/21] lpfc: Add recovery from adapter parity errors on some SLI4 adapters

2016-07-06 Thread James Smart
Add recovery from adapter parity errors on some SLI4 adapters Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 2 + drivers/scsi/lpfc/lpfc_hw4.h | 23 drivers/scsi/lpfc/lpfc_init.c | 118 +++--- drivers/

[PATCH 12/21] lpfc: Add support for XLane LUN priority

2016-07-06 Thread James Smart
Add support for XLane LUN priority Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_attr.c | 89 +-- drivers/scsi/lpfc/lpfc_crtn.h | 2 +- drivers/scsi/lpfc/lpfc_scsi.c | 9 - d

[PATCH 08/21] lpfc: Fix SLI mode 2 config failure

2016-07-06 Thread James Smart
Fix SLI mode 2 config failure Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 6eef972..b1ddbaa 100644 --- a/drivers/scsi/lpfc/lpfc_sli

[PATCH 17/21] lpfc: Re-organize source for easier driver attribute management

2016-07-06 Thread James Smart
Re-organize source for easier driver attribute management Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 97 +-- drivers/scsi/lpfc/lpfc_attr.h | 116 ++ 2 files changed, 117 ins

[PATCH 19/21] lpfc: Disable FDMI probing if not connected to a fabric

2016-07-06 Thread James Smart
Disable FDMI probing if not connected to a fabric Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ct.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index a38816e..63e48d4 100644 --- a/drivers

[PATCH 21/21] lpfc: Update lpfc version to 11.2.0.0

2016-07-06 Thread James Smart
Update lpfc version to 11.2.0.0 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index fa0d531..c9bf20e 100644 ---

[PATCH 07/21] lpfc: Add MDS Diagnostics Support

2016-07-06 Thread James Smart
Add MDS Diagnostics Support Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 4 ++- drivers/scsi/lpfc/lpfc_attr.c | 10 +++ drivers/scsi/lpfc/lpfc_els.c | 7 + drivers/scsi/lpfc/lpfc_hw4.h | 14 +- drivers/scsi/lpfc/lpfc_init.c | 28

[PATCH 18/21] lpfc: Correct issue with ioremap() call on 32bit kernel

2016-07-06 Thread James Smart
Correct issue with ioremap() call on 32bit kernel Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h index 4d9f1b1..b484859 100644 ---

[PATCH 11/21] lpfc: Correct RDP response Revision location

2016-07-06 Thread James Smart
Correct RDP response Revision location Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index c99c2b3..8226543 100644 --- a/driver

[PATCH 10/21] lpfc: Re-organize source for easier device-id management

2016-07-06 Thread James Smart
Re-organize source for easier device-id management Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ids.h | 122 ++ drivers/scsi/lpfc/lpfc_init.c | 101 +- 2 files changed, 123 insertions(

[PATCH 20/21] lpfc: Copyright updates

2016-07-06 Thread James Smart
Copyright updates Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_crtn.h | 2 +- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- drivers/scsi/lpfc/lpfc_scsi.h | 2 +- drivers/scsi/lpfc/lpfc_sli.h | 2 +- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 5 files changed, 5 insertio

[PATCH 06/21] lpfc: Add sysfs proc_name support

2016-07-06 Thread James Smart
Add sysfs proc_name support Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 3bd0be6..12b8e82 100644 --- a/drivers/scsi/lpfc/lpfc_s

[PATCH 15/21] lpfc: Remove global lpfc_delay_discovery attribute in leiu of per-hba lpfc_delay_discovery

2016-07-06 Thread James Smart
Remove global lpfc_delay_discovery attribute in leiu of per-hba lpfc_delay_discovery Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_attr.c | 8 +++- drivers/scsi/lpfc/lpfc_crtn.h | 1 - drivers/scsi/lpfc/lpfc_els.c |

[PATCH 1/2] libata-scsi: do not return designator for serial number

2016-07-06 Thread tom . ty89
From: Tom Yan SAT (as of sat4r05f.pdf) does not require this vendor specific designator. Besides, we already have the Unit Serial Number VPD. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..9f478ad 100644 --- a/drivers/ata/libata-scsi.c

[PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-06 Thread tom . ty89
From: Tom Yan SAT (as of sat4r05f.pdf) only requires the t10 designator if the drive does not support/have WWN. Besides, we already have the ATA information VPD. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 9f478ad..84b3d42 100644 --- a/driver

Zpráva pro vás

2016-07-06 Thread Bertphl
Mam investicni zajem, pro ktere hledame vasi ucast jako prijemce. Odpoved na e-mailu nize v pripade zajmu. e-mail: pbrt...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

[PATCH 2/2] libata-scsi: better style in ata_msense_caching()

2016-07-06 Thread tom . ty89
From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..e3f5751 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2424,10 +2424,12 @@ static void modecpy(u8 *dest, const u8 *src, int n, bool changeable) st

[PATCH 1/2] libata-scsi: fix SET FEATURES "filtering" for ata_msense_caching()

2016-07-06 Thread tom . ty89
From: Tom Yan Without this fix, the DRA bit of the caching mode page would not be updated when the read look-ahead feature is toggled (e.g. with `smartctl --set`), but will only be until, for example, the write cache feature is touched. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-co

Re: [Nouveau] [PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-06 Thread Alexandre Courbot
On Wed, Jul 6, 2016 at 7:56 AM, Joe Perches wrote: > On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: >> On 5 July 2016 at 15:14, Joe Perches wrote: >> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> > > This series introduces a family of generic string case conversion >> > > fu