From: Tom Yan <tom.t...@gmail.com>

It does not make sense and is confusing to respond with "Invalid
field in CDB" while we have no support at all implemented for
FORMAT UNIT. It is decent to let it go to the default, which
will respond with "Invalid command operation code" instead.

Signed-off-by: Tom Yan <tom.t...@gmail.com>

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index bfec66f..f1125fd 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4039,11 +4039,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct 
scsi_cmnd *cmd)
        args.done = cmd->scsi_done;
 
        switch(scsicmd[0]) {
-       /* TODO: worth improving? */
-       case FORMAT_UNIT:
-               ata_scsi_invalid_field(dev, cmd, 0);
-               break;
-
        case INQUIRY:
                if (scsicmd[1] & 2)                /* is CmdDt set?  */
                    ata_scsi_invalid_field(dev, cmd, 1);
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to