Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Ondrej Zary
On Sunday 29 November 2015 01:46:03 Finn Thain wrote: > > On Sun, 29 Nov 2015, Ondrej Zary wrote: > > > > [...] I think that this should solve the problem: > > > > Yes, it does! > > > > [ 48.119367] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > > n_io_port 0, base 0xd8000, irq 0

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Geert Uytterhoeven
Hi Finn, On Thu, Nov 26, 2015 at 11:32 PM, Finn Thain wrote: >> The timekeeping warning does not appear when all 71 patches are applied. >> Reverse-bisected it - the warning disappears after: >> [PATCH 50/71] ncr5380: Change instance->host_lock to hostdata->lock >> > > Makes sense. I think that t

[RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A

2015-11-29 Thread Ondrej Zary
Add I/O register mapping for NCR53C400A and enable PDMA mode to improve performance and fix non-working IRQ. Tested with HP C2502 (and user-space enabler). Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/d

[RFC PATCH 73/71] ncr5380: Use runtime register mapping

2015-11-29 Thread Ondrej Zary
Convert compile-time C400_ register mapping to runtime mapping. This removes the weird negative register offsets and allows adding additional mappings. Signed-off-by: Ondrej Zary --- drivers/scsi/NCR5380.h | 13 +- drivers/scsi/g_NCR5380.c | 61 ++---

[RFC PATCH 75/71] ncr5380: Remove FLAG_DTC3181E

2015-11-29 Thread Ondrej Zary
The FLAG_DTC3181E is used to activate a work-around for arbitration lost condition that these chips see when ICR is written during arbitration. Move the ICR write (to set SEL and BSY) after the arbitration loss check and remove FLAG_DTC3181E. Signed-off-by: Ondrej Zary --- Weird, we now have two

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Finn Thain
On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: > This still heavily depends on the processing time spent in > NCR5380_read(). You should never use a value derived from > loops_per_jiffy for a non-empty loop, Sure but the time-out condition isn't supposed to be precise. Plus/minus a jiffy is no

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Markus Trippelsdorf
On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: > On Thu, Nov 26 2015 at 2:46am -0500, > Hannes Reinecke wrote: > > > When a cloned request is retried on other queues it always needs > > to be checked against the queue limits of that queue. > > Otherwise the calculations for nr_phys_segments m

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Geert Uytterhoeven
Hi Finn, On Sun, Nov 29, 2015 at 11:25 AM, Finn Thain wrote: > On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: >> This still heavily depends on the processing time spent in >> NCR5380_read(). You should never use a value derived from >> loops_per_jiffy for a non-empty loop, > > Sure but the time-o

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: >> On Thu, Nov 26 2015 at 2:46am -0500, >> Hannes Reinecke wrote: >> >>> When a cloned request is retried on other queues it always needs >>> to be checked against the queue limits of that queue

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Markus Trippelsdorf
On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: > On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > > On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: > >> On Thu, Nov 26 2015 at 2:46am -0500, > >> Hannes Reinecke wrote: > >> > >>> When a cloned request is retried on other queues it alwa

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Mike Snitzer
On Sun, Nov 29 2015 at 11:15am -0500, Markus Trippelsdorf wrote: > On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: > > On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > > > > > > I'm still seeing the issue (BUG at drivers/scsi/scsi_lib.c:1096!) even > > > with this patch applied. > > >

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Markus Trippelsdorf
On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: > On Sun, Nov 29 2015 at 11:15am -0500, > Markus Trippelsdorf wrote: > > > On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: > > > On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > > > > > > > > I'm still seeing the issue (BUG at drivers/sc

Re: [PATCH] target: use offset_in_page macro

2015-11-29 Thread Nicholas A. Bellinger
Hi Geliang, On Wed, 2015-11-25 at 21:49 +0800, Geliang Tang wrote: > Use offset_in_page macro instead of (addr & ~PAGE_MASK). > > Signed-off-by: Geliang Tang > --- > drivers/target/target_core_user.c | 2 +- > drivers/target/tcm_fc/tfc_io.c| 8 > 2 files changed, 5 insertions(+), 5

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Finn Thain
On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: > If an ISA access takes 8 us, while the CPU runs at 1 GHz, i.e. 500M > loops/s, the difference will be huge. Ondrej showed that an ISA access can take about 1.6 us. I don't know what to make of the "8 uS" comment in the mainline driver. Maybe it

Re: [RFC PATCH 75/71] ncr5380: Remove FLAG_DTC3181E

2015-11-29 Thread Finn Thain
On Sun, 29 Nov 2015, Ondrej Zary wrote: > The FLAG_DTC3181E is used to activate a work-around for arbitration lost > condition that these chips see when ICR is written during arbitration. > > Move the ICR write (to set SEL and BSY) after the arbitration loss check > and remove FLAG_DTC3181E. Th

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Ming Lei
On Sun, 29 Nov 2015 18:05:06 +0100 Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: > > On Sun, Nov 29 2015 at 11:15am -0500, > > Markus Trippelsdorf wrote: > > > > > On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: > > > > On 11/29/2015 12:49 PM, Markus Trippe

Re: [PATCH] scsi: ufs: fix spelling mistake in error message

2015-11-29 Thread Johannes Thumshirn
Zitat von Colin King : From: Colin Ian King Minor issue, fix spelling mistake, Intialization -> Initialization Signed-off-by: Colin Ian King --- drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: >> On Sun, Nov 29 2015 at 11:15am -0500, >> Markus Trippelsdorf wrote: >> >>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > >>

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Markus Trippelsdorf
On 2015.11.30 at 14:11 +0800, Ming Lei wrote: > On Sun, 29 Nov 2015 18:05:06 +0100 > Markus Trippelsdorf wrote: > > > > No, I'm not using DM multipath. > > > OK, I guess it is still one block merge issue, care to test the > following patch? > > The patch can address one issue when bio->bi_seg