Use logical instead of bitwise AND.
Signed-off-by: Sebastian Herbszt
---
diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-05 22:18:43.933739150 +0200
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-22 10:31:14.2402094
On 21.7.2015 19:59, rajinikanth.panduran...@pmcs.com wrote:
> From: Rajinikanth Pandurangan
>
> Description:
> As pci_enable_msix() deprecated, replaced with pci_enable_msix_range()
>
> V3 Reviewed/commented by:
> Tomas Henzl
>
> Changes from V3:
> Uses pci_enable_msix_rang
Hello Tomas,
Yes, in case of failure, we'll fall into msi.
Thanks,
-Original Message-
From: Tomas Henzl [mailto:the...@redhat.com]
Sent: Wednesday, July 22, 2015 6:56 AM
To: Rajinikanth Pandurangan; jbottom...@parallels.com;
linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Y
On 22.7.2015 16:55, Rajinikanth Pandurangan wrote:
> Hello Tomas,
>
> Yes, in case of failure, we'll fall into msi.
Well ok, if you want support msi-x mode only with exactly 8 msi-x
lines, that's fine...
But because it creates another functional change - (before this patch
also values lower than
On 18.7.2015 18:12, Don Brace wrote:
> Reported-by: Dan Carpenter
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c |9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a
On 18.7.2015 18:12, Don Brace wrote:
> Reported-by: Dan Carpenter
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
On 18.7.2015 18:12, Don Brace wrote:
> Reported-by: Dan Carpenter
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c |4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/driv
On 18.7.2015 18:12, Don Brace wrote:
> From: Joe Handzik
>
> host no, bus, target, lun, scsi_device_type
> for hba mode add: box and bay information
>
> report if the path is active/inactive
>
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Don Brace
Reviewed-by: Toma
On 18.7.2015 18:12, Don Brace wrote:
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
On 18.7.2015 18:12, Don Brace wrote:
> showing that tables have been updated unnecessarily.
>
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c |6 +++---
> 1 file changed, 3 insertions(+), 3 dele
On 18.7.2015 18:13, Don Brace wrote:
> The driver is calling hpsa_shutdown before calling scsi_remove_host.
> hpsa_shutdown is disabling interrupts.
>
> scsi_remove_host can trigger I/O operations, such as
> SYNCHRONIZE CACHE when multipath is enabled which hang the system.
>
> Call scsi_remove_h
On 18.7.2015 18:13, Don Brace wrote:
> From: Scott Benesh
>
> prevent adding volumes that are not available.
>
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Reviewed-by: Justin Lindley
> Signed-off-by: Don Brace
Reviewed-by: Tomas Henzl
Tomas
> ---
> drivers/scsi/hpsa.c |
On 18.7.2015 18:13, Don Brace wrote:
> From: shane.seymour
>
> A regression was introduced into the hpsa driver a while back so
> non-zero LUNs of multi-LUN devices may no longer be presented via
> a SAS based Smart Array. I have not done a bisection to discover
> the change that caused it.
>
>
Reviewed-by: James Smart
Thanks
-- james
On 7/22/2015 4:53 AM, Sebastian Herbszt wrote:
Use logical instead of bitwise AND.
Signed-off-by: Sebastian Herbszt
---
diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-
Ok. will follow-up with new patch. We probably lower it to 4 instead of 8 :).
Thanks,
-Original Message-
From: Tomas Henzl [mailto:the...@redhat.com]
Sent: Wednesday, July 22, 2015 8:10 AM
To: Rajinikanth Pandurangan; jbottom...@parallels.com;
linux-scsi@vger.kernel.org
Cc: aacr...@pmc-
From: Rajinikanth Pandurangan
Description:
Driver sends the right size of the response buffer.
Changes from V2:
None
V2:
Reviewed-by: Johannes Thumshirn
Reviewed-by: Tomas Henzl
Reviewed-by: Mahesh Rajashekhara
Signed-off-by: Rajinikanth Pandurangan
---
drivers/scsi/aacraid/aachba
From: Rajinikanth Pandurangan
Description:
This change always sets MSI interrupt mode for series-6 controller.
Note: For series 6 family, MSIx is not supported.
Changes from V2:
Only Subject & description change.
Reviewed by:
Tomas Henzl ,
Mahesh Rajashekhara ,
Johannes Thumshirn
S
From: Rajinikanth Pandurangan
Description:
* .suspend() and .resume() routines implemented in the driver
* aac_release_resources() initiates firmware shutdown
* aac_acquire_resources re-initializes the host interface
Changes from V2:
Increased msleep(1) to msleep(20)
Reve
From: Rajinikanth Pandurangan
This patchset includes the following changes (bug fixes and new feature support)
specific to aacraid driver.
V5:
Splited patch 10 from V4 into 2
Added one more patch to request minimum 2 MSIx.
V4:
Updated code with pci_enable_msix_range instead of exact.
V3:
Incre
From: Rajinikanth Pandurangan
Description:
Reset irq affinity hints before releasing IRQ
Removed duplicate code of IRQ acquire/release
Changes from V2:
None
Reviewed by:
Mahesh Rajashekhara ,
Johannes Thumshirn
Signed-off-by: Rajinikanth Pandurangan
---
drivers/scsi/aacrai
From: Rajinikanth Pandurangan
Description:
If writeq() not supported, then do atomic two 32bit write
Changes from V2:
None
Reviewed by:
Tomas Henzl ,
Mahesh Rajashekhara ,
Johannes Thumshirn
Signed-off-by: Rajinikanth Pandurangan
---
drivers/scsi/aacraid/aacraid.h | 9 +
From: Rajinikanth Pandurangan
Signed-off-by: Rajinikanth Pandurangan
---
drivers/scsi/aacraid/aacraid.h | 2 +-
drivers/scsi/aacraid/linit.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 7b95227..73
From: Rajinikanth Pandurangan
Description:
If 'IsFastPath' bit is set, then response path assumes no error
and skips error check.
Changes from V2:
None
Reviewed By:
Tomas Henzl ,
Mahesh Rajashekhara ,
Johannes Thumshirn
Signed-off-by: Rajinikanth Pandurangan
---
drivers/s
From: Rajinikanth Pandurangan
Description:
As pci_enable_msix() deprecated, replaced with pci_enable_msix_range()
V4 Reviewed/commented by:
Tomas Henzl
Changes from V4:
Changed to 1 as minimum msix range in pci_enable_msix_range()
to match with original code.
Signed-of
From: Rajinikanth Pandurangan
Description:
Controller BIOS/UEFI driver used to send this request. But for
IBM-Power system there is no BIOS/UEFI driver. So this change is
required for IBM, otherwise controller will be read-only mode.
Changes from V2:
None
Reviewed by:
From: Rajinikanth Pandurangan
Description:
Driver blocks ioctls once it received shutdown/suspend request during
suspend/hybernation. This patch unblocks ioctls on resume path.
Changes from V2:
None
Reviewed by:
Mahesh Rajashekhara ,
Johannes Thumshirn
Signed-off-by: Rajinik
From: Rajinikanth Pandurangan
Description:
In MSIx mode, we need at least 2 vectors.
Changes from V4:
Newly created for V5 based on review comment.
Signed-off-by: Rajinikanth Pandurangan
---
drivers/scsi/aacraid/comminit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
https://bugzilla.kernel.org/show_bug.cgi?id=101011
taz-...@latribu.com changed:
What|Removed |Added
CC||taz-...@latribu.com
--- Comment #5
On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote:
> Praveen reports:
>
> After some debugging this is what I have found
>
> sas_phye_loss_of_signal gets triggered on phy_event from mvsas
> sas_phye_loss_of_signal calls sas_deform_port
> sas_deform_port posts a DI
On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley
wrote:
> On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote:
>> Praveen reports:
>>
>> After some debugging this is what I have found
>>
>> sas_phye_loss_of_signal gets triggered on phy_event from mvsas
>> sas_phye_loss_of_signal
From: Joern Engel
Make the warning about unsupported SCSI opcode more useful:
- Add in the initiator name so we know who's sending it.
- Print the warning even for opcodes that spc_parse_cdb() knows about
but that we don't handle.
Signed-off-by: Joern Engel
Signed-off-by: Spencer Baugh
-
From: Roland Dreier
It's not necessarily a fatal error if a command with a data-out phase
has a data length that differs from the transport data length (e.g.
PERSISTENT RESERVE OUT might have a parameter list length in the CDB
that's smaller than the FC_DL field), so allow these commands. The
Wi
From: Roland Dreier
Solaris seems to go beserk if we respond to REPORT LUNS with a
LUN LIST LENGTH of 0.
Signed-off-by: Roland Dreier
Signed-off-by: Spencer Baugh
---
drivers/target/target_core_spc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/target/target_core_spc.c b
From: Roland Dreier
In a performance profile, taking a mutex in iscsit_increment_maxcmdsn()
shows up very high. However taking a mutex around "sess->max_cmd_sn += 1"
seems pretty silly: we're not serializing against other contexts in
any useful way.
I did a quick audit and there don't appear to
From: Joern Engel
We don't touch the return value of qla2x00_loop_resync in
qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
Signed-off-by: Joern Engel
Signed-off-by: Spencer Baugh
---
drivers/scsi/qla2xxx/qla_os.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-
On 7/22/15, 3:08 PM, "Spencer Baugh" wrote:
>From: Joern Engel
>
>We don't touch the return value of qla2x00_loop_resync in
>qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
>
>Signed-off-by: Joern Engel
>Signed-off-by: Spencer Baugh
>---
> drivers/scsi/qla2xxx/qla_os.
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> ow...@vger.kernel.org] On Behalf Of Spencer Baugh
> Sent: Wednesday, July 22, 2015 5:08 PM
> Subject: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn
> increment
...
> diff --git a/drivers/targ
37 matches
Mail list logo
