On 21.7.2015 19:59, rajinikanth.panduran...@pmcs.com wrote:
> From: Rajinikanth Pandurangan <rajinikanth.panduran...@pmcs.com>
> 
> Description:
>         As pci_enable_msix() deprecated, replaced with pci_enable_msix_range()
> 
> V3 Reviewed/commented by:
>       Tomas Henzl <the...@redhat.com>
> 
> Changes from V3:
>       Uses pci_enable_msix_range() instead of pci_enable_msix_exact()
> based on review comment.
> 
> Signed-off-by: Rajinikanth Pandurangan <rajinikanth.panduran...@pmcs.com>
> ---
>  drivers/scsi/aacraid/comminit.c | 20 ++++++--------------
>  1 file changed, 6 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
> index b4b6088..3ba6e97 100644
> --- a/drivers/scsi/aacraid/comminit.c
> +++ b/drivers/scsi/aacraid/comminit.c
> @@ -338,7 +338,7 @@ static int aac_comm_init(struct aac_dev * dev)
>  
>  void aac_define_int_mode(struct aac_dev *dev)
>  {
> -     int i, msi_count;
> +     int i, msi_count, min_msix;
>  
>       msi_count = i = 0;
>       /* max. vectors from GET_COMM_PREFERRED_SETTINGS */
> @@ -366,22 +366,14 @@ void aac_define_int_mode(struct aac_dev *dev)
>  
>       if (msi_count > 1 &&
>           pci_find_capability(dev->pdev, PCI_CAP_ID_MSIX)) {
> -             i = pci_enable_msix(dev->pdev,
> +             min_msix = 8;
That^ will make the pci-enable function fail on boxes with less than
eight num-online-cpus

-tm

> +             i = pci_enable_msix_range(dev->pdev,
>                                   dev->msixentry,
> +                                 min_msix,
>                                   msi_count);
> -              /* Check how many MSIX vectors are allocated */
> -             if (i >= 0) {
> +             if (i > 0) {
>                       dev->msi_enabled = 1;
> -                     if (i) {
> -                             msi_count = i;
> -                             if (pci_enable_msix(dev->pdev,
> -                                 dev->msixentry,
> -                                 msi_count)) {
> -                                     dev->msi_enabled = 0;
> -                                     printk(KERN_ERR "%s%d: MSIX not 
> supported!! Will try MSI 0x%x.\n",
> -                                                     dev->name, dev->id, i);
> -                             }
> -                     }
> +                     msi_count = i;
>               } else {
>                       dev->msi_enabled = 0;
>                       printk(KERN_ERR "%s%d: MSIX not supported!! Will try 
> MSI 0x%x.\n",
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to