From: "Lad, Prabhakar"
this patch fixes following sparse warnings:
scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared. Should
it be static?
scsi_sysfs.c:376:24: warning: symbol 'scsi_shost_attr_group' was not declared.
Should it be static?
Signed-off-by: Lad, Prabhakar
--
From: "Lad, Prabhakar"
this patch fixes following sparse warning:
bfa_core.c:716:1: warning: symbol 'bfa_isr_rspq' was not declared. Should it be
static?
Signed-off-by: Lad, Prabhakar
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-
From: "Lad, Prabhakar"
this patch fixes following sparse warning:
scsi_debug.c:2687:6: warning: symbol 'dump_sector' was not declared. Should it
be static?
Signed-off-by: Lad, Prabhakar
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linu
On 02/05/15 10:41, Lad Prabhakar wrote:
> this patch fixes following sparse warnings:
> scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared.
> Should it be static?
> scsi_sysfs.c:376:24: warning: symbol 'scsi_shost_attr_group' was not
> declared. Should it be static?
Reviewed
From: "Lad, Prabhakar"
this patch fixes following sparse warnings:
initio.c:338:6: warning: symbol 'initio_se2_ew_en' was not declared. Should it
be static?
initio.c:352:6: warning: symbol 'initio_se2_ew_ds' was not declared. Should it
be static?
initio.c:897:22: warning: symbol 'initio_find_b
From: "Lad, Prabhakar"
this patch fixes following sparse warning:
dc395x.c:1525:17: warning: Using plain integer as NULL pointer
Signed-off-by: Lad, Prabhakar
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/scsi/dc395
From: "Lad, Prabhakar"
this patch fixes following sparse warning:
eata.c:2049:5: warning: symbol 'eata2x_bios_param' was not declared. Should it
be static?
Signed-off-by: Lad, Prabhakar
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linu
From: "Lad, Prabhakar"
this patch fixes following sparse warnings:
qla1280.c:557:1: warning: symbol 'qla1280_firmware_mutex' was not declared.
Should it be static?
qla1280.c:566:15: warning: symbol 'qla1280_fw_tbl' was not declared. Should it
be static?
Signed-off-by: Lad, Prabhakar
---
Fou
From: "Lad, Prabhakar"
this patch fixes following sparse warnings:
ips.c:784:5: warning: symbol 'ips_eh_abort' was not declared. Should it be
static?
ips.c:1277:1: warning: symbol 'ips_intr_copperhead' was not declared. Should it
be static?
ips.c:1341:1: warning: symbol 'ips_intr_morpheus' was
I've encountered a race condition which causes the UFS driver to receive
requests with an invalid tag (-1),
and wondering how to go about solving the case.
Consider the following scenario:
1. scsi_request_fn() -> scsi_dispatch_cmd() -> host->hostt->queuecommand()
(mapped to ufshcd_queuecommand)
2
SCSI transport drivers and SCSI LLDs block a SCSI device if the
transport layer is not operational. This means that in this state
no requests should be processed, even if the REQ_PREEMPT flag has
been set. This patch avoids that a rescan shortly after a cable
pull sporadically triggers the followin
On 02/03/2015 06:28 PM, micha...@cs.wisc.edu wrote:
> From: Mike Christie
>
> iBFT and non-iBFT drivers use the same iscsi boot sysfs
> interface. For iBFT we just directly export whatever
> is left by the FW. For non-iBFT drivers we do vendor
> specific commands to get the info or its just hard
> On 2.2.2015, at 17.16, Laurence Oberman wrote:
>
> I pulled this this morning and will be testing. The prior version was
> stable for me on the upstream and RHEL 6.5 kernel without exhaustive
> testing.
> We also just received more requests to get this into RHEL from HP /
> Red Hat customers.
- Original Message -
From: "Kai Mäkisara (Kolumbus)"
To: "Laurence Oberman"
Cc: "Shane M Seymour" , lober...@redhat.com,
linux-scsi@vger.kernel.org, "James E.J. Bottomley (jbottom...@parallels.com)"
, je...@suse.com
Sent: Thursday, February 5, 2015 12:03:29 PM
Subject: Re: [PATCH] st: i
> On 5.2.2015, at 19.40, Laurence Oberman wrote:
>
> - Original Message -
> From: "Kai Mäkisara (Kolumbus)"
> To: "Laurence Oberman"
> Cc: "Shane M Seymour" , lober...@redhat.com,
> linux-scsi@vger.kernel.org, "James E.J. Bottomley (jbottom...@parallels.com)"
> , je...@suse.com
> Sen
This patch set is fixing two serious problems which have turned up late
in the release cycle. The first fixes a problem with 4k sector disks
where the transfer length (amount of data sent to the disk) was getting
increased every time the disk was revalidated leading to potential for
overflows. Th
- Original Message -
From: "Kai Mäkisara (Kolumbus)"
To: "Laurence Oberman"
Cc: "Laurence Oberman" , "Shane M Seymour"
, linux-scsi@vger.kernel.org, "James E.J. Bottomley
(jbottom...@parallels.com)" , je...@suse.com
Sent: Thursday, February 5, 2015 12:46:32 PM
Subject: Re: [PATCH] st: i
On Thu, 2015-02-05 at 19:46 +0200, "Kai Mäkisara (Kolumbus)" wrote:
> > On 5.2.2015, at 19.40, Laurence Oberman wrote:
> > I missed the earlier conversations with James, I will go search for them.
> > Do you mean add them so they are similar to the /proc/diskstats
> >
> > cat /proc/diskstats
> >
On Thu, Feb 05, 2015 at 07:46:32PM +0200, "Kai Mäkisara (Kolumbus)" wrote:
> > On 5.2.2015, at 19.40, Laurence Oberman wrote:
> > From: "Kai Mäkisara (Kolumbus)"
> > I still think that the tape statistics should be exported like the
> > statistics of “real” block devices, i.e., one sysfs file ex
On Thu, 2015-02-05 at 18:50 +, Bryn M. Reeves wrote:
> On Thu, Feb 05, 2015 at 07:46:32PM +0200, "Kai Mäkisara (Kolumbus)" wrote:
> > > On 5.2.2015, at 19.40, Laurence Oberman wrote:
> > > From: "Kai Mäkisara (Kolumbus)"
> > > I still think that the tape statistics should be exported like the
On Thu, Feb 05, 2015 at 10:55:50AM -0800, James Bottomley wrote:
> OK, the sysfs bikeshedders hang out on linux-api
>
> https://www.kernel.org/doc/man-pages/linux-api-ml.html
>
> If you can convince them, we'll do the single file approach.
Will do - I've got a couple of stats projects on the go
This patch set updates the lpfc driver to revision 10.5.0.0
The patches were cut against Christoph's scsi-queue.git,
branch "drivers-for-3.20".
-- james s
James Smart (21):
Fix the iteration count to match the 30 sec comment
Add Lancer Temperature Event support to the lpfc driver
EnableB
---
drivers/scsi/lpfc/lpfc_hw4.h | 1 +
drivers/scsi/lpfc/lpfc_init.c | 179 +-
2 files changed, 125 insertions(+), 55 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h
index f432ec1..3121ec4 100644
--- a/drivers/scsi
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 0b2c53a..2b5b910 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7953,7 +7953,7 @@ wait:
---
drivers/scsi/lpfc/lpfc_crtn.h | 1 +
drivers/scsi/lpfc/lpfc_init.c | 11 ---
drivers/scsi/lpfc/lpfc_scsi.c | 25 +
3 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
index 00665a5..665c
---
drivers/scsi/lpfc/lpfc_attr.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 2f9b968..374aa03 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -406,8 +406,13 @@ lpfc
---
drivers/scsi/lpfc/lpfc_bsg.c | 1 +
drivers/scsi/lpfc/lpfc_bsg.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index a7bf359..6b4cf31 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -4179,6 +41
---
drivers/scsi/lpfc/lpfc_init.c | 8
drivers/scsi/lpfc/lpfc_sli.c | 9 +++--
drivers/scsi/lpfc/lpfc_sli4.h | 2 +-
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 74672e0..e01619c 100644
--- a/drive
---
drivers/scsi/lpfc/lpfc_els.c | 3 +--
drivers/scsi/lpfc/lpfc_hbadisc.c | 6 ++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index c66088d..6350563 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi
---
drivers/scsi/lpfc/lpfc_hw4.h | 5 -
drivers/scsi/lpfc/lpfc_init.c | 39 +++
2 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h
index 3121ec4..0b4c5afd6 100644
--- a/drivers/scsi
---
drivers/scsi/lpfc/lpfc_nportdisc.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c
b/drivers/scsi/lpfc/lpfc_nportdisc.c
index 5cc1103..3d93363 100644
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi
---
drivers/scsi/lpfc/lpfc_ct.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 61a32cd..5091184 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -1070,12 +107
---
drivers/scsi/lpfc/lpfc_els.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 9f3c74e..f73d58c 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -5197,7 +5197,6 @@ lpfc_els_rcv_flogi(struct lpfc_
---
drivers/scsi/lpfc/lpfc_scsi.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index f623299..5612ba6 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -5202,10 +5202,12
---
drivers/scsi/lpfc/lpfc_crtn.h| 1 +
drivers/scsi/lpfc/lpfc_els.c | 5
drivers/scsi/lpfc/lpfc_hbadisc.c | 60 +++-
drivers/scsi/lpfc/lpfc_init.c| 24 ++--
drivers/scsi/lpfc/lpfc_sli.c | 49 ++--
---
drivers/scsi/lpfc/lpfc.h | 3 +
drivers/scsi/lpfc/lpfc_attr.c| 16 +-
drivers/scsi/lpfc/lpfc_ct.c | 715 +--
drivers/scsi/lpfc/lpfc_els.c | 2 +-
drivers/scsi/lpfc/lpfc_hbadisc.c | 6 +-
drivers/scsi/lpfc/lpfc_hw.h | 206 +++
---
drivers/scsi/lpfc/lpfc_bsg.c | 1 +
drivers/scsi/lpfc/lpfc_sli.c | 12
drivers/scsi/lpfc/lpfc_sli.h | 1 +
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index 6b4cf31..a05 100644
--- a/drivers/scs
---
drivers/scsi/lpfc/lpfc_els.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index ba5da26..1003b5b 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3337,7 +3337,11 @@ lpfc_els
---
drivers/scsi/lpfc/lpfc_scsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 9ed5f44..fbdc39c 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -5464,9 +5464,10 @@ lpf
---
drivers/scsi/lpfc/lpfc_scsi.c | 41 -
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index fbdc39c..e900902 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc
---
drivers/scsi/lpfc/lpfc.h | 41
drivers/scsi/lpfc/lpfc_attr.c| 65 ++-
drivers/scsi/lpfc/lpfc_crtn.h| 3 +-
drivers/scsi/lpfc/lpfc_hbadisc.c | 3 +
drivers/scsi/lpfc/lpfc_init.c| 24 ++-
drivers/scsi/lpfc/lpfc_mbox.c| 4 +-
drivers/scsi/lpfc/lpfc_scsi.
---
drivers/scsi/lpfc/lpfc_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h
index 9285a6d..c37bb9f 100644
--- a/drivers/scsi/lpfc/lpfc_version.h
+++ b/drivers/scsi/lpfc/lpfc_version.h
@@ -18,7 +18,7 @
---
drivers/scsi/lpfc/lpfc.h | 2 +-
drivers/scsi/lpfc/lpfc_attr.c | 2 +-
drivers/scsi/lpfc/lpfc_bsg.c | 2 +-
drivers/scsi/lpfc/lpfc_bsg.h | 2 +-
drivers/scsi/lpfc/lpfc_crtn.h | 2 +-
drivers/scsi/lpfc/lpfc_ct.c| 2 +-
drivers/scsi/lpfc/lpfc_debugfs.c |
A process context may acquire struct blk_mq_hw_ctx::lock without
disabling IRQs. A deadlock may result if the process context holding
the spinlock is interrupted by an IRQ that calls
scsi_internal_device_unblock(), which may also try to acquire the same
spinlock. Pass 'async = true' to blk_mq_sta
From: Markus Elfring
Date: Thu, 5 Feb 2015 22:02:16 +0100
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scsi/bfa/bfad.c | 6 +++---
From: Markus Elfring
Date: Thu, 5 Feb 2015 22:23:48 +0100
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scsi
From: Markus Elfring
Date: Thu, 5 Feb 2015 23:17:52 +0100
Another update suggestion was taken into account after a patch was applied
from static source code analysis.
Markus Elfring (2):
Delete an unnecessary check before the function call "kfree"
One function call less in lpfc_bsg_hba_set_e
From: Markus Elfring
Date: Thu, 5 Feb 2015 22:45:02 +0100
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scsi
From: Markus Elfring
Date: Thu, 5 Feb 2015 23:03:52 +0100
The kfree() function was called in two cases by the lpfc_bsg_hba_set_event()
function during error handling even if the passed variable "dd_data" contained
still a null pointer.
This implementation detail could be improved by the introduc
Hello linux-api'ers
There has been some ongoing discussion about the best way to implement tape
statistics. The original method suggested a long time ago used a single file in
sysfs similar to block statistics in sysfs. That lead to an impass about the
code on the linux-scsi mailing list.
The
From: Nicholas Bellinger
Hi MST, Paolo, Al & Co,
Here is v4 patch series for vhost/scsi ANY_LAYOUT + VERSION_1 support.
It updates vhost_virtqueue->handle_kick() -> vhost_scsi_handle_vq()
callback code to determine the start of protection + data payloads iovecs
past the starting virtio-scsi req
From: Nicholas Bellinger
Required for ANY_LAYOUT support when the incoming virtio-scsi response
header + fixed size sense buffer payload may span more than a single
iovec entry.
This changes existing code to save cmd->tvc_resp_iov instead of the
first single iovec base pointer from &vq->iov[out]
From: Nicholas Bellinger
This patch fixes vhost_scsi_handle_vq() failure cases that result in BUG_ON()
getting triggered when vhost_scsi_free_cmd() is called, and ->tvc_se_cmd has
not been initialized by target_submit_cmd_map_sgls().
It changes tcm_vhost_release_cmd() to use tcm_vhost_cmd->tvc_n
From: Nicholas Bellinger
With the recent removal of MSG_*_TAG defines in commit 68d81f40,
vhost-scsi is now using TCM_*_TAG and doesn't depend upon host
side scsi_tcq.h definitions anymore.
Cc: Michael S. Tsirkin
Acked-by: Michael S. Tsirkin
Cc: Paolo Bonzini
Signed-off-by: Nicholas Bellinger
From: Nicholas Bellinger
There is a large amount of code that still references the original
'tcm_vhost' naming conventions, instead of modern 'vhost_scsi'.
Go ahead and do a global rename to make the usage consistent.
Cc: Michael S. Tsirkin
Acked-by: Michael S. Tsirkin
Cc: Paolo Bonzini
Sign
From: Nicholas Bellinger
Signal support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits
required for virtio-scsi 1.0 spec layout requirements.
Cc: Michael S. Tsirkin
Acked-by: Michael S. Tsirkin
Cc: Paolo Bonzini
Signed-off-by: Nicholas Bellinger
---
drivers/vhost/scsi.c | 4 +++-
From: Nicholas Bellinger
This patch adds ANY_LAYOUT compatible support within the existing
vhost_scsi_handle_vq() ->handle_kick() callback.
It calculates data_direction + exp_data_len for the new tcm_vhost_cmd
descriptor by walking both outgoing + incoming iovecs using iov_iter,
assuming the lay
From: Nicholas Bellinger
This patch changes vhost_scsi_map_to_sgl() parameters to accept virtio
iovec ptr + len when determing pages_nr.
This is currently done with iov_num_pages() -> PAGE_ALIGN, so allow
the same parameters as well.
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Signed-off-by: Nic
From: Nicholas Bellinger
This patch adds ANY_LAYOUT prerequisites logic for accepting a set of
protection + data payloads via iov_iter. Also includes helpers for
calcuating SGLs + invoking vhost_scsi_map_to_sgl() with a known number
of iovecs.
Required by ANY_LAYOUT processing when struct iovec
The g_NCR5380.c USLEEP timing change restores driver behaviour to what
it was before the configurable HZ value introduced in 2005. The
g_NCR5380.c USLEEP timing settings date back to 1997, so this patch
fixes a bug with the driver timing introduced in 2005 when the
conversion from fixed jiffies cou
60 matches
Mail list logo