On Fri, Sep 26, 2014 at 07:07:19PM +0100, David Vrabel wrote:
> On 26/09/14 17:36, Chen Gang wrote:
> > When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> > internally, so need not return any status value, then use 'void' instead
> > of 'int' for xenbus_switch_state() and __xenb
This patch fixes newly introduced sparse warning, introduced by
"scis: fixing the "type" for well known LUs".
Sparse warning:
>> drivers/scsi/scsi_scan.c:825: warning: format '%16p' expects type
'void *', but argument 6 has type 'u64'
Signed-off-by: Dolev Raviv
d
This patch fixes newly introduced sparse warning, introduced by
UFS power management series.
Sparse warning:
>> drivers/scsi/ufs/ufshcd.c:1867:5: sparse: symbol
'ufshcd_uic_pwr_ctrl' was not declared. Should it be static?
>> drivers/scsi/ufs/ufshcd.c:2025:5: sparse: symbol
'ufshcd_
Megaraid_sas uses a shared pool of commands per HBA, so we
should be enabling a shared tag map.
This will allow the I/O scheduler to make better scheduling
decisions and will avoid BUSY states in the driver.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 34 ++
Calling scsi_print_command should not be necessary during abort;
if the information is required one should enable scsi logging.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/53c700.c| 4 +---
drivers/scsi/NCR5380.c | 5 ++---
drivers/scsi/arm/fas216.c| 10 +++---
driver
print_opcode_name() was only ever called with a '0' argument
from LLDDs and ULDs which were _not_ supporting variable length
CDBs, so the 'if' clause was never triggered.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 21 +++--
1 file changed, 7 insertions(+), 14 d
libata already uses an internal buffer, so we should be using
__scsi_print_command() here.
Cc: Tejun Heo
Cc: linux-...@vger.kernel.org
Cc: LKML
Signed-off-by: Hannes Reinecke
---
drivers/ata/libata-eh.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/at
Implement a lookup array for SERVICE ACTION commands instead
of hardcoding it in a large switch statement.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 132 +++
1 file changed, 54 insertions(+), 78 delet
Convert scsi_normalize_sense() and frieds to return 'bool'
instead of an integer.
Reviewed-by: Yoshihiro Yunomae
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 14 +++---
drivers/scsi/scsi_lib.c | 2 +-
include/scsi/scsi_eh.h| 14 ++
scsi_try_to_abort_cmd() should only return
SUCCESS or FAILED. So document that in the
function description and simplify the
logging message.
Suggested-by: Christoph Hellwig
Cc: Robert Elliott
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 20 +---
1 file changed
Instead of having two versions of print_opcode_name() we
should be consolidating them into one version.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 91 ++--
1 file changed, 34 insertions(+), 57 deletion
Consolidate the CDB opcode lookup in scsi_opcode_sa_name(),
so that we don't have to call several functions to figure
out the CDB opcode string.
Reviewed-by: Christoph Hellweg
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 37 ++---
1 file changed,
Convert scsi_print_result() to use seq_buf to properly
decode the command result and disposition.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c| 20
drivers/scsi/scsi.c | 2 +-
drivers/scsi/scsi_logging.c | 36
The request tag provides a concise identification of a SCSI
command, so we should be printing that out for scmd_printk().
Suggested-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_logging.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/d
Convert sense buffer logging to use seq_buf to
avoid line breakup.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c| 107
drivers/scsi/osst.c | 4 +-
drivers/scsi/scsi_logging.c | 104 ++
Printing out the command pointer during logging messages doesn't
serve any real purpose, but only takes up space.
So we should remove it and rely on the generic logging functions
to distinguish the command for us.
Suggested-by: Robert Elliott
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi
Use an external buffer for __scsi_print_command() and
move command logging over to seq_buf. With that we can
guarantee to have the command always in one line,
and can even print out a variable length command
correctly across several lines.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/ch.c
Instead of having constants.c littered with ifdef statements
we should be moving dummy functions into the header and
condintionally compile in constants.c if selected.
Suggested-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/Makefile| 4 ++--
drivers/scsi/constants.c
There's several locations in the kernel that open code the calculation
of the next location in the trace_seq buffer. This is usually done with
p->buffer + p->len
Instead of having this open coded, supply a helper function in the
header to do it for them. This function is called trace_seq_buffer
Add functions for scmd_printk and sdev_prefix_printk
using dev_printk_string() instead of using macro magic.
And make sdev_printk() a wrapper for sdev_prefix_printk().
Signed-off-by: Hannes Reinecke
---
drivers/scsi/Makefile | 2 +-
drivers/scsi/scsi_logging.c | 78 +++
Move buffer formatting to the start of the function as it
doesn't require to be done under any locks.
No functional change, required by the next patch.
Cc: Steven Rostedt
Cc: LKML
Signed-off-by: Hannes Reinecke
---
kernel/printk/printk.c | 21 ++---
1 file changed, 10 insertion
From: "Steven Rostedt (Red Hat)"
Create a seq_buf layer that trace_seq sits on. The seq_buf will not
be limited to page size. This will allow other usages of seq_buf
instead of a hard set PAGE_SIZE one that trace_seq has.
Acked-by: Hannes Reinecke
Signed-off-by: Steven Rostedt
---
arch/x86/kv
Simplify scsi_log_(send|completion) by externalizing
scsi_mlreturn_string() and always print the command address.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 39 ---
drivers/scsi/scsi.c | 43 ++-
d
Currently we're only decoding sense extras for tape devices.
And even there only for fixed format sense formats.
As this is of rather limited use in the general case we should
be stop trying to decode sense extras; the tape driver does
its own decoding anyway.
Reviewed-by: Christoph Hellwig
Signe
This patch splits off the actual logging from vprintk_emit()
into printk_emit_string(), with vprintk_emit() just being a
simple wrapper for formatting the message into a
static buffer.
With that the caller can pass in a local buffer for
printk_emit_string() without increasing the overall stack siz
Introducing dev_printk_string() and dev_printk_header() to allow
using an external buffer for printing via dev_printk().
Cc: Greg Kroah-Hartman
Cc: Steven Rostedt
Cc: LKML
Signed-off-by: Hannes Reinecke
---
drivers/base/core.c| 24
include/linux/device.h | 12
Open-code scsi_print_result in sd.c, and cleanup logging to
not print duplicate informations.
With that we can remove scsi_show_result in constants.c
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 16
drivers/scsi/sd.c| 45 +++-
Last caller is gone, so we can remove it.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 35 ---
include/scsi/scsi_dbg.h | 1 -
2 files changed, 36 deletions(-)
diff --git a/drivers/scsi/constants.c b/drivers/scsi/
Unused.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 14 --
include/scsi/scsi_dbg.h | 2 --
2 files changed, 16 deletions(-)
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index d35a5d6..2f44707 100644
--- a/driver
Like scmd_printk(), but the device name is passed in as
a string. Can be used by eg ULDs which do not have access
to the scsi_cmnd structure.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/ch.c | 3 +--
drivers/scsi/sd.h | 7 ---
drivers/scs
If scsi_normalize_sense() fails we couldn't decode the sense
buffer, and the scsi_sense_hdr fields are invalid.
For those cases we should rather dump the sense buffer
and not try to decode invalid fields.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 34 --
Export functions for later use.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 58
include/scsi/scsi_dbg.h | 2 ++
2 files changed, 46 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.
The EH statistics are per host, so we should be using
shost_printk() here.
Suggested-by: Robert Elliott
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 4d
Use the matching scope for logging messages to allow for
better command tracing.
Suggested-by: Robert Elliott
Signed-off-by: Hannes Reinecke
---
drivers/scsi/hosts.c | 4 +--
drivers/scsi/scsi_error.c | 82 +--
2 files changed, 45 insertions(+),
Hi all,
here's the third version of my scsi logging updates.
Main (and most important) difference to the previous
patchset is that the stacksize does not increase when
printing SCSI CDBs, so the objection from hch should
be resolved with this.
To achieve this I've split up vprintk_emit() into two
sd_done() was calling scsi_print_sense() for a sense code
of 'NO_SENSE'.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/sd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 0cb5c9f..0ccb459 100644
--- a/drivers/scsi/
We should be using the standard dev_printk() variants for
sense code printing.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/53c700.c | 2 +-
drivers/scsi/ch.c | 2 +-
drivers/scsi/constants.c | 117 ++-
Update logging messages to use dev_printk() variants for correct
device annotations.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/arm/fas216.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas
Remove all uncommented debugging code and move all
printk() statements over to dev_printk().
And while we're at it we should be doing a whitespace
cleanup, too.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/aha152x.c | 994 +++--
1 file changed, 224
From: "Steven Rostedt (Red Hat)"
The seq_buf functions are rather useful outside of tracing. Instead
of having it be dependent on CONFIG_TRACING, move the code into lib/
and allow other users to have access to it even when tracing is not
configured.
The seq_buf utility is similar to the seq_file
The 53c700 driver would be using scsi_print_sense() in a debug
statement, which was never compiled in. Plus the same information
can get retrieved with logging. So remove it.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/53c700.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
Update acornscsi to use scsi_print_command() instead of the
underscore version. This will add correct device annotations
in the resulting message.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/arm/acornscsi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/driv
A tracepoint should be inserted upon completion to make tracing
equivalent to logging.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_lib.c | 1 +
drivers/scsi/scsi_trace.c | 16
include/trace/events/scsi.h | 31 +++
3 files changed, 48 i
On Fri, Sep 26, 2014 at 10:36 AM, Chen Gang wrote:
> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> internally, so need not return any status value, then use 'void' instead
> of 'int' for xenbus_switch_state() and __xenbus_switch_state().
>
> Also need be sure that all call
On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote:
> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
Only on the first depth, not on the subsequent ones (as in if
the first xenbus_switch_fail fails, it won't try to call
xenbus_switch_state again and again).
> internal
On Mon, 29 Sep 2014 13:58:55 +0200
Hannes Reinecke wrote:
> From: "Steven Rostedt (Red Hat)"
>
> The seq_buf functions are rather useful outside of tracing. Instead
> of having it be dependent on CONFIG_TRACING, move the code into lib/
> and allow other users to have access to it even when trac
On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote:
> libata already uses an internal buffer, so we should be using
> __scsi_print_command() here.
>
> Cc: Tejun Heo
> Cc: linux-...@vger.kernel.org
> Cc: LKML
> Signed-off-by: Hannes Reinecke
Applied to libata/for-3.18.
Thanks.
--
On 09/29/2014 04:04 PM, Steven Rostedt wrote:
> On Mon, 29 Sep 2014 13:58:55 +0200
> Hannes Reinecke wrote:
>
>> From: "Steven Rostedt (Red Hat)"
>>
>> The seq_buf functions are rather useful outside of tracing. Instead
>> of having it be dependent on CONFIG_TRACING, move the code into lib/
>> a
On Fri, Sep 26, 2014 at 07:07:19PM +0100, David Vrabel wrote:
> On 26/09/14 17:36, Chen Gang wrote:
> > When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> > internally, so need not return any status value, then use 'void' instead
> > of 'int' for xenbus_switch_state() and __xenb
On Mon, Sep 29, 2014 at 04:10:30PM +0200, Hannes Reinecke wrote:
> On 09/29/2014 04:06 PM, Tejun Heo wrote:
> > On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote:
> >> libata already uses an internal buffer, so we should be using
> >> __scsi_print_command() here.
> >>
> >> Cc: Tejun H
On 09/29/2014 04:06 PM, Tejun Heo wrote:
> On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote:
>> libata already uses an internal buffer, so we should be using
>> __scsi_print_command() here.
>>
>> Cc: Tejun Heo
>> Cc: linux-...@vger.kernel.org
>> Cc: LKML
>> Signed-off-by: Hannes Re
On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote:
> On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote:
>> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
>
> Only on the first depth, not on the subsequent ones (as in if
> the first xenbus_switch_fail fails, it won't try
On Mon, Sep 29, 2014 at 03:17:10PM +0100, David Vrabel wrote:
> On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote:
> > On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote:
> >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> >
> > Only on the first depth, not on the subse
[Hannes, James, Christoph: sorry for the extra copies -- my mail client
didn't automatically convert to plain-text for the list, so it bounced.]
Could someone enlighten me on when and where a driver might want to or
be required to set the "tagged_supported" flag?
A quick grep yields a number
On Mon, Sep 29, 2014 at 01:58:58PM +0200, Hannes Reinecke wrote:
> Introducing dev_printk_string() and dev_printk_header() to allow
> using an external buffer for printing via dev_printk().
>
> Cc: Greg Kroah-Hartman
> Cc: Steven Rostedt
> Cc: LKML
> Signed-off-by: Hannes Reinecke
> ---
> dri
On Mon, 2014-09-29 at 12:52 -0400, Webb Scales wrote:
> [Hannes, James, Christoph: sorry for the extra copies -- my mail client
> didn't automatically convert to plain-text for the list, so it bounced.]
>
> Could someone enlighten me on when and where a driver might want to or
> be required to
On 29/09/14 16:40, Konrad Rzeszutek Wilk wrote:
> On Mon, Sep 29, 2014 at 03:17:10PM +0100, David Vrabel wrote:
>> On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote:
>>> On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote:
When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
From: Mike Christie
This just has iscsi_tcp support ISCSI_PARAM_LOCAL_PORT which
exports the local port being used by the iscsi connection.
Signed-off-by: Mike Christie
---
drivers/scsi/iscsi_tcp.c | 10 --
drivers/scsi/libiscsi.c |1 +
2 files changed, 9 insertions(+), 2 deleti
From: Mike Christie
Dan Carpenter found a issue where be2iscsi would copy the ip
from userspace to the driver buffer before checking the len
of the data being copied:
http://marc.info/?l=linux-scsi&m=140982651504251&w=2
This patch just has us only copy what we the driver buffer
can support.
Tes
A couple patches made over the scsi-queue drivers-for-3.18 branch.
They just fix a possible bug with be2iscsi that Dan reported and
also export the iscsi port being used.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
On Mon, 2014-09-29 at 13:55 -0500, micha...@cs.wisc.edu wrote:
> From: Mike Christie
>
> Dan Carpenter found a issue where be2iscsi would copy the ip
> from userspace to the driver buffer before checking the len
> of the data being copied:
> http://marc.info/?l=linux-scsi&m=140982651504251&w=2
>
On 09/29/2014 02:06 PM, James Bottomley wrote:
> On Mon, 2014-09-29 at 13:55 -0500, micha...@cs.wisc.edu wrote:
>> From: Mike Christie
>>
>> Dan Carpenter found a issue where be2iscsi would copy the ip
>> from userspace to the driver buffer before checking the len
>> of the data being copied:
>> h
On Mon, Sep 29, 2014 at 02:08:13PM -0500, Mike Christie wrote:
> > This looks to be a long standing and potentially exploitable bug ...
> > does it need a cc to stable?
> >
>
> Yeah, sorry. Forgot to cc. Do you need me to resend with them ccd?
As mentioned offlist I can just add it, but if you k
On 14-09-29 07:58 AM, Hannes Reinecke wrote:
Implement a lookup array for SERVICE ACTION commands instead
of hardcoding it in a large switch statement.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c | 132 +++
On Sun, Sep 28, 2014 at 11:03:29AM -0400, Tejun Heo wrote:
> Hello,
>
> On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote:
> ...
> > Systemd should consider enabling async probe on device drivers
> > it loads through systemd-udev but probably does not want to
> > enable it for modu
Hello, Luis.
On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote:
> > > + /* For now lets avoid stupid bug reports */
> > > + if (!strcmp(bus->name, "pci") ||
> > > + !strcmp(bus->name, "pci_express") ||
> > > + !strcmp(bus->name, "hid") ||
> > > + !strcmp(bus->name, "sdi
On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote:
> On Sun, Sep 28, 2014 at 11:03:29AM -0400, Tejun Heo wrote:
> > Hello,
> >
> > On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote:
> > ...
> > > Systemd should consider enabling async probe on device drivers
> > > i
On Mon, Sep 29, 2014 at 2:59 PM, Greg KH wrote:
>> Sure make sense, I wasn't quite sure how to make this quite clear,
>> a naming convention seems good to me but I also had added at least
>> a print about this on the log. Ideally I think a TAIN_DEBUG would
>> be best and it seems it could be usefu
On Mon, Sep 29, 2014 at 03:10:22PM -0700, Luis R. Rodriguez wrote:
> On Mon, Sep 29, 2014 at 2:59 PM, Greg KH wrote:
> >> Sure make sense, I wasn't quite sure how to make this quite clear,
> >> a naming convention seems good to me but I also had added at least
> >> a print about this on the log. I
On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote:
> On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez
> wrote:
> > From: "Luis R. Rodriguez"
> > Systemd has a general timeout for all workers currently set to 180
> > seconds after which it will send a sigkill signal. Systemd now has
On 09/29/2014 06:58 PM, Greg Kroah-Hartman wrote:
On Mon, Sep 29, 2014 at 01:58:58PM +0200, Hannes Reinecke wrote:
Introducing dev_printk_string() and dev_printk_header() to allow
using an external buffer for printing via dev_printk().
Cc: Greg Kroah-Hartman
Cc: Steven Rostedt
Cc: LKML
Signe
On 09/29/2014 09:29 PM, Douglas Gilbert wrote:
On 14-09-29 07:58 AM, Hannes Reinecke wrote:
Implement a lookup array for SERVICE ACTION commands instead
of hardcoding it in a large switch statement.
Reviewed-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
---
drivers/scsi/constants.c |
72 matches
Mail list logo
