Hi Christoph,
On Fri, Apr 25, 2014 at 03:12:19PM +0200, Christoph Hellwig wrote:
>
> Looks useful, but why do we have basically two copies of the same
> code for different commands? Looking at them in detail they mostly look
> like copies of scsi_execute/scsi_execute_req_flags and should be switc
The for body loop isn't indented at all so it's confusing.
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 21883a2..3074f6b 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -5430,7 +5430,7 @@ static int append_to_buffer(const char __user *ub
Hi Nagalakshmi,
Welcome back from vacation. Please Ack this patch because output is
still badly fromatted in linux-next.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 11:39:01AM +0300, Dan Carpenter wrote:
> The indenting here for "pr_info("\n");" is not correct. It's not part
> of the if con
Krishna isn't around any more. Does anyone else know what's going on
in this code? It looks buggy to me.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 02:07:37AM +0300, Dan Carpenter wrote:
> On Fri, Mar 28, 2014 at 02:05:14AM +0300, Dan Carpenter wrote:
> > Hello Krishna Gudipati,
> >
> > Th
Instead of pushing each byte via stack let's use custom specifier which allows
to print small buffers as a hex string.
Signed-off-by: Andy Shevchenko
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
The function sas_parse_addr() could be easily substituted by hex2bin() which is
in kernel library code.
Signed-off-by: Andy Shevchenko
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/libsas/sas_scsi_host.c | 23 +++
1 file changed, 7 insertions(+),
On Tue, 2014-04-29 at 15:15 +1200, Michael Schmitz wrote:
> Finn,
>
> On Tue, Apr 29, 2014 at 2:22 PM, Finn Thain
> wrote:
> >
> > On Sat, 26 Apr 2014, James Bottomley wrote:
> >
> >> OK, so this is a pretty big change to an unmaintained driver. I'll take
> >> it if you're willing to maintain t
Instead of supplying each byte through stack let's use %pM specifier.
Signed-off-by: Andy Shevchenko
Cc: Tom Tucker
Cc: Steve Wise
Cc: linux-r...@vger.kernel.org
---
drivers/scsi/fnic/vnic_dev.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/fnic/vn
The original behaviour is to refuse to add a new page if the maximum number
of segments has been reached, regardless of the fact the page we are
going to add can be merged into the last segment or not.
Unfortunately, when the system runs under heavy memory fragmentation conditions,
a driver may tr
The original behaviour is to refuse to add a new page if the maximum number
of segments has been reached, regardless of the fact the page we are
going to add can be merged into the last segment or not.
Unfortunately, when the system runs under heavy memory fragmentation conditions,
a driver may tr
Sorry I did a mistake in this patch: on failure I should restore the original
value
of bi_phys_segments.
I'm going to send a new version.
Maurizio Lombardi
On Tue, Apr 29, 2014 at 04:58:18PM +0200, Maurizio Lombardi wrote:
> The original behaviour is to refuse to add a new page if the maximum n
On Tue, Apr 29, 2014 at 11:30:35AM +0200, Maurizio Lombardi wrote:
> If I convert submit_rtpg() to make use of scsi_execute() then I'll not be
> able to read the updated sense buffer.
>
> scsi_execute() accepts a pointer to the sense buffer as parameter, but
> it does not update its content in cas
On Fri, 2014-01-31 at 10:30 +0100, Hannes Reinecke wrote:
> @@ -797,37 +838,40 @@ static int alua_rtpg(struct scsi_device *sdev, struct
> alua_port_group *pg)
> off = 8 + (ucp[7] * 4);
> }
>
> - sdev_printk(KERN_INFO, sdev,
> - "%s: port group %02x state %
13 matches
Mail list logo
