Krishna isn't around any more. Does anyone else know what's going on
in this code? It looks buggy to me.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 02:07:37AM +0300, Dan Carpenter wrote:
> On Fri, Mar 28, 2014 at 02:05:14AM +0300, Dan Carpenter wrote:
> > Hello Krishna Gudipati,
> >
> > The patch 51e569aa1f0c: "[SCSI] bfa: Added support to obtain SFP
> > info." from Jun 24, 2011, leads to the following static checker
> > warning:
> >
> > drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_query()
> > warn: add curly braces?
> >
> > drivers/scsi/bfa/bfa_ioc.c
> > 3659 static void
> > 3660 bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
> > 3661 {
> > 3662 bfa_trc(sfp, sfp->portspeed);
> > 3663 if (sfp->media) {
> > 3664 bfa_sfp_media_get(sfp);
> > 3665 if (sfp->state_query_cbfn)
> > ^
> > Add a curly brace here?
> >
> > 3666
> > sfp->state_query_cbfn(sfp->state_query_cbarg,
> > 3667 sfp->status);
> > 3668 sfp->media = NULL;
> > 3669 }
> > 3670
> > 3671 if (sfp->portspeed) {
> > 3672 sfp->status = bfa_sfp_speed_valid(sfp,
> > sfp->portspeed);
> > 3673 if (sfp->state_query_cbfn)
> > 3674
> > sfp->state_query_cbfn(sfp->state_query_cbarg,
> > 3675 sfp->status);
> > 3676 sfp->portspeed =
> > BFA_PORT_SPEED_UNKNOWN;
>
> It looks like this if statement needs curly braces as well.
>
> regards,
> dan carpenter
>
> > 3677 }
> > 3678
> > 3679 sfp->state_query_lock = 0;
> > 3680 sfp->state_query_cbfn = NULL;
> >
> > ^
> > And another close curly brace here?
> >
> > 3681 }
> >
> > regards,
> > dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
