[RESEND][PATCH 2/8][SCSI] mpt2sas : Fix for issue Missing delay not getting set during system bootup

2013-02-01 Thread Sreekanth Reddy
Missing delay is not getting set properly. The reason is it is not defined in the same file from where it is being invoked. The fix is to move the missing delay module parameter from mpt2sas_base.c to mpt2sas_scsh.c. Signed-off-by: Sreekanth Reddy Cc: sta...@vger.kernel.org --- diff --git a

[RESEND][PATCH 5/8][SCSI] mpt2sas : Fix for device scan following host reset could get stuck in a infinite loop

2013-02-01 Thread Sreekanth Reddy
Modified device scan routine so each configuration page read breaks from the while loop when the ioc_status is not equal to MPI2_IOCSTATUS_SUCCESS. Signed-off-by: Sreekanth Reddy Cc: sta...@vger.kernel.org --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scs

[RESEND][PATCH 6/8][SCSI] mpt2sas : When SCSI command is received with task atrribute not set, set it to SIMPLE

2013-02-01 Thread Sreekanth Reddy
When SCSI command is received with task attribute not set, set it to SIMPLE. Previously it is set to untagged. This causes the firmware to fail the commands. Signed-off-by: Sreekanth Reddy Cc: sta...@vger.kernel.org --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mp

RE: How to online remove an error scsi disk from the system?

2013-02-01 Thread Jack Wang
Hi All, In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems to me that the io sent to the scsi layer is never returned back

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 03:54 PM, Bart Van Assche wrote: > On 02/01/13 07:13, Tao Ma wrote: >> In our product system, we have several sata disks attached to one >> machine. So when one of the disk fails, the jbd2(yes, we use ext4) will >> hang forever and we will get something in /var/log/messages like b

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 04:50 PM, Jack Wang wrote: > Hi All, > In our product system, we have several sata disks attached to one > machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang > forever and we will get something in /var/log/messages like below. > It seems to me that the

RE: How to online remove an error scsi disk from the system?

2013-02-01 Thread Jack Wang
On 02/01/2013 04:50 PM, Jack Wang wrote: > Hi All, > In our product system, we have several sata disks attached to one > machine. So when one of the disk fails, the jbd2(yes, we use ext4) > will hang forever and we will get something in /var/log/messages like below. > It seems to me that t

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Bryn M. Reeves
On 02/01/2013 07:54 AM, Bart Van Assche wrote: * proc_scsi_write - handle writes to /proc/scsi/scsi * @file: not used * @buf: buffer to write * @length: length of buf, at most PAGE_SIZE * @ppos: not used * * Description: this provides a legacy mechanism to add or remove * devices

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 05:24 PM, Jack Wang wrote: > > On 02/01/2013 04:50 PM, Jack Wang wrote: >> Hi All, >> In our product system, we have several sata disks attached to one >> machine. So when one of the disk fails, the jbd2(yes, we use ext4) >> will hang forever and we will get something in /var/

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 05:52 PM, Bryn M. Reeves wrote: > On 02/01/2013 07:54 AM, Bart Van Assche wrote: >> * proc_scsi_write - handle writes to /proc/scsi/scsi >> * @file: not used >> * @buf: buffer to write >> * @length: length of buf, at most PAGE_SIZE >> * @ppos: not used >> * >> * Descript

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Bryn M. Reeves
On 02/01/2013 09:59 AM, Tao Ma wrote: yes, but the result is the same. It will do some IO first which will cause this command hang. You seem to have a problem with either the device/adapter or in the driver. The backtrace you posted shows that jbd2 (ext4) is still waiting on IO that's been su

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 06:07 PM, Bryn M. Reeves wrote: > On 02/01/2013 09:59 AM, Tao Ma wrote: >> yes, but the result is the same. It will do some IO first which will >> cause this command hang. > > You seem to have a problem with either the device/adapter or in the > driver. The backtrace you posted shows

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Bryn M. Reeves
On 02/01/2013 11:13 AM, Tao Ma wrote: You don't mention the versions of the kernel and driver you're using - if the system is in production I would suggest contacting who ever normally provides support for the kernel and distribution that you are running. We use CentOS6.2 and the kernel version

[LSF/MM TOPIC] Reducing the SRP initiator failover time

2013-02-01 Thread Bart Van Assche
It is known that it takes about two to three minutes before the upstream SRP initiator fails over from a failed path to a working path. This is not only considered longer than acceptable but is also longer than other Linux SCSI initiators (e.g. iSCSI and FC). Progress so far with improving the

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Hillf Danton
On Fri, Feb 1, 2013 at 2:13 PM, Tao Ma wrote: > Hi All, > In our product system, we have several sata disks attached to one > machine. So when one of the disk fails, the jbd2(yes, we use ext4) will > hang forever and we will get something in /var/log/messages like below. > It seems to me t

Re: [LSF/MM TOPIC] SCSI Express driver

2013-02-01 Thread Hannes Reinecke
On 01/31/2013 06:23 PM, scame...@beardog.cce.hp.com wrote: If there is interest, I would like to discuss the SCSI Express driver Chayan and I have been working on for the last few months. YES. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-02-01 Thread Alan Stern
On Fri, 1 Feb 2013, Aaron Lu wrote: > On Thu, Jan 31, 2013 at 10:13:05AM -0500, Alan Stern wrote: > > On Thu, 31 Jan 2013, Aaron Lu wrote: > > > > > > > +static int scsi_blk_runtime_suspend(struct device *dev) > > > > > +{ > > > > > + struct scsi_device *sdev = to_scsi_device(dev); > > > > >

[PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug to provide enhanced support for Unit Attention conditions, as well as detection of reported sense data overflow conditions and some changes to sense data processing. It also adds a uevent when the repor

[PATCH v2 1/8] [SCSI] Generate uevent on sd capacity change

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" In sd_read_capacity(), detect if the capacity is different from the previously read value, and generate a uevent if this is the case. Signed-off-by: Ewan D. Milne --- drivers/scsi/scsi_lib.c| 5 - drivers/scsi/scsi_sysfs.c | 2 ++ drivers/scsi/sd.c | 9 +

[PATCH v2 2/8] [SCSI] Add a kernel config option for enhanced Unit Attention support

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Added CONFIG_SCSI_ENHANCED_UA kernel config option to enable changes in the SCSI mid-layer which detect and report certain Unit Attention conditions reported by devices. These changes are primarily useful when storage arrays that can be reconfigured are being used, so the c

[PATCH v2 3/8] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" The names of the struct and some of the functions for scsi_device events are too generic and do not match the comments in the source. Changed all of the names to begin with sdev_ in order to avoid naming issues and confusion with scsi_target events to be added. Also changed

[PATCH v2 4/8] [SCSI] Add support for scsi_target events

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Added capability to generate uevents on scsi_target objects. Signed-off-by: Ewan D. Milne --- drivers/scsi/scsi_lib.c| 135 + drivers/scsi/scsi_priv.h | 3 + drivers/scsi/scsi_scan.c | 17 ++ include/scsi/scsi_dev

[PATCH v2 8/8] [SCSI] Streamline detection of FM/EOM/ILI status

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Avoid duplicate tests when examining sense data for FM/EOM/ILI bits. Moved extraction of status to scsi_normalize_sense() if the config option CONFIG_SCSI_ENHANCED_UA is used, because descriptor format sense data is already being parsed there. Signed-off-by: Ewan D. Milne

[PATCH v2 7/8] [SCSI] Add sense and Unit Attention generation to scsi_debug

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Added capability to scsi_debug to generate sense and Unit Attention conditions to exercise the enhanced sense and Unit Attention handling. Signed-off-by: Ewan D. Milne --- drivers/scsi/scsi_debug.c | 138 ++ 1 file changed, 138

[PATCH v2 6/8] [SCSI] Add sysfs support for enhanced Unit Attention handling

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Added support for additional scsi_device events in sysfs, as well as support for scsi_target events. Also added "rescan" node in scsi_target sysfs to permit targets to be rescanned from udev rules in a more straightforward way. Signed-off-by: Ewan D. Milne --- drivers/sc

[PATCH v2 5/8] [SCSI] Generate uevents for certain Unit Attention codes

2013-02-01 Thread Ewan D. Milne
From: "Ewan D. Milne" Generate a uevent on the scsi_target object when the following Unit Attention ASC/ASCQ code is received: 3F/0E REPORTED LUNS DATA HAS CHANGED Generate a uevent on the scsi_device object when the following Unit Attention ASC/ASCQ codes are received: 2A/01 MODE PA

[GIT PULL] target fixes for v3.8-rc7

2013-02-01 Thread Nicholas A. Bellinger
Hi Linus, Here's the current set of v3.8-rc fixes in the target-pending.git queue. Apologies in advance for these missing the -rc6 release, and having to be destined for -rc7 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The m