Re: [PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-07 Thread Robert P. J. Day
On Tue, 6 Nov 2007, Matthew Wilcox wrote: > On Tue, Nov 06, 2007 at 10:20:46AM -0500, Robert P. J. Day wrote: > > @@ -1656,7 +1657,7 @@ static inline int reconnect_target(struct NCR_ESP > > *esp, struct ESP_regs *eregs) > > if(!(it & me)) > > return -1; > > it &= ~me; > > -

Re: usage of max_sectors in scsi_host_template

2007-11-07 Thread Stefan Richter
Erez Zilber wrote: > I'm running sgp_dd (on RHAS 4 up4 - kernel version is 2.6.9), so it > calls scsi-ml directly (without going through ll_rw_blk). ... > I guess that the max_sectors value is never used. Am I right? I have no idea. However you might be able to track how max_sectors trickles thr

Re: LTO-3 read performance issues

2007-11-07 Thread Kai Makisara
On Wed, 7 Nov 2007, James Pearson wrote: > I have two LTO-3 (QUANTUM ULTRIUM 3) drives attached to a dual Adaptec U160 > controller (one per SCSI host) on a Dell PE2850 running a RHEL4 based kernel > (2.6.9 based). > > I'm trying to read (with tar) LTO-3 tapes written on another system (possibly

[PATCH] [SCSI] iscsi: return data transfer residual for data-out commands

2007-11-07 Thread Tony Battersby
Currently, the iSCSI driver returns the data transfer residual for data-in commands (e.g. read) but not data-out commands (e.g. write). This patch makes it return the data transfer residual for both types of commands. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- --- linux-2.6.24-rc2/drive

Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 02:34:53PM -0800, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. Looks

LTO-3 read performance issues

2007-11-07 Thread James Pearson
I have two LTO-3 (QUANTUM ULTRIUM 3) drives attached to a dual Adaptec U160 controller (one per SCSI host) on a Dell PE2850 running a RHEL4 based kernel (2.6.9 based). I'm trying to read (with tar) LTO-3 tapes written on another system (possibly an SGI IRIX box), but I'm getting extremely vari

Re: usage of max_sectors in scsi_host_template

2007-11-07 Thread Erez Zilber
Stefan Richter wrote: Erez Zilber wrote: > I'm not sure that I understand the meaning of max_sectors in > scsi_host_template. Did you have a look at scsi_mid_low_api.txt? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/scsi/scsi_mid_low_api.txt;h=6f70f2b9

Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-07 Thread Jens Axboe
On Tue, Nov 06 2007, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. I updated the timeout patch

Re: [PATCH] [SCSI] iscsi: return data transfer residual for data-out commands

2007-11-07 Thread Boaz Harrosh
On Wed, Nov 07 2007 at 20:06 +0200, Tony Battersby <[EMAIL PROTECTED]> wrote: > Currently, the iSCSI driver returns the data transfer residual for > data-in commands (e.g. read) but not data-out commands (e.g. write). > This patch makes it return the data transfer residual for both types of > comma

RE: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-07 Thread Salyzyn, Mark
Christoph Hellwig [mailto:[EMAIL PROTECTED] sez: > Did anyone run the driver through sparse to see if we have > more issues like this? There are some warnings from sparse, none like this one. I will deal with the warnings ... Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the l

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 12:06:39PM -0700, Yang, Bo wrote: > The fast_load parameter is for the user to decide at driver load time if > (s)he wants to skip scan of devices in PD channels. > After driver is loaded the user cannot be permitted to modify this > value. If the user needs to see the devic

Re: [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24

2007-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 02:40:54PM -0500, Tony Battersby wrote: > The following commit changed the pointer passed to request_irq(), but > failed to change the pointer passed to free_irq(): Looks good. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

2007-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 12:04:31PM -0700, Yang, Bo wrote: > I see that scsi_scan_host_selected is in scsi_priv.h and currently is > not used by any other driver. The scsi_priv.h is not part of the include > dir (/include/scsi). One of the major Linux distro's don't even include > this file in /usr/

[PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-07 Thread Salyzyn, Mark
Good point, thanks. The intent of the management applications utilization of this AIF report is to observe the LSB of the value of integer value in BlinkLED. The actions of the cpu_to_le32 actually breaks this and reports the wrong content in swapped architectures. This attached follow-up patch is

Re: usage of max_sectors in scsi_host_template

2007-11-07 Thread Mike Christie
Erez Zilber wrote: Stefan Richter wrote: Erez Zilber wrote: I'm not sure that I understand the meaning of max_sectors in scsi_host_template. Did you have a look at scsi_mid_low_api.txt? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/scsi/scsi_mid_low_ap

Re: [PATCH -mm 0/3] convert IOMMUs to use iova

2007-11-07 Thread FUJITA Tomonori
On Fri, 2 Nov 2007 19:12:27 +0200 Muli Ben-Yehuda <[EMAIL PROTECTED]> wrote: > On Sat, Nov 03, 2007 at 02:05:39AM +0900, FUJITA Tomonori wrote: > > > This patchset convert the PPC64 IOMMU to use the iova code for free > > area management. > > > > The IOMMUs ignores low level drivers' restriction

[PATCH] [SCSI] sym53c8xx: don't flood syslog with negotiation messages

2007-11-07 Thread Tony Battersby
sym53c8xx prints a negotiation message after every check condition. This can add up to a lot of messages for removable-medium devices (CD-ROM, tape drives, etc.) that are being polled, since they return check condition when no medium is present. This patch suppresses the negotiation message if it

Re: [PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-07 Thread Mike Christie
Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Thanks for the iscsi bits. We have the libiscsi part from [EMAIL PROTECTED] queued for 2.6.25. And the iscsi_tcp parts you are patching over are broken and I am going to fix that for 2.6.25. We only support 1 r2

[PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects

2007-11-07 Thread Tony Battersby
This patch fixes the sym53c8xx "setflag" user command to control disconnect privilege, which has been broken for a long time. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- NOTE regarding the following change: can_disconnect = (cp->tag != NO_TAG) || - (lp && (lp->cur

Re: [PATCH] [SCSI] iscsi: return data transfer residual for data-out commands

2007-11-07 Thread Mike Christie
Boaz Harrosh wrote: On Wed, Nov 07 2007 at 20:06 +0200, Tony Battersby <[EMAIL PROTECTED]> wrote: Currently, the iSCSI driver returns the data transfer residual for data-in commands (e.g. read) but not data-out commands (e.g. write). This patch makes it return the data transfer residual for both

Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-07 Thread Christoph Hellwig
On Wed, Nov 07, 2007 at 10:58:12AM -0500, Salyzyn, Mark wrote: > Good point, thanks. The intent of the management applications > utilization of this AIF report is to observe the LSB of the value of > integer value in BlinkLED. The actions of the cpu_to_le32 actually > breaks this and reports the wr

Re: slow after upgrade to CentOS 5 (RHEL5)

2007-11-07 Thread Anthony Ewell
James Bottomley wrote: Please don't drop the cc lists. There are others who probably have more informed opinions than I do who won't get to comment if they don't see it. On Sun, 2007-10-28 at 17:36 -0700, Anthony Ewell wrote: James Bottomley wrote: On Sat, 2007-10-27 at 13:21 -0700, Anthony E

Re: [PATCH 1/3] scsi_tgt_lib: Use scsi_init_io instead of scsi_alloc_sgtable

2007-11-07 Thread FUJITA Tomonori
On Tue, 06 Nov 2007 20:16:19 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > - If we export scsi_init_io()/scsi_release_buffers() instead of > scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is > much more insulated from scsi_lib changes. As a bonus it will > also gain bid

Re: [0/3] Last 3 patches for bidi support

2007-11-07 Thread FUJITA Tomonori
On Tue, 06 Nov 2007 20:38:33 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Tue, Nov 06 2007 at 20:25 +0200, Mike Christie <[EMAIL PROTECTED]> wrote: > > Boaz Harrosh wrote: > >> [1] > >> I propose a small change to scsi_tgt_lib.c that will make > >> tgt completely neutral to the scsi_data_buf

Re: [PATCH 2/3] scsi_data_buffer

2007-11-07 Thread FUJITA Tomonori
On Tue, 06 Nov 2007 20:19:32 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > In preparation for bidi we abstract all IO members of scsi_cmnd, > that will need to duplicate, into a substructure. > > - Group all IO members of scsi_cmnd into a scsi_data_buffer > structure. > - Adjust