Re: [PATCH] zfcp: Report FCP LUN to SCSI midlayer

2007-06-22 Thread Christof Schmitt
On Thu, Jun 21, 2007 at 09:40:35PM -0700, Mike Anderson wrote: > James Bottomley <[EMAIL PROTECTED]> wrote: > > A proposal to display the correct form of the LUN would be useful if you > > wish to make it? ... The problem is really that SAM specifies a > > possible 4 level structure with 4 possibl

[PATCH] dmx3191d: Coding style police

2007-06-22 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c linux-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c --- linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c2007-06-07 14:24:28.0

[PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Alan Cox
Seems printk levels hadn't been invented last time this driver was tidied up. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dtc.c linux-2.6.22-rc4-mm2/drivers/scsi/dtc.c --- linux.vanilla-2.6.

[PATCH] ppa: Coding police and printk levels

2007-06-22 Thread Alan Cox
Add printk levels Clean up some oddities of formatting Fix goto labels Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/ppa.c linux-2.6.22-rc4-mm2/drivers/scsi/ppa.c --- linux.vanilla-2.6.22-rc4-

Re: [PATCH] dmx3191d: Coding style police

2007-06-22 Thread Matthew Wilcox
On Fri, Jun 22, 2007 at 02:24:56PM +0100, Alan Cox wrote: > - out_free_irq: > +out_free_irq: Which CodingStyle mandates that goto labels start in column 0? It screws up diff -p to do this. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL P

Re: [PATCH] dmx3191d: Coding style police

2007-06-22 Thread Alan Cox
On Fri, 22 Jun 2007 07:26:23 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Fri, Jun 22, 2007 at 02:24:56PM +0100, Alan Cox wrote: > > - out_free_irq: > > +out_free_irq: > > Which CodingStyle mandates that goto labels start in column 0? It > screws up diff -p to do this. The style being t

Re: [PATCH] zfcp: Report FCP LUN to SCSI midlayer

2007-06-22 Thread James Bottomley
On Thu, 2007-06-21 at 21:40 -0700, Mike Anderson wrote: > James Bottomley <[EMAIL PROTECTED]> wrote: > > A proposal to display the correct form of the LUN would be useful if you > > wish to make it? ... The problem is really that SAM specifies a > > possible 4 level structure with 4 possible addre

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Kristen Carlson Accardi
On Thu, 21 Jun 2007 15:08:32 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: > > Enable Aggressive Link Power management for AHCI controllers. > > > > This patch will set the correct bits to turn on Aggressive > > Link Power Management (ALPM) for

Re: [PATCH] zfcp: Report FCP LUN to SCSI midlayer

2007-06-22 Thread Doug Maxey
On Fri, 22 Jun 2007 09:11:39 CDT, James Bottomley wrote: > On Thu, 2007-06-21 at 21:40 -0700, Mike Anderson wrote: > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > A proposal to display the correct form of the LUN would be useful if you > > > wish to make it? ... The problem is really that SA

Re: [PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Darrick J. Wong
On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote: > @@ -244,7 +242,7 @@ > if (check_signature(base + > signatures[sig].offset, signatures[sig].string, > strlen(signatures[sig].string))) { > addr = > bases

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Jens Axboe
On Fri, Jun 22 2007, Kristen Carlson Accardi wrote: > On Thu, 21 Jun 2007 15:08:32 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: > > > Enable Aggressive Link Power management for AHCI controllers. > > > > > > This patch will set the correc

Re: [PATCH] zfcp: Report FCP LUN to SCSI midlayer

2007-06-22 Thread Stefan Richter
James Bottomley wrote: > H:C is really mid-layer defined (although I'd like to get rid of C > eventually). They really correspond to physical enumeration of the HBA > devices. T (or I) is the one we think could be abstracted and placed > within the gift of the transport, but so far there's been a

Re: [PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Alan Cox
On Fri, 22 Jun 2007 11:00:06 -0700 "Darrick J. Wong" <[EMAIL PROTECTED]> wrote: > On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote: > > @@ -244,7 +242,7 @@ > > if (check_signature(base + > > signatures[sig].offset, signatures[sig].string, > > strlen(si