Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Matthew Garrett
On Mon, Jun 11, 2007 at 08:59:46PM -0700, Arjan van de Ven wrote: > that's a temporary shortcoming; even with these power savings you can > do hotplug as long as you're willing to poll for it at a reasonable > interval and are willing to wait the time between polls for a hotplug > to take effec

Re: Question: vport_disable attribute under /sys/class/fc_vport

2007-06-12 Thread James Smart
The only thing that should keep the attribute being shown is whether you have a non-zero value for the template .vport_disable function. Double-checked it on my systems... -- james s Seokmann Ju wrote: Hello James, I've got a question on NPIV framwork that is included in FC transport layer.

Re: [PATCH]is_power_of_2-scsi/NCR53C9x.c

2007-06-12 Thread Matthew Wilcox
On Tue, Jun 12, 2007 at 10:54:36AM +0530, vignesh babu wrote: > @@ -1651,7 +1652,7 @@ static inline int reconnect_target(struct NCR_ESP *esp, > struct ESP_regs *eregs) > if(!(it & me)) > return -1; > it &= ~me; > - if(it & (it - 1)) > + if(!is_power_of_2(it)) >

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Henrique de Moraes Holschuh
On Tue, 12 Jun 2007, Matthew Garrett wrote: > On Mon, Jun 11, 2007 at 08:59:46PM -0700, Arjan van de Ven wrote: > > that's a temporary shortcoming; even with these power savings you can > > do hotplug as long as you're willing to poll for it at a reasonable > > interval and are willing to wait th

[PATCH] aacraid: add user initiated reset

2007-06-12 Thread Salyzyn, Mark
Add the ability for an application to issue a hardware reset to the adapter via sysfs. Typical uses include restarting the adapter after it has been flashed. Bumped revision number for the driver and added a feature to periodically check the adapter's health (check_interval), update the adapter's c

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Matthew Garrett
On Tue, Jun 12, 2007 at 09:18:19AM -0300, Henrique de Moraes Holschuh wrote: > On Tue, 12 Jun 2007, Matthew Garrett wrote: > > > > On laptops, I suspect that we'll probably get an ACPI interrupt even if > > the AHCI hotplug pathway can't manage. > > As long as we don't crash the drive or AHCI co

Re: Very slow writes with mptsas

2007-06-12 Thread bloch
On Tue, 05 Jun 2007, [EMAIL PROTECTED] wrote: > Hello > > I'm seeing very slow writes on a Dell Precision 690 with the Dell SAS5 > adapter, serving a RAID1 array of SATA-II disks. > > It's very similar to the problem in FreeBSD, described here: > > http://unix.derkeiler.com/Mailing-Lists/FreeBS

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Henrique de Moraes Holschuh
On Tue, 12 Jun 2007, Matthew Garrett wrote: > On Tue, Jun 12, 2007 at 09:18:19AM -0300, Henrique de Moraes Holschuh wrote: > > On Tue, 12 Jun 2007, Matthew Garrett wrote: > > > > > > On laptops, I suspect that we'll probably get an ACPI interrupt even if > > > the AHCI hotplug pathway can't manag

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Matthew Garrett
On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote: > On Tue, 12 Jun 2007, Matthew Garrett wrote: > > Laptop bays are designed to deal with hotplugging PATA - I don't think > > this is too much of an issue :) > > The new SATA ones use the SATA hardware hotplug ;-) Just

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Tejun Heo
Matthew Garrett wrote: > On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote: >> On Tue, 12 Jun 2007, Matthew Garrett wrote: >>> Laptop bays are designed to deal with hotplugging PATA - I don't think >>> this is too much of an issue :) >> The new SATA ones use the SATA hard

Re: [patch 0/3] AHCI Link Power Management

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 00:43:12 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > We will do AHCI link PM -- presuming that I can be convinced that it > does not repeatedly park the hard drive heads, or something similarly > annoying on PATA<->SATA bridges and similar setups. > > IF it works as adver

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Jeff Garzik
Matthew Garrett wrote: On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote: On Tue, 12 Jun 2007, Matthew Garrett wrote: Laptop bays are designed to deal with hotplugging PATA - I don't think this is too much of an issue :) The new SATA ones use the SATA hardware hotplug

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Matthew Garrett
On Wed, Jun 13, 2007 at 12:45:21AM +0900, Tejun Heo wrote: > Matthew Garrett wrote: > > Yes, but they'll also send an ACPI interrupt even if the SATA host > > controller doesn't - it's part of the spec for bays. > > Does the spec mandate that the ACPI interrupt shouldn't depend on SATA > phy stat

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Matthew Garrett
On Tue, Jun 12, 2007 at 11:46:56AM -0400, Jeff Garzik wrote: > Matthew Garrett wrote: > >On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh > >wrote: > >>On Tue, 12 Jun 2007, Matthew Garrett wrote: > >>>Laptop bays are designed to deal with hotplugging PATA - I don't think > >>

Re: [patch 0/3] AHCI Link Power Management

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 13:40:15 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > I don't think the end result will vary in any significant way. My > biggest argument for sw implementation is it can be used for other > controllers. What I had in mind when I created the new port operation "enable_pm" was

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Jeff Garzik
Matthew Garrett wrote: Excluding the corner case of an Expresscard SATA controller (where I suspect you'd want different policy), I doubt there are any cases where you have a laptop with hotplug capabilities without it being implemented as an ACPI bay. Cardbus card. Jeff - To unsu

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 11:46:56 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Matthew Garrett wrote: > > On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote: > >> On Tue, 12 Jun 2007, Matthew Garrett wrote: > >>> Laptop bays are designed to deal with hotplugging PATA - I don'

Re: qla2xxx errors? (2.6.19)

2007-06-12 Thread Andrew Vasquez
On Sun, 10 Jun 2007, Csillag Tamas wrote: > The university I work at has 4 Blade HS20 servers connected to a IBM > DS400 storage via Fibre Channel. > The fibre channel module is: > > 06:01.0 Fibre Channel: QLogic Corp. QLA2312 Fibre Channel Adapter (rev 02) > 06:01.1 Fibre Channel: QLogic Corp. Q

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-12 Thread Kristen Carlson Accardi
Expose Power Management Policy option to users This patch will modify the scsi subsystem to allow users to set a power management policy for the link. The scsi subsystem will create a new sysfs file for each host in /sys/class/scsi_host called "link_power_management_policy". This file can have 3

Re: [patch 2b/3] Expose Power Management Policy option to users

2007-06-12 Thread Kristen Carlson Accardi
Enable link power management for ata drivers libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be acti

scsi_cmnd accessors issues

2007-06-12 Thread Boaz Harrosh
2 things [1] There are 2 files (see attached patch) that use scsi_befflen() & scsi_sg_count() as L-value. If I try the scsi_sgtable approach and do: #define scsi_sg_count(cmd) ((cmd)->sg_table ? (cmd)->sg_table->sg_count : 0) #define scsi_sglist(cmd) ((cmd)->sg_table ? (cmd)->sg_table->sglist :

Re: scsi_cmnd accessors issues

2007-06-12 Thread Boaz Harrosh
Boaz Harrosh wrote: > 2 things > > [1] > There are 2 files (see attached patch) that use scsi_befflen() & > scsi_sg_count() as > L-value. If I try the scsi_sgtable approach and do: > > #define scsi_sg_count(cmd) ((cmd)->sg_table ? (cmd)->sg_table->sg_count : 0) > #define scsi_sglist(cmd) ((cmd)-

Re: scsi_cmnd accessors issues

2007-06-12 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: scsi_cmnd accessors issues Date: Tue, 12 Jun 2007 21:02:20 +0300 > [2] > if I use __deprecated on request_buffer, request_bufflen, and use_sg with > scsi_sgtable implementation Than I get below list of files complaining: (snip) > and also these fil

[PATCH][RESEND]is_power_of_2-scsi/NCR53C9x.c

2007-06-12 Thread vignesh babu
David S. Miller ([EMAIL PROTECTED]) LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers P: Matthew Wilcox M: [EMAIL PROTECTED] L: linux-scsi@vger.kernel.org S: Maintained Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Thanks Mathew for point