David S. Miller ([EMAIL PROTECTED])
LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
P: Matthew Wilcox
M: [EMAIL PROTECTED]
L: linux-scsi@vger.kernel.org
S: Maintained
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Thanks Mathew for pointing out the double check that was going on for 0.I have
fixed that.
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 8b5334c..60692dc 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -33,6 +33,7 @@
#include <linux/proc_fs.h>
#include <linux/stat.h>
#include <linux/init.h>
+#include <linux/log2.h>
#include "scsi.h"
#include <scsi/scsi_host.h>
@@ -1648,10 +1649,8 @@ static inline int reconnect_target(struct NCR_ESP *esp,
struct ESP_regs *eregs)
if(2 != fcount(esp, eregs))
return -1;
it = esp_read(eregs->esp_fdata);
- if(!(it & me))
- return -1;
it &= ~me;
- if(it & (it - 1))
+ if(!is_power_of_2(it))
return -1;
while(!(it & 1))
targ++, it >>= 1;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
