Re: scsi: Implement per-cpu logging buffer

2015-02-17 Thread Jiri Kosina
On Fri, 13 Feb 2015, Hannes Reinecke wrote: > Thing is, if we were to use per-CPU buffers for printk() out of > necessity we have to queue these buffers for writing out. So there is a > time window during which the message already is in the per-CPU buffer > but still not printed out as printk()

Re: scsi: Implement per-cpu logging buffer

2015-02-15 Thread Josh Triplett
master > >>>>>> Author: Hannes Reinecke > >>>>>> AuthorDate: Thu Jan 8 07:43:42 2015 +0100 > >>>>>> Committer: Christoph Hellwig > >>>>>> CommitDate: Fri Jan 9 15:44:28 2015 +0100 > >>>>>> &

Re: scsi: Implement per-cpu logging buffer

2015-02-14 Thread James Bottomley
master > >>>>>> Author: Hannes Reinecke > >>>>>> AuthorDate: Thu Jan 8 07:43:42 2015 +0100 > >>>>>> Committer: Christoph Hellwig > >>>>>> CommitDate: Fri Jan 9 15:44:28 2015 +0100 > >>>>>> > &g

Re: scsi: Implement per-cpu logging buffer

2015-02-14 Thread Geert Uytterhoeven
Hi Hannes, On Sat, Feb 14, 2015 at 3:29 PM, Hannes Reinecke wrote: > @jejb, hch: should I do a new patch or update the existing one? As the existing one is already upstream, you should send a new patch. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's

Re: scsi: Implement per-cpu logging buffer

2015-02-14 Thread Hannes Reinecke
; Commit: ded85c193a391a84076d5c6a7a5668fe164a490e >>>>>> Parent: b0a93d96b2814c725161f91a4e35d0c29ec0f95b >>>>>> Refname:refs/heads/master >>>>>> Author: Hannes Reinecke >>>>>> AuthorDate: Thu Jan 8 07:43:42 2015 +

Re: scsi: Implement per-cpu logging buffer

2015-02-13 Thread Josh Triplett
arent: b0a93d96b2814c725161f91a4e35d0c29ec0f95b > >>>> Refname:refs/heads/master > >>>> Author: Hannes Reinecke > >>>> AuthorDate: Thu Jan 8 07:43:42 2015 +0100 > >>>> Committer: Christoph Hellwig > >>>> Comm

Re: scsi: Implement per-cpu logging buffer

2015-02-13 Thread Hannes Reinecke
>> Author: Hannes Reinecke >>>> AuthorDate: Thu Jan 8 07:43:42 2015 +0100 >>>> Committer: Christoph Hellwig >>>> CommitDate: Fri Jan 9 15:44:28 2015 +0100 >>>> >>>> scsi: Implement per-cpu logging buffer >>>> >>

Re: scsi: Implement per-cpu logging buffer

2015-02-12 Thread Josh Triplett
015 +0100 > >> Committer: Christoph Hellwig > >> CommitDate: Fri Jan 9 15:44:28 2015 +0100 > >> > >> scsi: Implement per-cpu logging buffer > >> > >> Implement a per-cpu buffer for formatting messages to avoid line breaks > >>

Re: scsi: Implement per-cpu logging buffer

2015-02-12 Thread Hannes Reinecke
5668fe164a490e >> Parent: b0a93d96b2814c725161f91a4e35d0c29ec0f95b >> Refname:refs/heads/master >> Author: Hannes Reinecke >> AuthorDate: Thu Jan 8 07:43:42 2015 +0100 >> Committer: Christoph Hellwig >> CommitDate: Fri Jan 9 15:44:28 2015 +0100 >> >&

Re: scsi: Implement per-cpu logging buffer

2015-02-12 Thread Geert Uytterhoeven
efname:refs/heads/master > Author: Hannes Reinecke > AuthorDate: Thu Jan 8 07:43:42 2015 +0100 > Committer: Christoph Hellwig > CommitDate: Fri Jan 9 15:44:28 2015 +0100 > > scsi: Implement per-cpu logging buffer > > Implement a per-cpu buffer for formatting

Re: [PATCH 1/9] scsi: Implement per-cpu logging buffer

2015-01-13 Thread James Bottomley
On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: > - sdev_printk(prefix, (scmd)->device, fmt, ##a) > +extern int sdev_prefix_printk(const char *, const struct scsi_device *, > + const char *, const char *, ...); > + > +#define sdev_printk(l, sdev, fmt, a...)

[PATCH 1/9] scsi: Implement per-cpu logging buffer

2015-01-07 Thread Hannes Reinecke
Implement a per-cpu buffer for formatting messages to avoid line break up under high load. This patch implements scmd_printk() and sdev_prefix_printk() using the per-cpu buffer and makes sdev_printk() a wrapper for sdev_prefix_printk(). Tested-by: Robert Elliott Reviewed-by: Robert Elliott Signe

Re: [PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-18 Thread Hannes Reinecke
On 11/17/2014 08:44 PM, Douglas Gilbert wrote: > On 14-11-17 08:25 AM, Hannes Reinecke wrote: >> Implement a per-cpu buffer for formatting messages to >> avoid line break up under high load. >> This patch implements scmd_printk() and sdev_prefix_printk() >> using the per-cpu buffer and makes sdev_p

Re: [PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-17 Thread Douglas Gilbert
On 14-11-17 08:25 AM, Hannes Reinecke wrote: Implement a per-cpu buffer for formatting messages to avoid line break up under high load. This patch implements scmd_printk() and sdev_prefix_printk() using the per-cpu buffer and makes sdev_printk() a wrapper for sdev_prefix_printk(). Tested-by: Rob

[PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-17 Thread Hannes Reinecke
Implement a per-cpu buffer for formatting messages to avoid line break up under high load. This patch implements scmd_printk() and sdev_prefix_printk() using the per-cpu buffer and makes sdev_printk() a wrapper for sdev_prefix_printk(). Tested-by: Robert Elliott Reviewed-by: Robert Elliott Signe

RE: [PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-12 Thread Elliott, Robert (Server Storage)
Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 03/10] scsi: Implement per-cpu logging buffer > > +++ b/drivers/scsi/scsi_logging.c > @@ -0,0 +1,119 @@ ... > +static DEFINE_PER_CPU(struct scsi_log_buf, scs

[PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-06 Thread Hannes Reinecke
Implement a per-cpu buffer for formatting messages to avoid line break up under high load. This patch implements scmd_printk() and sdev_prefix_printk() using the per-cpu buffer and makes sdev_printk() a wrapper for sdev_prefix_printk(). Signed-off-by: Hannes Reinecke --- drivers/scsi/Makefile