On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote:
> -     sdev_printk(prefix, (scmd)->device, fmt, ##a)
> +extern int sdev_prefix_printk(const char *, const struct scsi_device *,
> +                           const char *, const char *, ...);
> +
> +#define sdev_printk(l, sdev, fmt, a...)                              \
> +     sdev_prefix_printk(l, sdev, NULL, fmt, ##a)
> +
> +extern int scmd_printk(const char *, const struct scsi_cmnd *,
> +                    const char *, ...);
>  
>  #define scmd_dbg(scmd, fmt, a...)                                       \
>       do {                                                               \

These new prototypes need to be printf format checked, otherwise you
lose us some type checking that gcc was doing:

extern __printf(4, 5)
int sdev_prefix_printk(const char *, const struct scsi_device *,
                      const char *, const char *, ...);

James

N�����r��y����b�X��ǧv�^�)޺{.n�+����{���"�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i

Reply via email to