Re: [RFC 18/34] iscsi-target: call complete on conn_logout_comp

2016-03-05 Thread Nicholas A. Bellinger
On Tue, 2016-03-01 at 06:52 -0800, Christoph Hellwig wrote: > On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote: > > >+ if ((conn->conn_transport->transport_type == ISCSI_TCP) || > > >+ (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4)) > > > complete(&conn->conn

Re: [RFC 18/34] iscsi-target: call complete on conn_logout_comp

2016-03-01 Thread Christoph Hellwig
On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote: > >+if ((conn->conn_transport->transport_type == ISCSI_TCP) || > >+(conn->conn_transport->transport_type == ISCSI_TCP_CXGB4)) > > complete(&conn->conn_logout_comp); > > IMO, this is an indication that this condi

Re: [RFC 18/34] iscsi-target: call complete on conn_logout_comp

2016-02-15 Thread Sagi Grimberg
On 14/02/2016 19:42, Varun Prakash wrote: ISCSI_TCP_CXGB4 driver waits on conn_logout_comp as ISCSI_TCP driver so call complete if transport type is ISCSI_TCP_CXGB4. Signed-off-by: Varun Prakash --- drivers/target/iscsi/iscsi_target.c | 10 ++ 1 file changed, 6 insertions(+), 4 del