On Tue, 2016-03-01 at 06:52 -0800, Christoph Hellwig wrote:
> On Mon, Feb 15, 2016 at 07:07:19PM +0200, Sagi Grimberg wrote:
> > >+  if ((conn->conn_transport->transport_type == ISCSI_TCP) ||
> > >+      (conn->conn_transport->transport_type == ISCSI_TCP_CXGB4))
> > >           complete(&conn->conn_logout_comp);
> > 
> > IMO, this is an indication that this condition is a bandage in the first
> > place...
> 
> Agreed.  Nevermind the fact that a spurious complete() is perfectly
> harmless..
> 

iser-target uses the same completion isert_wait4logout() waiting for a
logout_posted response, which is why a spurious wakeup is not OK here.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to