Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-08-06 Thread Sagi Grimberg
On 7/25/2014 11:34 PM, Martin K. Petersen wrote: For commands like REQ_COPY we need a way to pass extra information along with each bio. Like integrity metadata this information must be available at the bottom of the stack so bi_private does not suffice. Rename the existing bi_integrity field to

Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-07-26 Thread Christoph Hellwig
Not sure what this buys us until other uses show up, but it looks fine to me: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-07-03 Thread Sagi Grimberg
On 6/12/2014 3:18 AM, Martin K. Petersen wrote: "Christoph" == Christoph Hellwig writes: Christoph> Instead of having a union of pointer just make it a void Christoph> pointer. I also think special is a terribly generic name, but Christoph> I don't really have a better idea at hand. I needed s

Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-06-11 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Instead of having a union of pointer just make it a void Christoph> pointer. I also think special is a terribly generic name, but Christoph> I don't really have a better idea at hand. I needed something that could encompass additional inf

Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-06-11 Thread Christoph Hellwig
On Wed, May 28, 2014 at 11:28:36PM -0400, Martin K. Petersen wrote: > For commands like REQ_COPY we need a way to pass extra information along > with each bio. Like integrity metadata this information must be > available at the bottom of the stack so bi_private does not suffice. > > Rename the exi