On 6/12/2014 3:18 AM, Martin K. Petersen wrote:
"Christoph" == Christoph Hellwig <h...@infradead.org> writes:
Christoph> Instead of having a union of pointer just make it a void
Christoph> pointer. I also think special is a terribly generic name, but
Christoph> I don't really have a better idea at hand.
I needed something that could encompass additional information to be
passed for integrity, copy offload and discard requests.
Another option is that we forgo the union name:
union {
#if defined(CONFIG_BLK_DEV_INTEGRITY)
struct bio_integrity_payload *bi_integrity;
#endif
struct bio_copy *bi_copy;
};
That's the way Jens has done it in struct request. I think I like that
better and it doesn't send the same up-for-grabs signal that a void
pointer might.
Jens: Any preference?
A nameless union makes more sense to me here.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
