On Wednesday 31 August 2005 16:43, Greg KH wrote:
> On Thu, Aug 18, 2005 at 02:50:19PM -0500, Dmitry Torokhov wrote:
> > On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote:
> > > @@ -500,9 +519,13 @@ int class_device_add(struct class_device
> > >}
> > >
> > >class_device_add_attrs(class
On Thu, Aug 18, 2005 at 02:50:19PM -0500, Dmitry Torokhov wrote:
> On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote:
> > @@ -500,9 +519,13 @@ int class_device_add(struct class_device
> >}
> >
> >class_device_add_attrs(class_dev);
> > - if (class_dev->dev)
> > + if (class_d
On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote:
> @@ -500,9 +519,13 @@ int class_device_add(struct class_device
>}
>
>class_device_add_attrs(class_dev);
> - if (class_dev->dev)
> + if (class_dev->dev) {
> + class_name = make_class_name(class_dev);
>
On Thu, Aug 18, 2005 at 12:04:42AM -0700, Greg KH wrote:
> Matthew, this work for you?
Yep, that's fine by me. Thanks.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will
thew Wilcox; Smart, James; Andrew Morton; SCSI Mailing List;
> Linux Kernel; Alan Cox; Russell King; Dmitry Torokhov
> Subject: Re: [PATCH] add transport class symlink to device object
>
>
> On Wed, Aug 17, 2005 at 10:23:11PM -0700, Greg KH wrote:
> > On Mon, Aug 15, 2
> They are class devices called ttyS0, ttyS1, ttyS2 so you can say
> they're uniquely named.
>
> The problem is that Matthew wants to add a symlink from the device
> device to the class device to complement the class device to device
> symlink, since we end up with multiple symlinks in the devices
On Thu, Aug 18, 2005 at 07:50:27AM +0100, Russell King wrote:
> On Wed, Aug 17, 2005 at 11:41:29PM -0700, Greg KH wrote:
> > On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote:
> > > On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote:
> > > > On Mon, Aug 15, 2005 at 09:32:44AM +0100,
On Wed, Aug 17, 2005 at 11:41:29PM -0700, Greg KH wrote:
> On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote:
> > On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote:
> > > On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote:
> > > > On Mon, Aug 15, 2005 at 01:43:03AM +0100,
On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote:
> On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote:
> > On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote:
> > > On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote:
> > > > On Sun, Aug 14, 2005 at 11:25:25PM
On Wed, Aug 17, 2005 at 10:23:11PM -0700, Greg KH wrote:
> On Mon, Aug 15, 2005 at 05:41:17PM -0500, James Bottomley wrote:
> > Actually, isn't the fix to all of this to combine Greg and James'
> > patches?
>
> Yes it is.
>
> > The Greg one fails in SCSI because we don't have unique class device
On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote:
> On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote:
> > On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote:
> > > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote:
> > > > Eww. Do you really want one struc
On Mon, Aug 15, 2005 at 05:41:17PM -0500, James Bottomley wrote:
> On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote:
> > /sys/class/tty/ttyS0/device ->
> > ../../../devices/parisc/0/0:0/pci:00/:00:04.0
> > /sys/class/tty/ttyS1/device ->
> > ../../../devices/parisc/0/0:0/pci:00/
On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote:
> On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote:
> > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote:
> > > Eww. Do you really want one struct device per tty with all the
> > > memory each one eats?
> > >
On Tue, Aug 16, 2005 at 09:37:18AM -0400, Luben Tuikov wrote:
> On 08/15/05 20:52, [EMAIL PROTECTED] wrote:
> > My vote is to make the multiplexor instantiate each serial line
> > as a separate device.
>
> Yes, you're absolutely and completely correct. I think the same
> way as you do.
Just don'
> On Mon, 2005-08-15 at 20:52 -0400, [EMAIL PROTECTED] wrote:
> > What is ":00:04:0" in this case ? The "device" is not a serial
> > port, which is what the ttyXX back link would lead you to believe.
> > Thus, it's a serial port multiplexer that supports up to N ports,
> > right ? and wouldn't
On 08/15/05 21:08, James Bottomley wrote:
>>Think if SCSI used this same style of representation. For example,
>>if there was no scsi target device entity, but class entities did
>>exist and they just pointed back to the scsi host device entry.
>
>
> Yes, it's theoretically possible to have had S
On 08/15/05 20:52, [EMAIL PROTECTED] wrote:
> Actually, I view this as being a little odd...
>
> What is ":00:04:0" in this case ? The "device" is not a serial
> port, which is what the ttyXX back link would lead you to believe.
> Thus, it's a serial port multiplexer that supports up to N port
On Mon, 2005-08-15 at 20:52 -0400, [EMAIL PROTECTED] wrote:
> What is ":00:04:0" in this case ? The "device" is not a serial
> port, which is what the ttyXX back link would lead you to believe.
> Thus, it's a serial port multiplexer that supports up to N ports,
> right ? and wouldn't the more c
Actually, I view this as being a little odd...
What is ":00:04:0" in this case ? The "device" is not a serial
port, which is what the ttyXX back link would lead you to believe.
Thus, it's a serial port multiplexer that supports up to N ports,
right ? and wouldn't the more correct representatio
On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote:
> /sys/class/tty/ttyS0/device ->
> ../../../devices/parisc/0/0:0/pci:00/:00:04.0
> /sys/class/tty/ttyS1/device ->
> ../../../devices/parisc/0/0:0/pci:00/:00:04.0
> /sys/class/tty/ttyS2/device ->
> ../../../devices/parisc/0/
On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote:
> On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote:
> > Eww. Do you really want one struct device per tty with all the
> > memory each one eats?
> >
> > If that's really what you want you need to talk to Alan and not me.
On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote:
> On Sun, Aug 14, 2005 at 04:02:31PM +0100, Matthew Wilcox wrote:
> > Last time I tried to do something like this, it fell over with
> > multi-function serial ports. Look at this example:
> >
> > # ls -l /sys/class/tty/ttyS*/device | c
On Sun, Aug 14, 2005 at 04:02:31PM +0100, Matthew Wilcox wrote:
> On Sat, Aug 13, 2005 at 02:39:56PM -0700, Greg KH wrote:
> > Heh, I already have a patch like this pending for 2.6.14 at:
> >
> > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/driver-link-devic
On Sat, Aug 13, 2005 at 02:39:56PM -0700, Greg KH wrote:
> Heh, I already have a patch like this pending for 2.6.14 at:
>
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/driver-link-device-and-class.patch
Last time I tried to do something like this, it fel
On Sun, 2005-08-14 at 08:42 -0400, [EMAIL PROTECTED] wrote:
> I'll trust that James B's fix resolves things. Thought my testing was
> straight-forward and ok. Guess not. Humbled again as a mere mortal in
> the world of sysfs and transport/container logic... :)
Well ... I confidently predict that y
I'll trust that James B's fix resolves things. Thought my testing was
straight-forward and ok. Guess not. Humbled again as a mere mortal in
the world of sysfs and transport/container logic... :)
Anyway, the last item that needs discussion is what name should the
symlink have ?
Here's a few points
On Sat, 2005-08-13 at 19:42 -0500, James Bottomley wrote:
> I'll look into it.
OK, I think this fix will work for either patch. The problem is that if
the class hasn't been made visible, then the dentry has no inode, so in
that case we can just exit out of sysfs_hash_and_remove().
Someone needs
On Sat, 2005-08-13 at 18:36 -0500, James Bottomley wrote:
> And the reason why yours crashes and James' doesn't is the kobject_name
> (). Kobject names aren't valid until the object is visible, which is
> long after the class is created in the SCSI case. The actual panic is
> in removal on a NULL
On Sat, 2005-08-13 at 14:39 -0700, Greg KH wrote:
> Andrew keeps disabling it in the -mm releases due to it misbehaiving on
> some of his scsi devices. Perhaps he can post that oops message again
> so that someone here can fix it up before I add it to the main tree?
Actually, no need, it oopses f
On Sat, Aug 13, 2005 at 11:34:17AM -0400, [EMAIL PROTECTED] wrote:
> In prior conversations with folks doing utilities such as lsscsi, it became
> rather apparent that it is difficult to establish the relationships between
> the class device and its base device. The class->device symlink is good fo
30 matches
Mail list logo
