Re: scsi_cmnd accessors issues

2007-06-16 Thread Guennadi Liakhovetski
Hi On Tue, 12 Jun 2007, Boaz Harrosh wrote: > I get compilation errors. Attached solution is to add scsi_set_ > accessors to these members. But it would be best to STOP these drivers > from doing that ugly hack of modifying sg_count and bufflen. > (CC sign-off-by maintainers of the drivers in q

Re: scsi_cmnd accessors issues

2007-06-13 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: Re: scsi_cmnd accessors issues Date: Wed, 13 Jun 2007 20:24:42 +0900 > > drivers/scsi/sym53c8xx_2/sym_glue.h > > drivers/scsi/sym53c8xx_2/sym_glue.c > > The patch was in my old bidi tree but seems that it's in

Re: scsi_cmnd accessors issues

2007-06-13 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: scsi_cmnd accessors issues Date: Tue, 12 Jun 2007 21:02:20 +0300 Oops, I forgot to answer the status of lld conversion. > [2] > if I use __deprecated on request_buffer, request_bufflen, and use_sg with > scsi_sgtable implementation Than I get below

RE: scsi_cmnd accessors issues

2007-06-13 Thread FUJITA Tomonori
From: "Harrosh, Boaz" <[EMAIL PROTECTED]> Subject: RE: scsi_cmnd accessors issues Date: Wed, 13 Jun 2007 06:32:23 -0400 > From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] > Sent: Tue 6/12/2007 7:51 PM > To: Harrosh, Boaz > Cc: linux-scsi@vger.kernel.org; [EMAIL

RE: scsi_cmnd accessors issues

2007-06-13 Thread Harrosh, Boaz
From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] Sent: Tue 6/12/2007 7:51 PM To: Harrosh, Boaz Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: scsi_cmnd accessors issues > From: Boaz Harrosh <[EMAIL PROTECTED]> > Subject: scsi_cm

Re: scsi_cmnd accessors issues

2007-06-12 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: scsi_cmnd accessors issues Date: Tue, 12 Jun 2007 21:02:20 +0300 > [2] > if I use __deprecated on request_buffer, request_bufflen, and use_sg with > scsi_sgtable implementation Than I get below list of files complaining: (snip) > and also these fil

Re: scsi_cmnd accessors issues

2007-06-12 Thread Boaz Harrosh
Boaz Harrosh wrote: > 2 things > > [1] > There are 2 files (see attached patch) that use scsi_befflen() & > scsi_sg_count() as > L-value. If I try the scsi_sgtable approach and do: > > #define scsi_sg_count(cmd) ((cmd)->sg_table ? (cmd)->sg_table->sg_count : 0) > #define scsi_sglist(cmd) ((cmd)-