RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread Seungwon Jeon
review of a function with no callers is only > partial because you've no idea how it will be used. Whereas if you > review a function and its callers, you can see how the API works and > possibly suggest improvements. Thank you for your feedback. Okay, it will be reintroduced

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread James Bottomley
On Thu, 2013-05-09 at 12:22 +0530, Santosh Y wrote: > On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon wrote: > > On Thursday, May 09, 2013 Santosh wrote: > >> > There are two patches remained. These are applied with your final > >> > comments. > >> > Do you have any idea? > >> > [PATCH v4 5/6] scs

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon wrote: > On Thursday, May 09, 2013 Santosh wrote: >> > There are two patches remained. These are applied with your final comments. >> > Do you have any idea? >> > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives >> > [PATCH v4 6/6] scsi: ufs

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
On Thursday, May 09, 2013 Santosh wrote: > > There are two patches remained. These are applied with your final comments. > > Do you have any idea? > > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives > > [PATCH v4 6/6] scsi: ufs: add dme control primitives > > > > Since there is no use c

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
> There are two patches remained. These are applied with your final comments. > Do you have any idea? > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives > [PATCH v4 6/6] scsi: ufs: add dme control primitives > Since there is no use case for these implementations yet, except for ufshcd_ge

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
On Thursday, May 09, 2013, Santosh Y wrote: > On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > > Simplify operations with hiding mmio_base. > > > > Signed-off-by: Seungwon Jeon > > Tested-by: Maya Erez > > --- > > drivers/scsi/ufs/ufshcd.c | 105 > > +++--

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > Simplify operations with hiding mmio_base. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c | 105 > +++-- > drivers/scsi/ufs/ufshcd.h |7 +++- > 2 files

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread merez
Hi, I tested the new set of patches (v4 1-6) and it works. Thanks, Maya > Simplify operations with hiding mmio_base. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c | 105 > +++-- > drivers/scsi/ufs/ufshcd.h |

[PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- drivers/scsi/ufs/ufshcd.c | 105 +++-- drivers/scsi/ufs/ufshcd.h |7 +++- 2 files changed, 50 insertions(+), 62 deletions(-) diff --git a/drivers/scsi/u