Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-06 Thread Tejun Heo
On Wed, Jul 06, 2016 at 06:40:32AM +, Tom Yan wrote: > Um it's not mainly about in caps or not, but more about wrongly spelled as > cbd. Heh, right, so please just note it in the description. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-05 Thread Tom Yan
Um it's not mainly about in caps or not, but more about wrongly spelled as cbd. On 5 July 2016 at 22:39, Tejun Heo wrote: > Hello, > > On Wed, Jul 06, 2016 at 03:13:31AM +0800, Tom Yan wrote: >> I just thought that such a minor change in a comment can fit in the >> same patch where the issue was

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-05 Thread Tejun Heo
Hello, On Wed, Jul 06, 2016 at 03:13:31AM +0800, Tom Yan wrote: > I just thought that such a minor change in a comment can fit in the > same patch where the issue was first noticed. Anyway, will split them > if I am going to send a v3 set. > > On 5 July 2016 at 19:08, Sergei Shtylyov > wrote: >

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-05 Thread Tom Yan
I just thought that such a minor change in a comment can fit in the same patch where the issue was first noticed. Anyway, will split them if I am going to send a v3 set. On 5 July 2016 at 19:08, Sergei Shtylyov wrote: > On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> It d

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-05 Thread Sergei Shtylyov
On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation

[PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-04 Thread tom . ty89
From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation code" instead. Signed-off-by: Tom Yan diff --gi