Re: [PATCH 3/9] scsi: use external buffer for command logging

2015-01-14 Thread James Bottomley
On Wed, 2015-01-14 at 10:36 +0100, h...@lst.de wrote: > On Tue, Jan 13, 2015 at 06:56:17PM +, James Bottomley wrote: > > I really hate using an on-stack buffer here ... we're pretty deep in the > > call chain already. > > > > Since it's just required for printing a "command: " prefix, why not

Re: [PATCH 3/9] scsi: use external buffer for command logging

2015-01-14 Thread h...@lst.de
On Tue, Jan 13, 2015 at 06:56:17PM +, James Bottomley wrote: > I really hate using an on-stack buffer here ... we're pretty deep in the > call chain already. > > Since it's just required for printing a "command: " prefix, why not just > use scsi_print_command()? Both the ch and sr callers are

Re: [PATCH 3/9] scsi: use external buffer for command logging

2015-01-13 Thread James Bottomley
On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: > Use an external buffer for __scsi_print_command() and > move command logging over to use the per-cpu logging > buffer. With that we can guarantee the command always > will always be formatted in one line. > So we can even print out a varia

[PATCH 3/9] scsi: use external buffer for command logging

2015-01-07 Thread Hannes Reinecke
Use an external buffer for __scsi_print_command() and move command logging over to use the per-cpu logging buffer. With that we can guarantee the command always will always be formatted in one line. So we can even print out a variable length command correctly across several lines. Finally rename __