On Tue, Jan 13, 2015 at 06:56:17PM +0000, James Bottomley wrote: > I really hate using an on-stack buffer here ... we're pretty deep in the > call chain already. > > Since it's just required for printing a "command: " prefix, why not just > use scsi_print_command()?
Both the ch and sr callers are not really a problem in terms of stack usage, as they are directly in file operations of character or block devices, so the whole FS/MM stack stack problem isn't an issue. But using higher level functions might still be useful here. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
