> On Fri, 12 Oct 2018, Christoph Hellwig wrote:
>
> >
> > > diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
> > > index eb551f3cc471..85d067889a9b 100644
> > > --- a/drivers/scsi/mac_esp.c
> > > +++ b/drivers/scsi/mac_esp.c
> > > @@ -58,8 +58,7 @@ static struct esp *esp_chips[2];
> >
On Fri, Oct 12, 2018 at 04:47:23PM +1100, Finn Thain wrote:
> > + esp->dev = &dev->dev;
> >
> > esp->command_block = kzalloc(16, GFP_KERNEL);
> > if (!esp->command_block)
>
>
> Isn't this missing the corresponding dev_set_drvdata() in esp_mac_probe()?
> Also conversion to dev_get_drv
On Thu, 11 Oct 2018, Christoph Hellwig wrote:
> esp->dev is a void pointer that points either to a struct device, or a
> struct platform_device. As we can easily get from the device to the
> platform_device if needed change it to always point to a struct device
> and properly type the pointer to
esp->dev is a void pointer that points either to a struct device, or a
struct platform_device. As we can easily get from the device to the
platform_device if needed change it to always point to a struct device
and properly type the pointer to avoid errors.
Signed-off-by: Christoph Hellwig
---
d
4 matches
Mail list logo
