Re: [PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()

2019-03-14 Thread Martin K. Petersen
Dan, > It used to be that "error" was set to -ENODEV at the start of the > function but we shifted some code around an now "error" is set to zero > for most error paths. There is a mix of direct returns and "goto out" > but I changed everything to direct returns for consistency. Applied to 5.1

Re: [PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()

2019-03-13 Thread James Smart
On 3/6/2019 9:33 PM, Dan Carpenter wrote: It used to be that "error" was set to -ENODEV at the start of the function but we shifted some code around an now "error" is set to zero for most error paths. There is a mix of direct returns and "goto out" but I changed everything to direct returns f

[PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()

2019-03-06 Thread Dan Carpenter
It used to be that "error" was set to -ENODEV at the start of the function but we shifted some code around an now "error" is set to zero for most error paths. There is a mix of direct returns and "goto out" but I changed everything to direct returns for consistency. Fixes: 56de8357049c ("scsi: lp