Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-21 Thread Martin K. Petersen
Sabyasachi, > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Applied to 4.21/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-20 Thread John Garry
On 20/11/2018 21:52, James Smart wrote: On 11/20/2018 1:40 AM, John Garry wrote: please ensure that you maintain alignment with opening brackets I don't think this is a requirement. From the rules I've read preference is tabs-only indentation. This is the only rule (enforcement) I see: htt

Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-20 Thread James Smart
On 11/18/2018 6:38 AM, Sabyasachi Gupta wrote: Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/scsi/lpfc/lpfc_sli.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc

Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-20 Thread James Smart
On 11/20/2018 1:40 AM, John Garry wrote: please ensure that you maintain alignment with opening brackets I don't think this is a requirement.  From the rules I've read preference is tabs-only indentation.  Spacing (less than a tab), after tabs, for open brace alignment is allowed, thus is c

Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-20 Thread John Garry
On 18/11/2018 14:38, Sabyasachi Gupta wrote: Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/scsi/lpfc/lpfc_sli.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpf

[PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

2018-11-18 Thread Sabyasachi Gupta
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/scsi/lpfc/lpfc_sli.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 783a154..3491ff7 100644 --- a/dri