Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

[James Smart]

On 11/18/2018 6:38 AM, Sabyasachi Gupta wrote:

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by: Sabyasachi Gupta <sabyasachi.li...@gmail.com>
---
  drivers/scsi/lpfc/lpfc_sli.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 783a154..3491ff7 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -6229,7 +6229,7 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
                        goto free_mem;
                }

- dmabuf->virt = dma_alloc_coherent(&phba->pcidev->dev,

+               dmabuf->virt = dma_zalloc_coherent(&phba->pcidev->dev,
                                                  LPFC_RAS_MAX_ENTRY_SIZE,
                                                  &dmabuf->phys,
                                                  GFP_KERNEL);
@@ -6240,7 +6240,6 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
                                        "6187 DMA Alloc Failed FW logging");
                        goto free_mem;
                }
-               memset(dmabuf->virt, 0, LPFC_RAS_MAX_ENTRY_SIZE);
                dmabuf->buffer_tag = i;
                list_add_tail(&dmabuf->list, &ras_fwlog->fwlog_buff_list);
        }

Looks fine.

-- james

Reviewed-by:   James Smart   <jsmart2...@gmail.com>