Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-11 Thread Johannes Thumshirn
On Wed, Feb 10, 2016 at 01:32:50PM -0500, Dick Kennedy wrote: > Martin,  > the FCP_RING_POLLING feature is an old driver option that we would like to > remove from the driver. It was put in in 2006 as a feature request. > What we don't know is if any customers still use it? or ever used it.  > > T

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-10 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> This removes a redundant code block that will either be Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in Johannes> phba->cfg_poll or not. The code is just duplicated in both Johannes> cases, hence we unify it again. Johanne

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-10 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> This removes a redundant code block that will either be Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in Johannes> phba->cfg_poll or not. The code is just duplicated in both Johannes> cases, hence we unify it again. James a

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-26 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> This removes a redundant code block that will either be Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in Johannes> phba->cfg_poll or not. The code is just duplicated in both Johannes> cases, hence we unify it again. Johanne

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Sebastian Herbszt
Johannes Thumshirn wrote: > This removes a redundant code block that will either be executed if the > ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just > duplicated in both cases, hence we unify it again. > > This probably is a left over from some sort of refactoring.

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Tomas Henzl
On 20.1.2016 16:08, Johannes Thumshirn wrote: > This removes a redundant code block that will either be executed if the > ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just > duplicated in both cases, hence we unify it again. > > This probably is a left over from some so

[PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Johannes Thumshirn
This removes a redundant code block that will either be executed if the ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just duplicated in both cases, hence we unify it again. This probably is a left over from some sort of refactoring. Signed-off-by: Johannes Thumshirn