Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-13 Thread malahal
Jens Axboe [EMAIL PROTECTED] wrote: > +static void blk_rq_timed_out_timer(unsigned long data) > +{ > + struct request_queue *q = (struct request_queue *) data; > + unsigned long flags, next = 0; > + struct request *rq, *tmp; > + > + spin_lock_irqsave(q->queue_lock, flags); > + > +

Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2007 at 02:34:53PM -0800, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. Looks

Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-07 Thread Jens Axboe
On Tue, Nov 06 2007, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. I updated the timeout patch

Re: [PATCH] gdth: scp timeout clean up (try #2)

2007-11-06 Thread malahal
gdth driver is modified NOT to use scp->eh_timeout. Now, it has eh_timed_out (gdth_timed_out) to handle command timeouts for locked I/O's. Have not tested as I don't have needed hardware! Patch is against 2.6.23-mm1. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r dbb45a1edd2a drivers/

Re: [PATCH] gdth: scp timeout clean up

2007-11-06 Thread malahal
Boaz Harrosh [EMAIL PROTECTED] wrote: > > +static enum scsi_eh_timer_return gdth_timed_out(struct scsi_cmnd *scp) > > +{ > > + gdth_ha_str *ha = shost_priv(scp->device->host); > > + struct gdth_cmndinfo *cmndinfo = gdth_get_cmndinfo(ha); > > a gdth_get_cmndinfo(ha) is for allocating a new cmnd

Re: [PATCH] gdth: scp timeout clean up

2007-11-05 Thread Boaz Harrosh
On Tue, Nov 06 2007 at 8:54 +0200, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. > > Thank you

[PATCH] gdth: scp timeout clean up

2007-11-05 Thread malahal
gdth driver is modified NOT to use scp->eh_timeout. Now, it has eh_timed_out (gdth_timed_out) to handle command timeouts for locked I/O's. Have not tested as I don't have needed hardware! Patch is against 2.6.23-mm1. Thank you Matthew Wilcox for your input on the IRC channel. Signed-off-by: Malah