Re: [PATCH] blk request timeout minor fixes...

es timing out issues. Thanks, Malahal. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] blk request timeout minor fixes...

ed another field because I couldn't find a way to use just one field without breaking something! I will gladly clean it up if you find a way to fix it. Thanks, Malahal. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAI

Re: [PATCH] blk request timeout minor fixes...

Matthew Wilcox [EMAIL PROTECTED] wrote: > On Sun, Dec 02, 2007 at 05:53:30PM -0800, [EMAIL PROTECTED] wrote: > Can I suggest running 'pahole' over this when compiled on 64-bit? > You've just introduced a 4-byte hole. This one fixes the 4-byte hole. Thank you very much. diff --git a/block/ll_rw_b

[PATCH] blk request timeout minor fixes...

Adds deadline field to preserve the timeout on retries. Calculates next timeout for mod_timer correctly and uses an extra symbol, next_set, as zero could be a valid 'next' value. Based off of timeout branch from Jens git repo. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]&g

Re: [PATCH] gdth: scp timeout clean up (try #2)

Jens Axboe [EMAIL PROTECTED] wrote: > +static void blk_rq_timed_out_timer(unsigned long data) > +{ > + struct request_queue *q = (struct request_queue *) data; > + unsigned long flags, next = 0; > + struct request *rq, *tmp; > + > + spin_lock_irqsave(q->queue_lock, flags); > + > +

Re: [PATCH] gdth: scp timeout clean up (try #2)

gdth driver is modified NOT to use scp->eh_timeout. Now, it has eh_timed_out (gdth_timed_out) to handle command timeouts for locked I/O's. Have not tested as I don't have needed hardware! Patch is against 2.6.23-mm1. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r d

Re: [PATCH] gdth: scp timeout clean up

Boaz Harrosh [EMAIL PROTECTED] wrote: > > +static enum scsi_eh_timer_return gdth_timed_out(struct scsi_cmnd *scp) > > +{ > > + gdth_ha_str *ha = shost_priv(scp->device->host); > > + struct gdth_cmndinfo *cmndinfo = gdth_get_cmndinfo(ha); > > a gdth_get_cmndinfo(ha) is for allocating a new cmnd

[PATCH] gdth: scp timeout clean up

Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r dbb45a1edd2a drivers/scsi/gdth.c --- a/drivers/scsi/gdth.c Mon Nov 05 21:32:26 2007 -0800 +++ b/drivers/scsi/gdth.c Mon Nov 05 21:54:27 2007 -0800 @@ -2056,22 +2056,12 @@ static void gdth_putq(gdth_ha_str *ha, S regis

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

[EMAIL PROTECTED] [EMAIL PROTECTED] wrote: > Jens Axboe [EMAIL PROTECTED] wrote: > > Current code is below, btw. Not a lot of changes, iirc it's just the > > delete-always, a missing export, delete timer on empty list. > > > > +void blk_add_timer(struct request *req) > > +{ > > + struct request_

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

Jens Axboe [EMAIL PROTECTED] wrote: > Current code is below, btw. Not a lot of changes, iirc it's just the > delete-always, a missing export, delete timer on empty list. > > +void blk_add_timer(struct request *req) > +{ > + struct request_queue *q = req->q; > + unsigned long expiry; > + >

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

Jens Axboe [EMAIL PROTECTED] wrote: > On Tue, Oct 09 2007, James Bottomley wrote: > > On Tue, 2007-10-09 at 14:15 +0200, Jens Axboe wrote: > > > On Tue, Oct 09 2007, Matthew Wilcox wrote: > > > > On Mon, Oct 08, 2007 at 10:36:10PM -0700, [EMAIL PROTECTED] wrote: > > > > > Thank you Randy, Jens for

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

I don't see blk_delete_timer() actually calling mod_timer/del_timer at all. Doesn't that mean, your timer would eventually expire for no reason and walk through the list unnecessarily? Thanks, Malahal. Jens Axboe [EMAIL PROTECTED] wrote: > On Tue, Oct 09 2007, James Bottomley wrot

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

ng all pending requests is one option. As we don't start timer for each request, there is no need to stop any timer when the request is done. Thanks, Malahal. James Bottomley [EMAIL PROTECTED] wrote: > On Tue, 2007-10-09 at 14:15 +0200, Jens Axboe wrote: > > On Tue, Oct 09 2007, Matt

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

Here is another attempt! Thank you. diff -r 1b51503899a0 block/ll_rw_blk.c --- a/block/ll_rw_blk.c Thu Sep 27 00:25:15 2007 -0700 +++ b/block/ll_rw_blk.c Tue Oct 09 07:00:51 2007 -0700 @@ -181,6 +181,18 @@ void blk_queue_softirq_done(struct reque EXPORT_SYMBOL(blk_queue_softirq_done); +void

Re: [RFC] [PATCH 1/1] blk request timeout handler patches

Thank you Randy, Jens for your suggestions. I folded the second patch as it is just a clean up. Here is the fixed one patch version. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> Thanks, Malahal. diff -r 2cd6b249e335 block/ll_rw

Re: [RFC] [PATCH 1/2] blk request timeout handler patches

Jens Axboe [EMAIL PROTECTED] wrote: > On Thu, Oct 04 2007, [EMAIL PROTECTED] wrote: > > Mike Christie's patches refreshed to 2.6.23-rc8-mm1. > > > > Signed-off-by: Mike Christie <[EMAIL PROTECTED]> > > Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]&

[RFC] [PATCH 2/2] blk request timeout handler patches

Fix scsi_dispatch_cmd() to stop timers. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r 870bb598c977 drivers/scsi/scsi.c --- a/drivers/scsi/scsi.c Thu Sep 27 00:25:38 2007 -0700 +++ b/drivers/scsi/scsi.c Thu Sep 27 01:04:10 2007 -0700 @@ -471,14 +471,19

[RFC] [PATCH 1/2] blk request timeout handler patches

Mike Christie's patches refreshed to 2.6.23-rc8-mm1. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r 3697367c6e4d block/ll_rw_blk.c --- a/block/ll_rw_blk.c Thu Sep 27 00:12:13 2007 -0700 +++ b/block/ll_rw_blk.c Thu Sep

[RFC] [PATCH 0/2] blk request timeout handler patches

I refreshed the blk layer timeout patch from Mike Christie to 2.6.23-rc8-mm1. Fixed couple of places where scsi_dispatch_cmd() wasn't stopping timers. Thanks, Malahal. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL

Re: [PATCH] qla2xxx: fix RSCN handling on big-endian systems

Seokmann Ju [EMAIL PROTECTED] wrote: > On Wednesday, February 21, 2007 6:54 PM, Malahal Naineni wrote: > > I have JBOD in FL-port and if I unplug the cable or disable > > the switch port, the qla2xxx driver doesn't fail the I/O > > soon. The remote port status is

Re: [PATCH] qla2xxx: fix RSCN handling on big-endian systems

owest addressed byte, so the b24 field's interpretation as an integer is *incorrect* on big endinan systems. You should be able to print the b24 as an integer and see what you get is incorrect on big endian systems. Thanks, Malahal. Seokmann Ju [EMAIL PROTECTED] wrote: > On Monday, Februar

[PATCH] qla2xxx: fix RSCN handling on big-endian systems

qla2xxx driver fails to handle RSCN events affecting area or domain due to an endian issue on big endian systems. This fixes the port_id_t structure on big endian systems. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff -r c860739bb0f4 drivers/scsi/qla2xxx/qla_def.h --- a/driver

Re: Linux not adhering to BIOS Drive boot order?

ng can go on in the > right order. Name slippage is a horrible thing. That should be fixed first. The O/S should get the device names right for every boot. Thanks, Malahal. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED]