On Thu, 2018-11-15 at 18:20 +0800, John Garry wrote:
> This patchset presents some logging tidy-up, namely removing the printk
> wrappers and using pr_XXX() instead.
>
> In addition, some log levels are revised, as previous levels (generally
> debug) were too low.
Seems sensible, thanks.
On Wed, 2018-11-14 at 15:12 +, John Garry wrote:
> On 14/11/2018 14:53, Joe Perches wrote:
> > On Wed, 2018-11-14 at 21:47 +0800, John Garry wrote:
> > > Like sas_printk() did previously, SAS_DPRINTK() offers little value now
> > > that libsas logs already have the
On Wed, 2018-11-14 at 21:47 +0800, John Garry wrote:
> Like sas_printk() did previously, SAS_DPRINTK() offers little value now
> that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it
> can be dropped.
>
> However, after reviewing some logs in libsas, it is noticed that debug
>
On Tue, 2018-11-13 at 13:38 +, John Garry wrote:
> On 12/11/2018 19:52, Joe Perches wrote:
> > On Mon, 2018-11-12 at 19:31 +, John Garry wrote:
> > > On 12/11/2018 18:58, Joe Perches wrote:
> > > > > > +#define pr_fmt(fmt) "sas: " fmt
[]
On Mon, 2018-11-12 at 19:31 +, John Garry wrote:
> On 12/11/2018 18:58, Joe Perches wrote:
> > > > +#define pr_fmt(fmt) "sas: " fmt
> > > >
> > > > Some other subsystem may try to include this header, and gets its
> > > > message p
On Mon, 2018-11-12 at 18:48 +, John Garry wrote:
> On 12/11/2018 18:30, Joe Perches wrote:
[]
> > diff --git a/drivers/scsi/libsas/sas_internal.h
> > b/drivers/scsi/libsas/sas_internal.h
[]
> > @@ -32,7 +32,10 @@
> > #include
> > #include
> >
&
On Mon, 2018-11-12 at 17:55 +, John Garry wrote:
> On 12/11/2018 17:49, John Garry wrote:
> > On 12/11/2018 17:32, Joe Perches wrote:
> > > On Tue, 2018-11-13 at 01:28 +0800, John Garry wrote:
> > > > Not all host drivers are PCI drivers - like hisi_sas, whi
On Tue, 2018-11-13 at 01:28 +0800, John Garry wrote:
> Not all host drivers are PCI drivers - like hisi_sas, which supports a
> platform driver - so remove reference to "pcidev".
>
> The debug level is also downgraded to KERN_ERR for the same message.
[]
> diff --git a/drivers/scsi/libsas/sas_disc
On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote:
> From: Colin Ian King
>
> In the expression "ahc_inb(ahc, port+3) << 24", the initial value is a
> u8, but is promoted to a signed int, then sign-extended to uint64_t. If
> the value read from the port has the upper bit set then the sign
> ex
On Thu, 2018-10-11 at 19:25 -0400, Martin K. Petersen wrote:
> Joe,
>
> > > Applied to 4.20/scsi-queue, thanks!
> >
> > Is this branch also applied to Stephen Rothwell's -next?
>
> Yes.
Via what tree? It doesn't seem directly pulled.
On Wed, 2018-10-10 at 21:54 -0400, Martin K. Petersen wrote:
> Joe,
>
> > Several defects exist in the logging uses
> >
> > o Missing KERN_
> > o Unnecessary KERN_ uses with panic
> > o Mismatched MPT3SAS_FMT and %s: with name and __func__
> >
>
On Mon, 2018-09-17 at 08:01 -0700, Joe Perches wrote:
> Several defects exist in the logging uses
>
> o Missing KERN_
> o Unnecessary KERN_ uses with panic
> o Mismatched MPT3SAS_FMT and %s: with name and __func__
>
> Correct these defects and perhaps add some clarity to th
On Mon, 2018-10-01 at 00:03 +0100, Colin King wrote:
> From: Colin Ian King
>
> There are extraneous parantheses that are causing clang to produce a
> warning so remove these.
>
> Clean up 3 clang warnings:
> equality comparison with extraneous parentheses [-Wparentheses-equality]
[]
> diff --gi
Please fix this defect appropriately.
linux-next MAINTAINERS section:
3964CXLFLASH (IBM Coherent Accelerator Processor Interface CAPI
Flash) SCSI DRIVER
3965M: Manoj N. Kumar
3966M: Matthew R. Ochs
3967M: Uma Krishnan
3968
All the uses have been removed, delete the macro.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
index 941a4faf20be..8f1d6b071b39 100644
--- a
Convert these uses to ioc_ where appropriate.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 41 +++-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 12 +-
drivers/scsi/mpt3sas/mpt3sas_transport.c | 6 ++---
3 files changed, 28
These have misordered uses of __func__ and ioc->name that could
mismatch MPT3SAS_FMT and "%s: ".
Convert them to ioc_.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 50 +++-
drivers/scsi/mpt3sas/mpt3sas_transport.c | 18 ++
These macros can help identify specific logging uses and eventually
perhaps reduce object sizes.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas
Several defects exist in the logging uses
o Missing KERN_
o Unnecessary KERN_ uses with panic
o Mismatched MPT3SAS_FMT and %s: with name and __func__
Correct these defects and perhaps add some clarity to the logging.
Joe Perches (7):
mpt3sas: Add ioc_ logging macros
mpt3sas: Convert uses of
Convert the existing 2 uses to make the format and arguments
matching more obvious.
Miscellanea:
o Move the word "enabled" into the format to trivially reduce object size
o Remove unnecessary parentheses
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 10 +++
Remove the logging level as panic calls stop the machine and should
always be emitted regardless of requested logging level.
These existing panic uses are perhaps inappropriate.
Miscellanea:
o Coalesce formats and convert MPT3SAS_FMT to "%s: " to improve clarity
Signed-off-by: J
On Fri, 2018-09-07 at 11:39 +0100, Colin King wrote:
> From: Colin Ian King
>
> It is possible to heavily spam the kernel logs with messages by
> excessive reading of the mpt3sas sysfs files. Make the error messages
> ratelimited to reduce the spamming effect.
[]
> diff --git a/drivers/scsi/mpt3
Some functions definitions have either the initial open brace and/or
the closing brace outside of column 1.
Move those braces to column 1.
This allows various function analyzers like gnu complexity to work
properly for these modified functions.
Signed-off-by: Joe Perches
Acked-by: Andy
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :)
> >
> > So here's an opportunity for you:
> >
> > The sysfs maintainer hasn't added include/linux/sysfs.h to
> > the list of maintained files...
> >
> > D
On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > &g
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
[]
> > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
[]
> > @@ -854,7 +85
On Tue, 2017-12-19 at 19:44 +0100, Borislav Petkov wrote:
> On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote:
> > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible.
> >
> > Done with perl script:
> >
> > $ git grep -w --name-only DEVICE_ATTR
Joe Perches (4):
sysfs.h: Use octal permissions
treewide: Use DEVICE_ATTR_RW
treewide: Use DEVICE_ATTR_RO
treewide: Use DEVICE_ATTR_WO
arch/arm/mach-pxa/sharpsl_pm.c | 4 +-
arch/s390/kernel/smp.c | 2 +-
arch/s390/kernel/topology.c
TR_WO(\1)/g;
print;}'
Signed-off-by: Joe Perches
---
arch/s390/kernel/smp.c | 2 +-
arch/x86/kernel/cpu/microcode/core.c | 2 +-
drivers/input/touchscreen/elants_i2c.c | 2 +-
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
drivers/net/wimax/i2400m/sysfs.c | 3 +--
d
_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g;
print;}'
Signed-off-by: Joe Perches
---
arch/s390/kernel/topology.c | 3 +--
arch/tile/kernel/sysfs.c | 2 +-
drivers/gpu/drm/i915/i915_sysfs.c| 6 ++---
drivers/platform/x86/compal-laptop.c | 18 +--
)/g;
print;}'
Signed-off-by: Joe Perches
---
arch/arm/mach-pxa/sharpsl_pm.c | 4 ++--
arch/sh/drivers/push-switch.c| 2 +-
arch/tile/kernel/sysfs.c | 10 +-
drivers/acpi/device_sysfs.c
line from xfs_agf_verify
Signed-off-by: Joe Perches
---
git diff -w shows no difference other than the above 'Miscellanea'
(this is against -next, but it applies against Linus' tree
with a couple offsets)
arch/x86/include/asm/atomic64_32.h | 2 +
On Wed, 2017-09-13 at 13:02 +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais
I think the changelog for this series of conversions
should show that you've validated the change by
inspecting the return call chain at each modified line.
Also, it seems you've cc'd the same mailing lists for
all
good catch, thanks; I'll propagate this to our various OOB drivers.
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Wednesday, August 30, 2017 6:31 AM
To: Dept-Eng QLA2xxx Upstream ; shqking
; Carnuccio, Joe
Cc: James E.J. Bottomley ; Martin K. Pet
On Wed, 2017-08-30 at 00:19 +0530, Himanshu Jha wrote:
> drivers/scsi/megaraid/megaraid_sas_fusion.c
I don't know if you did this with coccinelle.
If so, it would be good to show the tool and script
in the commit message.
If not, the input script is pretty simple.
$ cat memset_before_memcpy.coc
On 08/14/2017 02:30 PM, Tejun Heo wrote:
> Hello, Joe.
>
> On Thu, Aug 10, 2017 at 10:45:54AM -0400, Joe Lawrence wrote:
>> In the case of my USB DVD -> laptop example, there is no media in my
>> device, however I still see the DISK_EVENT_MEDIA_CHANGE event. This is
>&
; present in the virtual device... is it reasonable to expect a
DISK_EVENT_MEDIA_CHANGE even for a new device that contains media? (I
haven't verified, but in this case GET_EVENT_STATUS_NOTIFICATION might
be enough to set media present.)
If there is documentation that explains DISK_EVENT_MEDIA_CHANGE conditions
somewhere, feel free to point me there.
Thanks,
-- Joe
On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote:
> On Sat, May 20, 2017 at 12:28 PM, Joe Perches wrote:
> > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> > > The lpfc_nvmeio_data() tracing helper always takes a format string and
> > > three additiona
On Sat, 2017-05-20 at 13:16 +0200, Nicolas Iooss wrote:
> nsp32_message() and nsp32_dmessage() use printf format strings in order
> to format a message. Adding __printf attributes helps to detect errors
> in such format strings at build time, like:
>
> drivers/scsi/nsp32.c:3314:23: error: form
On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> The lpfc_nvmeio_data() tracing helper always takes a format string and
> three additional arguments.
No it doesn't. It takes a format and arguments.
I don't disagree with the patch, just the characterization
of the lpfc_mvmeio_data call i
__printf makes the compiler check format and arguments.
Fix fallout.
Miscellanea:
o Convert formats to const char *
o Use vsprintf extension %pV instead of a static buffer.
o Add newline to logging and remove now unnecessary printk("\n")
o Use pr_cont where appropriate
Signed-o
On Wed, 2017-04-26 at 20:50 +0200, SF Markus Elfring wrote:
> > Basically most everything that has a gfp_t argument does a
> > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.
>
> How do you think about to improve any programming interface documentation
> around such a function
On Wed, 2017-04-26 at 10:57 -0700, Subhash Jadavani wrote:
> PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation
> (via dmam_alloc_coherent() APIs) and tries to print out the message on
> allocation failure. Although i don't know "out of memory" messages will
> be printed out
return 0;
+ if (rport) {
+ struct fc_rport_libfc_priv *rp = rport->dd_data;
+
+ if (!rp || rp->rp_state != RPORT_ST_READY) {
+ FNIC_SCSI_DBG(KERN_DEBUG, fnic->lport->host,
+ "returning DID_NO_CONNECT for IO as rport is
removed\n");
Thanks,
Joe
On Mon, 2017-03-06 at 10:17 -0800, Joe Perches wrote:
> On Tue, 2017-03-07 at 02:03 +0800, kbuild test robot wrote:
> > Hi Joe,
>
> Hi again Fengguang's robot.
Rehi. OK, it is a new message. Patch sent.
Using %llx for a dma_addr_t can lead to format/argument mismatches.
Use %pad and the address of the dma_addr_t instead.
Signed-off-by: Joe Perches
---
drivers/scsi/qedf/qedf_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers
On Tue, 2017-03-07 at 02:03 +0800, kbuild test robot wrote:
> Hi Joe,
Hi again Fengguang's robot.
> [auto build test WARNING on scsi/for-next]
> [also build test WARNING on v4.11-rc1 next-20170306]
> [if your patch is applied to the wrong git tree, please drop us a note to
&
Add __printf compiler verification of format and arguments.
Fix fallout.
Signed-off-by: Joe Perches
---
drivers/scsi/qedf/qedf_dbg.h | 13 -
drivers/scsi/qedf/qedf_fip.c | 2 +-
drivers/scsi/qedf/qedf_io.c | 4 ++--
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a
/qla2xxx/qla_dbg.o.new
39164 0 0 3916498fc drivers/scsi/qla2xxx/qla_dbg.o.old
Signed-off-by: Joe Perches
---
drivers/scsi/qla2xxx/qla_dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx
On Wed, 2017-03-01 at 16:55 +0100, Romain Perier wrote:
> support to warn about this old API in checkpath.pl
checkpatch
This part isn't true anymore, but it seems sensible enough, thanks.
On Mon, 2017-02-27 at 13:52 +0100, Romain Perier wrote:
> > I also wonder if you've in fact converted all of the
> > pci_pool struct and function uses why a new checkpatch
> > test is needed at all.
>
> That's just to avoid futures mistakes/uses.
When all instances and macro definitions are remo
s
> > > in the DMA pool API. This adds support to check for use of these pci
> > > functions and display a warning when it is the case.
> > >
> >
> > I guess Joe Perches did sent some comments for this one, did you address
> > them?
>
> See the
t; > functions and display a warning when it is the case.
> >
>
> I guess Joe Perches did sent some comments for this one, did you address
> them?
> Reviewed-by: Peter Senna Tschudin
> > Signed-off-by: Romain Perier
> > ---
> > scripts/checkpatch.pl | 9 +
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote:
> On 23 February 2017 at 17:18, Joe Perches wrote:
> > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote:
> > > > There are ~4300 uses of pr_w
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote:
> > There are ~4300 uses of pr_warn and ~250 uses of the older
> > pr_warning in the kernel source tree.
> >
> > Make the use of pr_warn consistent across all
with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
Miscellanea:
o Coalesce formats and realign arguments
Some files not compiled - no cross-compilers
Joe Perches (35):
alpha: Convert remaining uses of pr_warning to pr_warn
ARM: ep93xx: Convert remaining uses of pr_warning
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/scsi
Prior to this patch, there was 1 use of pr_warning and
96 uses of pr_warn in drivers/scsi
Signed-off-by: Joe Perches
---
drivers/scsi/a3000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote:
> On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
> > pci_pool_*() functions should be replaced by the corresponding functions
> > in the DMA pool API. This adds support to check for use of these pci
> > functions and dis
On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote:
> This patch makes use of is_vlan_dev() function instead of flag
> comparison which is exactly done by is_vlan_dev() helper function.
Thanks.
btw: after applying this patch, there is one left
$ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" -- "*.c
On Fri, 2017-01-20 at 09:55 -0800, Joe Perches wrote:
> I believe MPT3SAS_FMT is unnecessary obfuscation and
> it should just be replaced by "%s: " everywhere.
Here's a trivial command that could be used one day:
$ git grep --name-only MPT3SAS_FMT -- "*.c" |
On Fri, 2017-01-20 at 20:12 +0530, Chaitra P B wrote:
> Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED
> when a cable is present and is running at a degraded speed
> (below the SAS3 12 Gb/s rate). Prints added
> to inform the user that the cable is not running at
> optimal speed.
[]
>
On Mon, 2016-12-12 at 16:56 -0800, Subhash Jadavani wrote:
> Errors such as UIC error, illegal OCS values, and others may require
> more information for debugging. Such information could be hibern8 events,
> events sequences, recoverable errors, error history, and more.
[]
> diff --git a/drivers/sc
On Fri, 2016-12-09 at 22:45 +0200, Michael S. Tsirkin wrote:
> This adds endian-ness labels for lots of qla structs.
> Doing this cuts down number of sparse warnings from ~1700 to ~1400.
> Will help find and resolve some of real issues down the road.
>
> Signed-off-by: Michael S. Tsirkin
>
> ---
On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote:
> From: Shikhar Dogra
>
> Reduce chatter on console for usb hotplug.
> KERN_ERR is too high severity for these messages, moving them
> to KERN_WARNING
Perhaps KERN_NOTICE is more appropriate.
That's the level for most of these sd_first_pr
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> Constify local structures.
Thanks Julia.
A few suggestions & questions:
Perhaps the script should go into scripts/coccinelle/
so that future cases could be caught by the robot
and commit message referenced by the patch instances.
Can you
From:Mr Joe Ike
Block 10 Flat 5
Victoria Island
Lagos-Nigeria
This is to inform you that your funds of US$15 Million has been
approved for immediate delivery to you. For the purpose of
clarification,you are advised to reconfirm your Full Names,Direct
Telephone Numbers,Physical Address with Zip
Convert it to the preferred const struct pci_device_id instead.
Signed-off-by: Joe Perches
---
drivers/scsi/wd719x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index e3da1a2..2a9da2e 100644
--- a/drivers/scsi/wd719x.c
+++ b
Joe Perches (2):
wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE
treewide: Remove references to the now unnecessary DEFINE_PCI_DEVICE_TABLE
Documentation/PCI/pci.txt | 1 -
drivers/scsi/wd719x.c | 2 +-
include/linux/pci.h | 9 -
scripts/checkpatch.pl | 9
On Wed, 2016-08-17 at 09:20 +0530, Jitendra Bhivare wrote:
> >
> > -Original Message-
> > From: Joe Perches [mailto:j...@perches.com]
> > Sent: Tuesday, August 16, 2016 3:57 PM
> > To: Jitendra Bhivare; Christophe JAILLET; Jayamohan Kallickal; Ketan
> Muk
On Wed, 2016-08-17 at 01:19 +, Bart Van Assche wrote:
> On 08/14/16 10:29, Joe Perches wrote:
> > On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote:
> > > My primary concern is how to enable and disable log messages from user
> > > space.
[]
> > I think
On Tue, 2016-08-16 at 11:32 +0530, Jitendra Bhivare wrote:
> Thanks Joe for taking this up. It has been pending for long time from our
> side.
Thanks, not a problem, it took ~10 minutes.
There was a bit of an issue about your reply though.
First there was ~50 k of quoted stuff witho
kbasename(__FILE__)
and stringify(__LINE__) to reduce code size in beiscsi_printk
o Realign arguments
Signed-off-by: Joe Perches
---
drivers/scsi/be2iscsi/be_cmds.c | 142
drivers/scsi/be2iscsi/be_iscsi.c | 223 ++--
drivers/scsi/be2iscsi/be_main.c | 733
On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote:
> My primary concern is how to enable and disable log messages from user
> space. Many drivers define their own logging macros and export a bitmask
> that allows to enable and disable logging messages per category. These
> bitmask contro
On Sun, 2016-08-14 at 14:34 +, Bart Van Assche wrote:
> On 08/13/16 13:42, Joe Perches wrote:
> > Joe Perches (2):
> > be2iscsi: Coalesce split strings and formats
> > be2iscsi: Use a standard logging style
> Hello Joe,
Hello Bart.
> As one can see in be_mai
Neaten all the beiscsi_log uses.
Remove the leading 'B_%d" prefixes and make the
format and arguments match without an implied __LINE__.
Signed-off-by: Joe Perches
---
drivers/scsi/be2iscsi/be_cmds.c | 54 +++
drivers/scsi/be2iscsi/be_iscsi.c | 100 ++--
drivers/scs
Split strings are not preferred for ease of grep.
Signed-off-by: Joe Perches
---
drivers/scsi/be2iscsi/be_cmds.c | 15 ++--
drivers/scsi/be2iscsi/be_iscsi.c | 33 +++
drivers/scsi/be2iscsi/be_main.c | 180 ++-
drivers/scsi/be2iscsi/be_mgmt.c | 3
Joe Perches (2):
be2iscsi: Coalesce split strings and formats
be2iscsi: Use a standard logging style
drivers/scsi/be2iscsi/be_cmds.c | 61 +++---
drivers/scsi/be2iscsi/be_iscsi.c | 115 ++-
drivers/scsi/be2iscsi/be_main.c | 398 +--
drivers/scsi
On Sat, 2016-08-13 at 09:41 -0700, Joe Perches wrote:
> On Sat, 2016-08-13 at 14:31 +0200, Christophe JAILLET wrote:
> > Le 13/08/2016 à 13:35, Joe Perches a écrit :
> > > > @@ -268,7 +268,7 @@ static int beiscsi_eh_abort
On Sat, 2016-08-13 at 14:31 +0200, Christophe JAILLET wrote:
> Le 13/08/2016 à 13:35, Joe Perches a écrit :
> > > @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_cmnd *sc)
> > > &nonemb_cmd.dma);
> > >
On Sat, 2016-08-13 at 09:20 +0200, Christophe JAILLET wrote:
> This fixes:
[]
> - concatenate strings on the same line to fix checkpatch warnings
[]
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
[]
> @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_c
On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote:
> On 5 July 2016 at 15:14, Joe Perches wrote:
> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> > > This series introduces a family of generic string case conversion
> > > functions. This kind of functio
On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> This series introduces a family of generic string case conversion
> functions. This kind of functionality is needed in several places in
> the kernel. Right now, everybody seems to be implementing their own
> copy of this functionality.
>
>
On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote:
> Enabling format checking in dprintk() shows that wd7000_biosparam
> uses an incorrect format string for sector_t:
trivia:
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
[]
> @@ -192,7 +192,7 @@
> #ifdef WD7000_DEBUG
> #defi
On Fri, 2016-06-17 at 17:44 +, Jim Gill wrote:
> On 6/16/16, 8:11 PM, "Julian Calaby" wrote:
>
>
>
> >
> > []
> >
> > >
> > > >
> > > > On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches wrote:
> > &g
On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
> Hi Joe,
rehi Julian.
> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches wrote:
[]
> > get_maintainer.pl also has a rarely used "--file-emails" option to
> > scan for what appears to be email addresses in specific
On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c
just fyi: the script name is not plural
$ ./scripts/get_maintainer.pl -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar (maintainer:VMware PVSCSI driver)
VMware PV-Drivers (maintainer:V
On Thu, 2016-06-16 at 16:20 -0500, Bryant G. Ly wrote:
> This driver is a pick up of the old IBM VIO scsi Target Driver
> that was started by Nick and Fujita 2-4 years ago.
> http://comments.gmane.org/gmane.linux.scsi/90119
(style trivia only, nothing important enough to force a respin
but nice t
On Wed, 2016-06-15 at 18:41 -0500, Bryant G. Ly wrote:
> The driver provides a virtual SCSI device on IBM Power Servers.
[]
> MAINTAINERS | 11 +
> drivers/scsi/Kconfig | 27 +-
> drivers/scsi/Makefile|2 +-
> drivers/scs
dOn Thu, 2016-05-26 at 17:08 -0700, Long Li wrote:
> The block sector size should be in unit of 512 bytes, not in bytes.
Thanks. The patch subject should use something like:
[PATCH] sd: Use the correct size to set block max sectors
to show what subsystem is being modified.
> diff --git a/drive
If _scsih_sas_host_add's call to mpt3sas_config_get_sas_iounit_pg0
fails, ioc->sas_hba.parent_dev may be left uninitialized. A later
device probe could invoke mpt3sas_transport_port_add which will call
sas_port_alloc_num [scsi_transport_sas] with a NULL parent_dev pointer.
Signed-off
>sas_hba is left in a dangerous state: all readers
of ioc->sas_hba.phy[] do so by indexing it from 0..ioc->sas_hba.num_phys
without checking that the space was ever allocated.
Modify _scsih_sas_host_add to set ioc->sas_hba.num_phys only after
successfully allocating ioc->sas_hba.
Note: these changes don't improve or retry adapter initialization, but
only try to prevent the system from crashing
Joe Lawrence (2):
mpt3sas - set num_phys after allocating phy[] space
mpt3sas - avoid mpt3sas_transport_port_add NULL parent_dev
drivers/scsi/mpt3sas/mpt3sas_scsi
On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly
Please use your whole name here and for your sign-off like:
From: Bryant G. Ly
Signed-off-by: Bryant G. Ly
> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixe
On Tue, 2016-05-24 at 08:52 -0500, Bryant G. Ly wrote:
> From: bgly
>
> This initial commit contains WIP of the IBM VSCSI Target Fabric
> Module. It currently supports read/writes, and I have tested
> the ability to create a file backstore with the driver and install
> RHEL VIA NIM and then boot
On 05/05/2016 04:40 PM, Joe Lawrence wrote:
> On 05/05/2016 03:58 PM, Bart Van Assche wrote:
>> On 03/28/2016 02:29 PM, Bart Van Assche wrote:
>>> Avoid that the sd driver registers a BDI device with a name that
>>> is still in use. This patch avoids that the following
able.
sd 1:0:0:2: [sds] Write Protect is off
sd 1:0:0:2: [sds] Mode Sense: 00 00 00 60
sd 1:0:0:2: [sds] Asking for cache data failed
sd 1:0:0:2: [sds] Assuming drive cache: write through
Regards,
-- Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote:
> From: Colin Ian King
>
> Add a missing space in dev_err message, missed because the string
> spans a few lines.
This is a dev_notice() not dev_err().
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megara
es: 146b16c8071f (mpt3sas: Refcount fw_events and fix unsafe list usage)
Signed-off-by: Joe Lawrence
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
inde
t3 version? If that is
interesting, that info could be added to v2 commit message as well.
Thanks,
-- Joe
On 04/11/2016 07:13 AM, Chaitra Basappa wrote:
Hi,
Please consider this patch as Ack-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: Sathya Prakash [mailto:s
On 04/01/2016 02:51 PM, Ewan D. Milne wrote:
> On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote:
>> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER
>> *ioc)
>> /*
>> * Wait on the fw_event to comple
1 - 100 of 448 matches
Mail list logo
