We are dereferencing ioc->sense_dma_pool in pci_pool_free() and after
that we are checking if it is NULL, before calling pci_pool_destroy().
Lets check if it is NULL before calling both pci_pool_free() and
pci_pool_destroy().
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/mpt3
FIG_PM is
defined as mentioned in the mvumi_pci_driver.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/mvumi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 02360de..d9d0736 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.
The variable is_ver1 is always true and so OSD_CAP_LEN can never be
used.
Reported by Coverity.
Signed-off-by: Sudip Mukherjee
---
v2: Joe Perches asked to mention the tool used in the commit log.
drivers/scsi/osd/osd_initiator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
parport_claim() can fail and we should be checking if we were able to
claim the port.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/imm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index f8b88fa..9164ce12 100644
--- a
The variable is_ver1 is always true and so OSD_CAP_LEN can never be
used.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/osd/osd_initiator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index d8a2b51
We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not used
dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not
defined then dptids[] becomes unused.
Reviewed-by: Johannes Thumshirn
Signed-off-by: Sudip Mukherjee
---
On Wednesday 17 February 2016 07:57 PM, One Thousand Gnomes wrote:
On Wed, 17 Feb 2016 17:50:14 +0530
Sudip Mukherjee wrote:
This is a pci device but was not done in the usual way a pci driver is
done. Convert the driver into a proper pci driver.
This looks completely wrong. Please read the
This is a pci device but was not done in the usual way a pci driver is
done. Convert the driver into a proper pci driver.
Signed-off-by: Sudip Mukherjee
---
v1: only build warning related to "dptids defined but not used" was
fixed using #ifdef
drivers/scsi/dpt_i
On Tuesday 16 February 2016 02:47 PM, Johannes Thumshirn wrote:
On Tue, Feb 16, 2016 at 02:07:36PM +0530, Sudip Mukherjee wrote:
We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: ‘dptids’ defined but not used
dptids[] is only used in the MODULE_DEVICE_TABLE so when
We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: ‘dptids’ defined but not used
dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not
defined then dptids[] becomes unused.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/dpt_i2o.c | 3 +++
1 file
Modify ppa driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
Resending as there was no review or ACK for this change.
This has exactly same changes as done in scsi/imm.c which has already
been accepted.
drivers/scsi/ppa.c | 46
was being referenced from
sim710_eisa_driver.
Signed-off-by: Sudip Mukherjee
---
patch first sent on 4th Sept.2015. There is no review or ACK yet.
warning is still there with next-20160209,
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/107948115
drivers/scsi/sim710.c | 3 +
Modify imm driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
Resending as the first mail bounced back with the error:
Delivery to the following recipient failed permanently:
jbottom...@odin.com
Looking at the MAINTAINERS file gives me multiple email
Modify imm driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
I usually submit checkpatch cleanup and other modifications while
converting a driver to use parport device model. For this driver i
hesitated. If you want I can send a series with this modification
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151211 and build log is at:
https://travis-ci.org
On Tue, Sep 15, 2015 at 01:30:00PM +0530, Sudip Mukherjee wrote:
> On Fri, Sep 04, 2015 at 07:40:29PM +0530, Sudip Mukherjee wrote:
> > We were getting build warning about:
> > "Section mismatch in reference from the variable sim710_eisa_driver to
> > the function .i
On Wed, Sep 23, 2015 at 07:02:32PM +0530, Sudip Mukherjee wrote:
> kmalloc() can return NULL and without checking we were dereferencing it.
> Moreover if kmalloc succeeds but the function fails in other parts then
> we were returning the error code but we missed freeing lcb_context.
>
On Wed, Sep 16, 2015 at 08:47:43AM -0600, Khalid Aziz wrote:
> On 09/16/2015 08:06 AM, Sudip Mukherjee wrote:
> >We have been getting a warning about non ANSI function.
> >warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
> >
&g
kmalloc() can return NULL and without checking we were dereferencing it.
Moreover if kmalloc succeeds but the function fails in other parts then
we were returning the error code but we missed freeing lcb_context.
While at it fixed one related checkpatch warning.
Signed-off-by: Sudip Mukherjee
We have been getting a warning about non ANSI function.
warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/FlashPoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Flas
On Fri, Sep 04, 2015 at 07:40:29PM +0530, Sudip Mukherjee wrote:
> We were getting build warning about:
> "Section mismatch in reference from the variable sim710_eisa_driver to
> the function .init.text:sim710_eisa_probe()
> The variable sim710_eisa_driver references th
was being referenced from
sim710_eisa_driver.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/sim710.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c
index 3b3b56f..82ed998 100644
--- a/drivers/scsi/sim710.c
+++ b/drivers/scs
On Wed, Apr 08, 2015 at 04:32:57PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 4/8/2015 2:20 PM, Sudip Mukherjee wrote:
>
> >now that we are monitoring the return value from attach, make the
>
>So you've first changed the method prototype and follow up wit
On Wed, Apr 08, 2015 at 02:44:37PM +0300, Dan Carpenter wrote:
> On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
>
> Then we convert one driver to use the new function pointer and see if
> it simplifies the code. If so we can transition the others as well. If
> not then we give up
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
> 1) We can't apply this patch on its own so this way of breaking up the
> patches doesn't work.
yes, if the first patch is reverted for any reason all the others need
to be reverted also. so then everything in one single patch?
>
> 2)
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
sound/drivers/mts64.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/sound/drivers/mts64.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-butterfly.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/ppa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ppa.c b/drivers/scsi
only mark attach as failed only if it has never
returned a 0.
Signed-off-by: Sudip Mukherjee
---
drivers/parport/share.c | 20 +++-
include/linux/parport.h | 2 +-
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/pps/clients/pps_parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pps/clients
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/i2c/busses/i2c-parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/char/ppdev.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/char/ppdev.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
also return the proper error code in module_init.
Signed-off-by: Sudip Mukherjee
---
drivers/net/plip/plip.c | 16 ++--
1 file changed, 10 insertions
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/imm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/imm.c b/drivers/scsi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/char/lp.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/char/lp.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/pps/generators/pps_gen_parport.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/panel.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
sound/drivers/portman2x4.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/sound/drivers
code from parport_register_driver.
Sudip Mukherjee (14):
parport: return value of attach and parport_register_driver
ALSA: portman2x4: return proper error values from attach
ALSA: mts64: return proper error values from attach
staging: panel: return proper error values from attach
spi
we were dereferencing sdkp first and then we were checking for it
being NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/sd_dif.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c
index 14c7d42..a514645 100644
On Thu, Oct 30, 2014 at 06:28:13AM +, Elliott, Robert (Server Storage)
wrote:
>
>
> > -Original Message-
> > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> > ow...@vger.kernel.org] On Behalf Of Sudip Mukherjee
> > Sent: Thursday, Oc
On Wed, Oct 29, 2014 at 04:15:04PM +0100, Fabian Frederick wrote:
> Fix -Wunused-but-set-variable warning
you should also mention why you have left the call to irq_set_affinity_hint().
i am not sure , but it looks like irq_set_affinity_hint() is only checking if
the lock is available or not. It is
On Tue, Sep 09, 2014 at 12:53:50PM +0530, Sudip Mukherjee wrote:
> build is giving :
> warning: passing argument 1 of 'strlen' makes pointer from integer
> without a cast [enabled by default]
>
> the snprintf after the strlen is trying to put the "Unsupported&q
build is giving :
warning: passing argument 1 of 'strlen' makes pointer from integer
without a cast [enabled by default]
the snprintf after the strlen is trying to put the "Unsupported" string
at the end of exising string. so len should give the string length here
45 matches
Mail list logo
