[PATCH] block/null_blk: Fix completion processing from LIFO to FIFO

2014-02-06 Thread Shlomo Pongratz
processing is done in reverse order w.r.t order of the insertion i.e. LIFO processing. By reversing the disconnected list which is done in linear time the desired FIFO processing is achieved. Signed-off-by: Shlomo Pongratz --- drivers/block/null_blk.c |2 ++ 1 files changed, 2 insertions(+), 0

[PATCH] [SCSI] be2iscsi: fix reentrancy issue in be_iopoll

2013-03-20 Thread Shlomo Pongratz
ge "ret". return ret; Fix - remove the "static" Signed-off-by: Shlomo Pongratz --- drivers/scsi/be2iscsi/be_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 4e

Possible reentrancy issue in be_iopoll

2013-03-18 Thread Shlomo Pongratz
Hi Jayamohan. I think that there is a reentrancy issue in "drivers/scsi/be2iscsi/be_main.c::be_iopoll". The driver creates "NAPI" context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable, so if this routine i

spin_lock in scsi_request_fn

2012-10-28 Thread Shlomo Pongratz
Hi, I've noticed a strange usage of spin lock in scsi_request_fn located in drivers/scsi/scsi_lib.c That is in line 1565 we have spin_lock(shost->host_lock); but in line 1595 we have spin_unlock_irq(shost->host_lock); Is this by design or it is a typo? Best regards, Shlomo Pong