Hi Jayamohan.

I think that there is a reentrancy issue in "drivers/scsi/be2iscsi/be_main.c::be_iopoll". The driver creates "NAPI" context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable, so if this routine is called from more than one thread of execution the result is unpredictable.

        static unsigned int ret;
        .....

        ret = beiscsi_process_cq(pbe_eq);
<----------------------------------------------------------------------------------Another thread can enter here and change "ret".
        if (ret < budget) {
               ....
        }
<----------------------------------------------------------------------------------Another thread can enter here and change "ret".
        return ret;

I can't submit a patch without checking it first, which is impossible since I don't have the HW, but the fix seems trivial, just take out the static.

Best regards,

S.P.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to