[PATCH] Transition maintainership to Vasu.

Acked-by: Vasu Dev Signed-off-by: Robert Love --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8ccf31c..c9afcf3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3539,7 +3539,7 @@ F:Documentation/fault-injection/ F

Open-FCoE Maintainer Transition

Hello community, It is with mixed feelings that I send this mail to state that I am transitioning maintainership of Open-FCoE. I'm still working on Linux solutions, but now I'm focusing on SDN/NfV technologies. I'll still be around and I'll continue to help where I can. Vasu Dev will t

fcoe request pull 3.13

ing them fcoe: cleanup return codes from fcoe_rcv fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path Robert Love (1): libfcoe: Make fcoe_sysfs optional / fix fnic NULL exception drivers/scsi/bnx2fc/bnx2fc_fcoe.c |4 +- drivers/scsi/fcoe/fcoe.c |

[PATCH 06/19] libfc: Micro-optimize fc_setup_exch_mgr()

From: Bart Van Assche Convert a loop into an ilog2() call. Although this code is not performance sensitive this conversion makes this code easier to read. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 10 +++--- 1 file

[PATCH 04/19] libfc: Source code comment spelling fixes

From: Bart Van Assche Change 'initiaive' into 'initiative', 'remainig' into 'remaining' and change 'exected' into 'expected'. Signed-off-by: Bart Van Assche Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |5 +

[PATCH 13/19] fcp: Do not interpret check condition as underrun

From: Bart Van Assche This patch avoids that the FCoE initiator sends a REC message after having received a SCSI response with non-zero status and non-zero DATA IN buffer length. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_fcp.c | 10

[PATCH 11/19] libfc: Reduce exchange lock contention in fc_exch_recv_abts()

From: Bart Van Assche Reduce the time during which the exchange lock is held by allocating a frame before obtaining the exchange lock. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 18 ++ 1 file changed, 10

[PATCH 12/19] libfc: Do not invoke the response handler after fc_exch_done()

been aborted. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 131 +- include/scsi/libfc.h |9 +++ 2 files changed, 101 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/

[PATCH 16/19] fcoe: Reduce fcoe_sysfs_fcf_add() stack usage

: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index 9e83a79..692c653 100644 --- a/drivers/scsi

[PATCH 14/19] fcoe: Declare fcoe_ctlr_mode_set() static

From: Bart Van Assche The function fcoe_ctlr_mode_set() is local, hence declare it static. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 18/19] fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path

apply it on top of what you already have, that would be great. Thanks! Signed-off-by: Neil Horman CC: the...@redhat.com Reported-by: the...@redhat.com Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/fcoe

[PATCH 19/19] scsi: Convert uses of compare_ether_addr to ether_addr_equal

) Signed-off-by: Joe Perches Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |3 +-- drivers/scsi/fcoe/fcoe.c |2 +- drivers/scsi/fcoe/fcoe_ctlr.c | 22 +++--- drivers/scsi/fcoe/fcoe_sysfs.c|2 +- drivers/scsi/fnic/fnic_fcs.c |6

[PATCH 15/19] fcoe: Add missing newlines in debug messages

From: Bart Van Assche FCoE debug statements must end in a newline. Add one where it is missing. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 12 ++-- drivers/scsi/fcoe/fcoe_sysfs.c | 12 ++-- 2 files

[PATCH 17/19] libfcoe: Make fcoe_sysfs optional / fix fnic NULL exception

if ctlr->cdev is set and only if so will it continue to interact with fcoe_sysfs. Signed-off-by: Robert Love Acked-by: Neil Horman Tested-by: Hiral Patel --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |1 drivers/scsi/fcoe/fcoe.c |1 drivers/scsi/fcoe/fcoe_ctlr.c | 94 ++

[PATCH 02/19] fcoe: make sure fcoe frames are unshared prior to manipulating them

prior to doing anything with it. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 07453bb..f9b0302 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b

[PATCH 10/19] libfc: Avoid that sending after an abort triggers a kernel warning

art Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index bc0aba4..2a7fd5a 10064

[PATCH 01/19] fcoe: ensure that skb placed on the fip_recv_list are unshared

ods, implying list corruption, and the oops recorded above. The fix is pretty easy, just make sure that we clone the skb if its got multiple users with the skb_share_check function, like other protocols do. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |

[PATCH 09/19] libfc: Protect ep->esb_stat changes via ex_lock

ned-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index 7000203..bc0aba4 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c

[PATCH 05/19] libfc: Debug code fixes

: Robert Love --- drivers/scsi/libfc/fc_exch.c |8 drivers/scsi/libfc/fc_lport.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index b233a2d..cb2b900 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b

[PATCH 03/19] fcoe: cleanup return codes from fcoe_rcv

From: Neil Horman the return codes from fcoe_rcv should be NET_RX_*, not 0 or -1. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c

[PATCH 08/19] libfc: Fix a race in fc_exch_timer_set_locked()

enabled in the memory allocator. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index f6bb0fb

[PATCH 00/19] libfc, libfcoe, and fcoe updates for 3.13

fip_recv_list are unshared fcoe: make sure fcoe frames are unshared prior to manipulating them fcoe: cleanup return codes from fcoe_rcv fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path Robert Love (1): libfcoe: Make fcoe_sysfs optional / fix fnic NULL excepti

[PATCH 07/19] libfc: Clarify fc_exch_find()

From: Bart Van Assche The condition ep != NULL && ep->xid != xid can never be met. Make this explicit. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH 00/16] libfc, libfcoe, fcoe updates for 3.12(+)

The following series implements some fixes and enhancements. I know this series may be a bit late for the merge window. They have been in my tree so they could see some testing. Now that that is done I don't want to hold them back anymore. Please pull when appropriate. --- Bart Van Assche (13):

[PATCH 12/16] libfc: Do not invoke the response handler after fc_exch_done()

been aborted. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 131 +- include/scsi/libfc.h |9 +++ 2 files changed, 101 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/

[PATCH 11/16] libfc: Reduce exchange lock contention in fc_exch_recv_abts()

From: Bart Van Assche Reduce the time during which the exchange lock is held by allocating a frame before obtaining the exchange lock. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 18 ++ 1 file changed, 10

[PATCH 01/16] fcoe: ensure that skb placed on the fip_recv_list are unshared

ods, implying list corruption, and the oops recorded above. The fix is pretty easy, just make sure that we clone the skb if its got multiple users with the skb_share_check function, like other protocols do. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |

[PATCH 10/16] libfc: Avoid that sending after an abort triggers a kernel warning

art Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index bc0aba4..2a7fd5a 10064

[PATCH 06/16] libfc: Micro-optimize fc_setup_exch_mgr()

From: Bart Van Assche Convert a loop into an ilog2() call. Although this code is not performance sensitive this conversion makes this code easier to read. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 10 +++--- 1 file

[PATCH 15/16] fcoe: Add missing newlines in debug messages

From: Bart Van Assche FCoE debug statements must end in a newline. Add one where it is missing. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 12 ++-- drivers/scsi/fcoe/fcoe_sysfs.c | 12 ++-- 2 files

[PATCH 07/16] libfc: Clarify fc_exch_find()

From: Bart Van Assche The condition ep != NULL && ep->xid != xid can never be met. Make this explicit. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH 14/16] fcoe: Declare fcoe_ctlr_mode_set() static

From: Bart Van Assche The function fcoe_ctlr_mode_set() is local, hence declare it static. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 04/16] libfc: Source code comment spelling fixes

From: Bart Van Assche Change 'initiaive' into 'initiative', 'remainig' into 'remaining' and change 'exected' into 'expected'. Signed-off-by: Bart Van Assche Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |5 +

[PATCH 16/16] fcoe: Reduce fcoe_sysfs_fcf_add() stack usage

: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index 9e83a79..692c653 100644 --- a/drivers/scsi

[PATCH 05/16] libfc: Debug code fixes

: Robert Love --- drivers/scsi/libfc/fc_exch.c |8 drivers/scsi/libfc/fc_lport.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index b233a2d..cb2b900 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b

[PATCH 13/16] fcp: Do not interpret check condition as underrun

From: Bart Van Assche This patch avoids that the FCoE initiator sends a REC message after having received a SCSI response with non-zero status and non-zero DATA IN buffer length. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_fcp.c | 10

[PATCH 09/16] libfc: Protect ep->esb_stat changes via ex_lock

ned-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index 7000203..bc0aba4 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c

[PATCH 02/16] fcoe: make sure fcoe frames are unshared prior to manipulating them

prior to doing anything with it. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 07453bb..f9b0302 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b

[PATCH 03/16] fcoe: cleanup return codes from fcoe_rcv

From: Neil Horman the return codes from fcoe_rcv should be NET_RX_*, not 0 or -1. Signed-off-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c

[PATCH 08/16] libfc: Fix a race in fc_exch_timer_set_locked()

enabled in the memory allocator. Signed-off-by: Bart Van Assche Cc: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index f6bb0fb

[PATCH 7/8] fcoe: Stop fc_rport_priv structure leak

+0x7c/0xb0 [] 0x This patch stops the leak of the fc_rport_priv structure. Signed-off-by: Mark Rustad Tested-by: Jack Morgan Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers

[PATCH 6/8] libfcoe: Fix meaningless log statement

ctlr_dev was initialized to NULL, and never re-assigned. This caused the log statement to always report failure. This patch removes the unused variable and fixes the log statement to always report 'success', as that is what should be logged if the code reaches this point. Signed-off-

[PATCH 8/8] fcoe: Reduce number of sparse warnings

From: Bart Van Assche Declare local variables and functions 'static'. This patch does not change any functionality. Signed-off-by: Bart Van Assche Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_sysfs.c | 24 1 file changed, 12 insertions(+), 12

[PATCH 1/8] libfc: Reject PLOGI from nodes with incompatible role

From: Mark Rustad Reject a PLOGI from a node with an incompatible role, that is, initiator-to-initiator or target-to-target. Signed-off-by: Mark Rustad Reviewed-by: Yi Zou Tested-by: Jack Morgan Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_rport.c | 27

[PATCH 4/8] libfc: Remove extra space in fc_exch_timer_cancel definition

Simply remove an extra space that violates coding style. Signed-off-by: Robert Love Tested-by: Jack Morgan Acked-by: Neil Horman --- drivers/scsi/libfc/fc_exch.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c

[PATCH 5/8] libfc: Differentiate echange timer cancellation debug statements

There are two debug statements with the same output string regarding echange timer cancellation. This patch simply changes the output of one string so that they can be differentiated. Signed-off-by: Robert Love Tested-by: Jack Morgan Acked-by: Neil Horman --- drivers/scsi/libfc/fc_exch.c

[PATCH 2/8] fcoe: Fix smatch warning in fcoe_fdmi_info function

From: Neerav Parikh This patch fixes a smatch warning as below: smatch warnings: drivers/scsi/fcoe/fcoe.c:782 fcoe_fdmi_info() warn: 'fdmi' puts 896 bytes on stack Reported-by: Fengguang Wu Signed-off-by: Neerav Parikh Tested-by: Jack Morgan Signed-off-by: Robert Love --- dr

[PATCH 3/8] fcoe: fix the link error status block sparse warnings

fixes the warning from sparse check. Signed-off-by: Yi Zou Reported-by: Fengguang Wu Tested-by: Jack Morgan Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_transport.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 0/8] libfc, libfcoe, fcoe updates for 3.11(+)

ings Mark Rustad (2): libfc: Reject PLOGI from nodes with incompatible role fcoe: Stop fc_rport_priv structure leak Neerav Parikh (1): fcoe: Fix smatch warning in fcoe_fdmi_info function Robert Love (3): libfc: Remove extra space in fc_exch_timer_cancel definition

[PATCH 4/4] MAINTAINERS: Fix fcoe mailing list

From: Neil Horman The FCoE mailing list has moved, updte it in the MAINTAINERS file Signed-off-by: Neil Horman CC: Robert Love Signed-off-by: Robert Love --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8bdd7a7..bde678d

[PATCH 3/4] libfc: extend ex_lock to protect all of fc_seq_send

st fix this specific issue, we can just extend the ex_lock protection through the entire fc_seq_send path Signed-off-by: Neil Horman Reported-by: Gris Ge CC: Robert Love Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_exch.c | 37 - 1 file changed, 24

[PATCH 2/4] libfc: Correct check for initiator role

From: Mark Rustad The service_params field is being checked against the symbol FC_RPORT_ROLE_FCP_INITIATOR where it really should be checked against FCP_SPPF_INIT_FCN. Signed-off-by: Mark Rustad Tested-by: Jack Morgan Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_rport.c |2 +- 1

[PATCH 0/4] libfc, libfcoe, fcoe updates for 3.10-rc

The following series implements a few random fixes. --- Krishna Mohan (1): libfcoe: Fix Conflicting FCFs issue in the fabric Mark Rustad (1): libfc: Correct check for initiator role Neil Horman (2): libfc: extend ex_lock to protect all of fc_seq_send MAINTAINERS: Fix fco

[PATCH 1/4] libfcoe: Fix Conflicting FCFs issue in the fabric

Prakash Gollapudi Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index a762472..4c77641 100644 --- a/drivers/scsi/fcoe/fcoe_ctlr.c +

[PATCH 5/5] libfcoe: Fix fcoe_sysfs VN2VN mode

n in 'vn2vn' mode. Signed-off-by: Robert Love Tested-by: Jack Morgan Reviewed-by: Bhanu Prakash Gollapudi --- drivers/scsi/fcoe/fcoe_ctlr.c | 60 +++-- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr

[PATCH 4/5] libfc, fcoe, bnx2fc: Split fc_disc_init into fc_disc_{init, config}

Split discovery initialization in code that is setup once (fcoe_disc_init) and code that can be re-configured (fcoe_disc_config). Signed-off-by: Robert Love Tested-by: Jack Morgan Reviewed-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |3 ++- drivers/scsi/fcoe

[PATCH 3/5] libfc, fcoe, bnx2fc: Always use fcoe_disc_init for discovery layer initialization

Currently libfcoe is doing some libfc discovery layer initialization outside of libfc. This patch moves this code into libfc and sets up a split in discovery (one time) initialization code and (re-configurable) settings that will come in the next patch. Signed-off-by: Robert Love Tested-by: Jack

[PATCH 2/5] fcoe: Fix deadlock between create and destroy paths

[ 4200.503308] [] ? kthread_create_on_node+0x160/0x160 Signed-off-by: Robert Love Tested-by: Jack Morgan --- drivers/scsi/fcoe/fcoe.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index b5d92fc..9bfdc9a

[PATCH 1/5] bnx2fc: Make the fcoe_cltr the SCSI host parent

bnx2fc. This patch sets up the correct linkage for bnx2fc such that fcoemon will work correctly with fcoe_sysfs and bnx2fc. Signed-off-by: Robert Love Acked-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 0/5] libfc, bnx2fc, fcoe fixes for 3.9-rc

These patches are needed to allow fcoe to move to the new sysfs interfaces. I would like to see these pushed upstream for 3.9-rc. A pull-request mail will immediately follow this series. --- Robert Love (5): bnx2fc: Make the fcoe_cltr the SCSI host parent fcoe: Fix deadlock between

[PATCH] libfcoe: Check for unusable FCFs before looking for conflicting FCFs

FCFs (since fabric name is 0, it fails the condition), instead of first checking if it is usable or not. Fix it by first checking if FCF is usable and skip that FCF, and go to the next one in the list to check if it can be selected. Signed-off-by: Bhanu Prakash Gollapudi Signed-off-by: Robert Love

[PATCH 21/21] libfc: XenServer fails to mount root filesystem.

From: Krishna Mohan schedule_delayed_work() is using msec instead of jiffies. On PLOGI reject from target, remote port retry is scheduled @ 20 sec instead of 2sec(FC_DEF_E_D_TOV). XenServer dom0 kernel is configured with CONFIG_HZ=100Hz Signed-off-by: Krishna Mohan Signed-off-by: Robert Love

[PATCH 19/21] fcoe: Fix deadlock while deleting FCoE interface with NPIV ports

lport. Signed-off-by: Neerav Parikh Tested-by: Marcus Dennis Acked-by: Neil Horman Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index d605700..b5d92fc 1

[PATCH 20/21] libfcoe: Handle CVL while waiting to select an FCF

has cleared its internal state, and expects the initiator to start FIP discovery protocol. Fix this condition by resetting the fcoe controller. Signed-off-by: Bhanu Prakash Gollapudi Reviewed-by: Yi Zou Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_ctlr.c | 10 +- 1 file

[PATCH 18/21] fcoe: close race on link speed detection in fcoe code

fcoe_link_speed_update. Also use this opportunity to clean up access to the fc_hostlist a bit by creating a fcoe_hostlist_del accessor and replacing the cleanup in fcoe_exit to use it properly. Tested by myself successfully [ Comment over 80 chars broken into multi-line by Robert Love to satisfy

[PATCH 16/21] debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks"

ed-off-by: Al Viro Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_transport.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index dd1aeb4..f3a5a53 100644 --- a/drivers/scsi/fcoe/fcoe_tran

[PATCH 15/21] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe

From: Yi Zou Drop the bnx2fc_xxx versions as they are basically the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 53 + 1 file changed, 7 insertions

[PATCH 14/21] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe

From: Yi Zou We have fcoe_link_speed_update() in libfcoe ready for use now, take out the bnx2fc version which is almost the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 33

[PATCH 13/21] bnx2fc: add support to get_netdev for bnx2f_interface

From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer for bnx2fc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |5 +++-- 1 file changed, 3 insertions(

[PATCH 12/21] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb

From: Yi Zou Similarly they can be moved into libfcoe instead of being private to fcoe now. Also add comments particularly on the term LESB to the corresponding function. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi

[PATCH 11/21] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it

From: Yi Zou With the previous patch, fcoe_link_speed_update() can be moved into libfcoe and exported to used by fcoe, bnx2fc, and etc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 35

[PATCH 10/21] fcoe: add support to the get_netdev() for fcoe_interface

From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |1 + include/scsi/libfcoe.h | 12 2 files change

[PATCH 09/21] fcoe: prep work to start consolidate the usage of fcoe_netdev

of it. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- include/scsi/libfcoe.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h index 6add37a..52bba71 100644 --- a/include/scsi/libf

[PATCH 08/21] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info

Convert libfc, libfcoe and fcoe's debug_logging macros to use pr_info() instead of printk(KERN_INFO, ...). checkpatch.pl now complains about this, so convert libfcoe to preferred method. Signed-off-by: Robert Love Tested-by: Marcus Dennis --- drivers/scsi/fcoe/fcoe.h |

[PATCH 05/21] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

call the LLD (if there is a callback) to notifiy that the enalbed state has changed. This patch maintains the old FCoE control interfaces as module parameters, but it adds comments pointing out that the old interfaces are deprecated. Signed-off-by: Robert Love Acked-by: Neil Horman --- Documentati

[PATCH 07/21] bnx2fc: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love Acked-by: N

[PATCH 06/21] fcoe: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love Acked-by: N

[PATCH 02/21] Documentation: Add missing devices/ to devices path

Add missing 'devices/ subdirectory to /sys/bus/fcoe/devices/ctlr_X and /sys/bus/fcoe/devices/fcf_X references. Signed-off-by: Robert Love Tested-by: Ross Brattain --- Documentation/ABI/testing/sysfs-bus-fcoe |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 04/21] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love Acked-by: Neil Horman --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 03/21] libfcoe: Save some memory and optimize name lookups

latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love Acked-by: Neil

[PATCH 01/21] libfc: fix REC handling

27;t cause any issue during clearing FC_RP_FLAGS_REC_SUPPORTED on failed IO with target not supporting FC_RP_FLAGS_REC_SUPPORTED, since retry on failed IO would succeed. Signed-off-by: Vasu Dev Tested-by: Ross Brattain Signed-off-by: Robert Love --- drivers/scsi/libfc/fc_fcp.c |6 +++-

[PATCH 00/21] libfc, libfcoe and fcoe updates for 3.9

orts Neil Horman (1): fcoe: close race on link speed detection in fcoe code Robert Love (7): Documentation: Add missing devices/ to devices path libfcoe: Save some memory and optimize name lookups libfcoe: Add fcoe_sysfs debug logging level libfcoe, fcoe, bnx2fc: Add new fc

FCoE Updates for 3.8 (v2)

--- Al Viro (1): debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks" Robert Love (7): Documentation: Add missing devices/ to devices path libfcoe: Save some memory and optimize name lookups libfcoe: Add fcoe_sysfs debug logging level

[PATCH v2] libfcoe: Save some memory and optimize name lookups

latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love Acked-by: Neil

FCoE Updates for 3.8

syscall checks" Robert Love (7): Documentation: Add missing devices/ to devices path libfcoe: Save some memory and optimize name lookups libfcoe: Add fcoe_sysfs debug logging level libfcoe, fcoe, bnx2fc: Add new fcoe control interface fcoe: Use the fcoe_sysfs control in

[PATCH 16/16] debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks"

ed-off-by: Al Viro Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_transport.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index dd1aeb4..f3a5a53 100644 --- a/drivers/scsi/fcoe/fcoe_tran

[PATCH 15/16] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe

From: Yi Zou Drop the bnx2fc_xxx versions as they are basically the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 53 + 1 file changed, 7 insertions

[PATCH 14/16] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe

From: Yi Zou We have fcoe_link_speed_update() in libfcoe ready for use now, take out the bnx2fc version which is almost the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 33

[PATCH 13/16] bnx2fc: add support to get_netdev for bnx2f_interface

From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer for bnx2fc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |5 +++-- 1 file changed, 3 insertions(

[PATCH 12/16] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb

From: Yi Zou Similarly they can be moved into libfcoe instead of being private to fcoe now. Also add comments particularly on the term LESB to the corresponding function. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi

[PATCH 11/16] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it

From: Yi Zou With the previous patch, fcoe_link_speed_update() can be moved into libfcoe and exported to used by fcoe, bnx2fc, and etc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 35

[PATCH 10/16] fcoe: add support to the get_netdev() for fcoe_interface

From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |1 + include/scsi/libfcoe.h | 12 2 files change

[PATCH 09/16] fcoe: prep work to start consolidate the usage of fcoe_netdev

of it. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- include/scsi/libfcoe.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h index 6add37a..52bba71 100644 --- a/include/scsi/libf

[PATCH 08/16] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info

Convert libfc, libfcoe and fcoe's debug_logging macros to use pr_info() instead of printk(KERN_INFO, ...). checkpatch.pl now complains about this, so convert libfcoe to preferred method. Signed-off-by: Robert Love Tested-by: Marcus Dennis --- drivers/scsi/fcoe/fcoe.h |

[PATCH 06/16] fcoe: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love Acked-by: N

[PATCH 07/16] bnx2fc: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love Acked-by: N

[PATCH 05/16] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

call the LLD (if there is a callback) to notifiy that the enalbed state has changed. This patch maintains the old FCoE control interfaces as module parameters, but it adds comments pointing out that the old interfaces are deprecated. Signed-off-by: Robert Love Acked-by: Neil Horman --- Documentati

[PATCH 04/16] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love Acked-by: Neil Horman --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 03/16] libfcoe: Save some memory and optimize name lookups

latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love Acked-by: Neil

[PATCH 00/16] libfc, libfcoe and fcoe updates for 3.8

compose a pull-request and send it soon, but I wanted to make sure the most recent versions of these patches were posted to linux-scsi first. --- Al Viro (1): debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks" Robert Love (7): Documentation: Add

  1   2   >