Use "*/" to end kernel-doc notation blocks.
> - A few other minor typo fixes.
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
Acked-by: Rob Landley <[EMAIL PROTECTED]>
Rob
--
"One of my most productive days was throwing away 1000 lines of code."
- Ke
On Wednesday 07 November 2007 00:47:20 James Bottomley wrote:
> On Sun, 2007-11-04 at 10:02 -0800, Randy Dunlap wrote:
> > My only concern with this ATM is its name (SCSI midlayer), but
> > chapter 2 is SCSI upper layer, chap 3 is SCSI midlayer, and
> > chap 4 is SCSI low-level interfaces.
> >
> >
On Tuesday 30 October 2007 9:43:29 am James Bottomley wrote:
> On Tue, 2007-10-30 at 08:34 -0400, Jeff Garzik wrote:
> > Randy Dunlap wrote:
> > > On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote:
> > >> On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wro
On Saturday 27 October 2007 8:24:24 am James Bottomley wrote:
> On Fri, 2007-10-26 at 23:05 -0700, Randy Dunlap wrote:
> > On Fri, 26 Oct 2007 23:18:00 -0500 Rob Landley wrote:
> > > From: Rob Landley <[EMAIL PROTECTED]>
> > >
> > > Add Documentation/DocB
From: Rob Landley <[EMAIL PROTECTED]>
Add Documentation/DocBook/scsi_midlayer.tmpl and add to Makefile.
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
Documentation/DocBook/Makefile |2
Documentation/DocBook/scsi_midlayer.tmpl | 409 +
2 f
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_transport_srp.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_srp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -r a868e8217782
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_transport_sas.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_sas.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff -r a868e8217782
On Friday 26 October 2007 5:47:57 pm James Bottomley wrote:
> > > http://www.t10.org/ftp/t10/drafts/sam3/sam3r14.pdf
> > > http://www.t10.org/ftp/t10/drafts/sam4/sam4r13.pdf
> >
> > Unfortunately those two documents are 127 pages and 148 pages,
> > respectively, and I haven't had a chance to make a
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_transport_iscsi.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -r a868e8217782
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_transport_fc.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_fc.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff -r
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_scan.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_scan.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff -r a868e8217782
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_proc.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_proc.c | 110 -
1 file changed, 108 insertions(+), 2 deletions(-)
diff -r a868e821
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_netlink.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_netlink.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff -r a868e8217782
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_ioctl.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_ioctl.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff -r a868e8217782
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_lib.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_lib.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff -r a868e8217782 drivers/scsi/scsi
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_error.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_error.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff -r a868e821
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi_devinfo.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_devinfo.c | 34 +++---
1 file changed, 15 insertions(+), 19 deletions(-)
diff -r
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/constants.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/constants.c |1 -
1 file changed, 1 deletion(-)
diff -r a868e8217782 drivers/scsi/constants.c
--- a/drivers/scsi/constant
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsicam.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsicam.c | 39 ++-
1 file changed, 26 insertions(+), 13 deletions(-)
diff -r a868e821
From: Rob Landley <[EMAIL PROTECTED]>
Update kerneldoc comments in drivers/scsi/scsi.c
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
drivers/scsi/scsi.c | 195 +-
1 file changed, 102 insertions(+), 93 deletions(-)
diff -r a868e8217782
On Friday 26 October 2007 5:45:56 pm Stefan Richter wrote:
> Rob Landley wrote:
> > drivers/scsi/scsi.c | 181 -
>
> Also have a look at this:
> "Fix a few misleading comments in scsi.c"
> http://marc.info/?l=linux-scsi&m=119340708
On Friday 26 October 2007 5:45:56 pm Stefan Richter wrote:
> Rob Landley wrote:
> > drivers/scsi/scsi.c | 181 -
>
> Also have a look at this:
> "Fix a few misleading comments in scsi.c"
> http://marc.info/?l=linux-scsi&m=119340708
On Friday 26 October 2007 4:09:37 pm James Bottomley wrote:
> On Fri, 2007-10-26 at 15:07 -0500, Rob Landley wrote:
> > I don't understanding this code:
> >
> > 1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this
> > only for parall
I don't understanding this code:
1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this only
for parallel scsi? I thought most modern busses (usb, sata, FC, firewire,
etc) dynamically assign these numbers and just use them as a unique
identifier ala kdev_t. How would this wor
On Thursday 25 October 2007 3:49:26 pm Randy Dunlap wrote:
> On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote:
> > On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote:
> > > > Entirely possible I'm doing something wrong:
> > > >
> > >
Looking at the scsi_transport_*.c files... Are these part of the lower layer
or the midlayer? I _think_ these exist primarily to expose information about
the lower layers through sysfs, but I'm very fuzzy on this...
Should they be documented as part of the lower layer or the midlayer or are
t
On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote:
> > Entirely possible I'm doing something wrong:
> >
> >
> > include/scsi/scsi_device.h
> >
> >
> > !Einclude/scsi/scsi_device.h
> >
>
> !E is for exported symbols and that file has none.
> USe !I instead.
So
On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote:
> > Entirely possible I'm doing something wrong:
> >
> >
> > include/scsi/scsi_device.h
> >
> >
> > !Einclude/scsi/scsi_device.h
> >
>
> !E is for exported symbols and that file has none.
> USe !I instead.
Ah,
On Thursday 25 October 2007 10:40:39 am Randy Dunlap wrote:
> On Thu, 25 Oct 2007 06:06:03 -0500 Rob Landley wrote:
> > The rest sort of seems to make sense, although the kerneldoc comments in
> > include/scsi/scsi_device.h are before #defines instead of before function
> > de
Ok, I'm reading the code and trying to update the kerneldoc comments (first
stab at it attached, a Documentation/DocBook/scsi_midlayer.tmpl is in the
works), and I have a few random questions from the read-through:
Why does __scsi_put_command() pass in both a Scsi_Host * and struct device *
whe
On Thursday 11 October 2007 4:49:28 pm David Miller wrote:
> From: Rob Landley <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 17:47:02 -0500
>
> > On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> > > Since scsi_esp_{,un}register() are EXPORT_SYMBOL'
On Tuesday 16 October 2007 5:28:59 am Alan Cox wrote:
> > I'm sure somebody will eventually write an OLS paper or something on the
> > advisability of making swapping decisions with 4k granularity when disks
> > really want bigger I/O transactions.
>
> Funnily enough someone thought of that many ye
On Monday 15 October 2007 11:38:33 pm Eric W. Biederman wrote:
> > I don't follow your logic. We don't need SWAP > RAM in order to swap
> > effectively, IMO.
>
> The steady state of a system that is heavily and usably swapping but
> not thrashing is that all of the pages in RAM are in the swap cach
On Monday 15 October 2007 12:25:13 pm Greg KH wrote:
> Oh, and this seems like a very Ubuntu specific rant, might I suggest you
> contact the Ubuntu developers about this? The kernel doesn't dictate
> that the distro has to use these long identifiers, and there is nothing
> we can do about it.
I
On Monday 15 October 2007 8:10:49 am James Bottomley wrote:
> OK, so could we get back to the original discussion? The question I
> think you meant to ask is "does SCSI use the block layer, and if so;
> how?"
>
> The answer is yes (just do an ls /sys/block on any scsi machine). The
> how is that
On Monday 15 October 2007 6:19:58 am Neil Brown wrote:
> On Monday October 15, [EMAIL PROTECTED] wrote:
> > This is my objection. Even when enumerating multiple devices of the same
> > type is tricky, enumerating multiple devices of _different_ types should
> > not be. There's a great big type ind
On Monday 15 October 2007 5:32:32 am Loïc Grenié wrote:
> You are really looking like you are out for a fight.
...
> Your objection is interesting. It is lost in the middle of e-mails
> which, to the untrained eye, look like you are trying to fight everyone and
> everybody.
...
> ...holy
On Monday 15 October 2007 4:06:20 am Julian Calaby wrote:
> On 10/15/07, Rob Landley <[EMAIL PROTECTED]> wrote:
> > I note that the eth0 and eth1 names are dynamically assigned on a first
> > come first serve basis (like scsi). This never causes me a problem
> > becau
On Monday 15 October 2007 8:37:44 am Nick Piggin wrote:
> > Virtual memory isn't perfect. I've _always_ been able to come up with
> > examples where it just doesn't work for me. This doesn't mean VM
> > overcommit should be abolished, because it's useful more often than not.
>
> I hate to go comp
On Monday 15 October 2007 12:44:19 am Stefan Richter wrote:
> Rob Landley wrote:
> > I was at least attempting to ask a serious question.
>
> ...
>
> > Actually, I was going through Documentation/block thinking about making a
> > 00-INDEX for it, but my earlier ques
On Monday 15 October 2007 1:00:15 am Greg KH wrote:
> If you hate USB storage devices using scsi, please use the ub driver,
> that is what it was written for.
For the embedded space, the ability to configure out the scsi layer is
interesting from a size perspective. I bookmarked that a while bac
On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote:
> On Sun, Oct 14, 2007 at 06:45:44PM -0500, Rob Landley wrote:
> > I admit a certain amount of personal annoyance that once the SCSI
> > layer consumes a category of device (USB, SATA, PATA), they can
> > often _o
On Sunday 14 October 2007 7:45:46 pm Luben Tuikov wrote:
> Matthew's expletive and extremely rude response really shows
> the general attitude of the linux-scsi people.
No, it doesn't. James Bottomley has been exceedingly polite and helpful, as
were several other people on the linux-scsi list wh
On Sunday 14 October 2007 5:24:32 pm James Bottomley wrote:
> On Sat, 2007-10-13 at 16:05 -0600, Matthew Wilcox wrote:
> > On Thu, Oct 11, 2007 at 08:11:21PM -0500, Rob Landley wrote:
> > > My impression from asking questions on the linux-scsi mailing list is
> > > that
On Sunday 14 October 2007 12:46:12 pm Stefan Richter wrote:
> David Newall wrote:
> > That is so rude.
When a reply contains as a reply to the first paragraph "you're wrong" with no
elaboration, and as a reply to the second paragraph nothing but expletives
and personal insults, I tend to stop re
My impression from asking questions on the linux-scsi mailing list is that the
scsi upper/middle/lower layers doesn't use the block layer described in
Documentation/block/*.
For example, the scsi guys say:
http://marc.info/?l=linux-scsi&m=118633268527856&w=2
Instead of using the block layer, SC
On Thursday 11 October 2007 6:56:59 pm Adrian Bunk wrote:
> On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote:
> > On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote:
> > > I assume you have the full .config in your build directory, and could
> > &g
On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions
> (and the functions they use) can't be __dev{init,exit}.
>
> Based on a bug report by Rob Landley.
>
> Signed-off-by: Adrian Bunk <[E
On Thursday 11 October 2007 6:05:55 am Adrian Bunk wrote:
> On Thu, Oct 11, 2007 at 05:52:48AM -0500, Rob Landley wrote:
> > CONFIG_SCSI_SUNESP=y breaks the build in 2.6.23:
> >
> > LD vmlinux
> > `scsi_esp_unregister' referenced in section `__ksymtab'
CONFIG_SCSI_SUNESP=y breaks the build in 2.6.23:
LD vmlinux
`scsi_esp_unregister' referenced in section `__ksymtab' of drivers/built-in.o:
defined in discarded section `.exit.text' of drivers/built-in.o
make: *** [vmlinux] Error 1
Do you need my full .config to reproduce this?
Rob
--
"O
From: Rob Landley <[EMAIL PROTECTED]>
Update Documentation/scsi/00-INDEX to match current files.
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
Documentation/scsi/00-INDEX | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff -r
On Sunday 05 August 2007 11:50:33 am Douglas Gilbert wrote:
> Stefan Richter wrote:
> > Rob Landley wrote:
> >> So an sg device is for something like a scanner that doesn't
> >> present a block device?
> >
> > That's what I heard.
>
> The s
On Friday 03 August 2007 2:37:02 pm Stefan Richter wrote:
> Rob Landley wrote:
> > They keep using the fact that they're exporting random kernel data as an
> > excuse for not documenting a stable subset of this as an API userspace
> > can rely on.
>
> At least sysf
On Friday 03 August 2007 5:43:25 am Stefan Richter wrote:
> Rob Landley wrote:
> > On Thursday 02 August 2007 5:19:51 pm Stefan Richter wrote:
> >> Alternatively to partition labels, you can also have udev create
> >> persistently named symlinks for you.
> >
&
On Friday 03 August 2007 3:15:27 am Stefan Richter wrote:
> Rob Landley wrote:
> > On Thursday 02 August 2007 5:39:55 pm Stefan Richter wrote:
> >> The place where these symlinks live might change in the future. See
> >> linux-2.6.23*/Documentation/sysfs-rules.txt.
>
On Thursday 02 August 2007 5:39:55 pm Stefan Richter wrote:
> The place where these symlinks live might change in the future. See
> linux-2.6.23*/Documentation/sysfs-rules.txt.
I noticed this. I had a longish flamewar with Greg KH about this, which would
be ongoing if he hadn't stopped replying
On Thursday 02 August 2007 5:19:51 pm Stefan Richter wrote:
> > Rob Landley wrote:
> >> On Thursday 26 July 2007 9:15:11 am James Bottomley wrote:
> >>> Users have great difficulty understanding how to
> >>> map sg to sr (or sd), so we're trying to
On Thursday 02 August 2007 2:41:46 pm Douglas Gilbert wrote:
> > I'm still trying to figure what the other options _are_.
> >
> >> James
> >
> > Rob
>
> Interesting discussion.
I'm trying to pull together documentation of the scsi layer and link it into
the index I'm trying to put up at http://ke
On Thursday 26 July 2007 9:15:11 am James Bottomley wrote:
> On Wed, 2007-07-25 at 23:28 -0400, Rob Landley wrote:
> > 1) Is the summary of the scsi subsystem in appendix A of your 2002 OLS
> > paper still more or less current? (The scsi mid-layer document never
> > se
59 matches
Mail list logo
