Re: [EXT] Re: [PATCH v2 04/14] qla2xxx: Optimize NPIV tear down process

2019-09-26 Thread Quinn Tran
On 9/26/19, 3:52 AM, "Martin Wilck" wrote: External Email -- On Thu, 2019-09-12 at 11:09 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > In the case of NPIV port is be

Re: [PATCH] qla2xxx: always allocate qla_tgt_wq

2019-07-12 Thread Quinn Tran
tialize FW. Initiator side eh_abort goes through a specific IOCB call "Abort IO" that can enter through our Request IOCB Q or Mailbox interface. Abort IO completion would 'NOT' return back to driver as ABTS_RECV_24XX. Regards, Quinn Tran On 7/12/19, 12:01 AM, "linux-scsi

Re: [PATCH v2 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-20 Thread Quinn Tran
next submission window. Regards, Quinn Tran On 6/19/19, 1:36 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On 6/18/19 11:10 AM, Himanshu Madhani wrote: > diff --git a/drivers/scsi/qla2xxx/qla_nvme.h b/drivers/scsi/qla2xxx/qla_nvme.h &g

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-18 Thread Quinn Tran
On 6/18/19, 8:57 AM, "Bart Van Assche" wrote: On 6/17/19 5:01 PM, Quinn Tran wrote: > Attached is the clean-up patch that we held back from the series. > We felt it wasn't ready for wider audience because it needed additional > soak time with our test gro

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-17 Thread Quinn Tran
|kref]. Once it has some soak time in our test group, we'll submit it in the next RC window. Thanks. Regards, Quinn Tran On 6/17/19, 1:42 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On 6/14/19 3:58 PM, Himanshu Madhani wrote: > Ye

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-06-30 Thread Quinn Tran
Ack. Looks good. Thanks. Regards, Quinn Tran -Original Message- From: Bruno Prémont Date: Thursday, June 30, 2016 at 8:00 AM To: Quinn Tran , Himanshu Madhani , Nicholas Bellinger Cc: Dept-Eng QLA2xxx Upstream , "James E.J. Bottomley" , "Martin K. Petersen

Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

2016-06-23 Thread Quinn Tran
-Original Message- From: Johannes Thumshirn Date: Thursday, June 23, 2016 at 12:22 AM To: Quinn Tran Cc: "Martin K. Petersen" , Linus Torvalds , Josh Boyer , Thorsten Leemhuis , linux-kernel , linux-scsi Subject: Re: Reported regressions for 4.7 as of Sunday, 2016-06-

Re: [PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-28 Thread Quinn Tran
-Original Message- From: on behalf of Josh Poimboeuf Date: Wednesday, April 27, 2016 at 3:11 PM To: Arnd Bergmann Cc: Martin Jambor , "Martin K. Petersen" , James Bottomley , linux-scsi , linux-kernel , Denys Vlasenko , Thomas Graf , Peter Zijlstra , David Rientjes , Andrew Mort

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-22 Thread Quinn Tran
ars kernel: [] ? dev_attr_show+0x20/0x50 Regards, Quinn Tran -Original Message- From: on behalf of Josh Poimboeuf Date: Tuesday, April 19, 2016 at 6:56 AM To: James Bottomley , "Martin K. Petersen" Cc: linux-scsi , linux-kernel , Denys Vlasenko , Thomas Graf , P

Re: [Lsf] [LSF/MM TOPIC] block-mq issues with FC

2016-04-12 Thread Quinn Tran
>Hey Willy, > >> - Interrupt steering needs to be controlled by block-mq instead of >> the driver. It's pointless to have each driver implement its own >> policies on interrupt steering, irqbalanced remains a source of >> end-user frustration, and block-mq can change the queue<->cpu

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

2016-04-11 Thread Quinn Tran
* then set it here. */ Regards, Quinn Tran -Original Message- From: Joseph Salisbury Date: Monday, April 11, 2016 at 11:41 AM To: Quinn Tran Cc: Dept-Eng QLA2xxx Upstream , "j...@linux.vnet.ibm.com" , "Martin K. Petersen" , linux-scsi , linux-ke

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

2016-04-11 Thread Quinn Tran
Joe, How do I get access to this specific Ubuntu kernel where the bug is found? Is there stack trace/bug report that you could share? Any data would be helpful. Thanks. In the mean time, I will download 4.5 rc4 to re-verify. Regards, Quinn Tran -Original Message- From: Joseph

Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables

2016-03-31 Thread Quinn Tran
-Original Message- From: Johannes Thumshirn Date: Thursday, March 31, 2016 at 12:37 AM To: Bart Van Assche Cc: James Bottomley , "Martin K. Petersen" , Himanshu Madhani , Quinn Tran , Christoph Hellwig , linux-scsi , "linux-scsi-ow...@vger.kernel.org" Sub

Re: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags

2016-03-31 Thread Quinn Tran
Bart, We use these flags for debugging purpose in crash cases. Please drop the patch. Thanks. Regards, Quinn Tran -Original Message- From: Bart Van Assche Date: Wednesday, March 30, 2016 at 4:26 PM To: James Bottomley , "Martin K. Petersen" Cc: Himanshu Madhani ,

Re: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags

2016-03-31 Thread Quinn Tran
Agreed. It’s one of our pending action items for cleanup. Regards, Quinn Tran -Original Message- From: Bart Van Assche Date: Thursday, March 31, 2016 at 8:22 AM To: Quinn Tran , James Bottomley , "Martin K. Petersen" Cc: Himanshu Madhani , Christoph Hellwig ,

Re: [PATCH 1/3] qla2xxx: Indicate out-of-memory with -ENOMEM

2016-03-31 Thread Quinn Tran
-Original Message- From: Johannes Thumshirn Date: Thursday, March 31, 2016 at 12:30 AM To: Bart Van Assche Cc: James Bottomley , "Martin K. Petersen" , Himanshu Madhani , Quinn Tran , Christoph Hellwig , linux-scsi , "linux-scsi-ow...@vger.kernel.org" Sub

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-05 Thread Quinn Tran
Bart, Thanks for sharing the script. Will drop the patch. Regards, Quinn Tran On 2/5/16, 11:42 AM, "Bart Van Assche" wrote: >On 02/05/2016 10:49 AM, Quinn Tran wrote: >> On 2/4/16, 10:20 AM, "Bart Van Assche" wrote: >>> On 02/04/2016 08:45 AM, Hi

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-05 Thread Quinn Tran
ives us the summary. We choose path 2 for the ease of usage. Regards, Quinn Tran On 2/4/16, 10:20 AM, "Bart Van Assche" wrote: >On 02/04/2016 08:45 AM, Himanshu Madhani wrote: >> From: Quinn Tran >> >>> cat /sys/kernel/debug/qla2xxx/*/irq_cpuid >>

Re: [PATCH v2 11/16] qla2xxx: Add selective command queuing

2016-01-04 Thread Quinn Tran
On 12/29/15, 1:32 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: >On 12/17/2015 08:57 PM, Himanshu Madhani wrote: >>From: Quinn Tran >>queue work element to specific process lessen cache miss > >How about replacing this patch by some

Re: [PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

2016-01-04 Thread Quinn Tran
On 12/20/15, 11:13 PM, "target-devel-ow...@vger.kernel.org on behalf of Nicholas A. Bellinger" wrote: >On Thu, 2015-12-17 at 14:57 -0500, Himanshu Madhani wrote: >> From: Quinn Tran >> >> At high traffic, the work queue can become a bottle neck. >> I

Re: [PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer

2015-12-14 Thread Quinn Tran
Christoph, Thanks for reviewing. I¹ll withdraw this patch. Will rework with new code and submit at a later time. Regards, Quinn Tran On 12/14/15, 2:37 AM, "Christoph Hellwig" wrote: >On Wed, Dec 09, 2015 at 08:24:57PM +0000, Quinn Tran wrote: >> >> + if

Re: [PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

2015-12-14 Thread Quinn Tran
Christoph, Thanks for reviewing. I¹ll withdraw this patch. Will rework with new code and submit at a later time. Regards, Quinn Tran On 12/14/15, 2:34 AM, "Christoph Hellwig" wrote: >On Wed, Dec 09, 2015 at 10:07:32PM +0000, Quinn Tran wrote: >> >Err, no. Loo

Re: [PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

2015-12-09 Thread Quinn Tran
On 12/8/15, 10:56 PM, "target-devel-ow...@vger.kernel.org on behalf of Hannes Reinecke" wrote: >On 12/08/2015 01:48 AM, Himanshu Madhani wrote: >> From: Quinn Tran >> >> change tcm_qla2xxx_check_stop_free to always return 1 >> to prevent transport_cmd_f

Re: [PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

2015-12-09 Thread Quinn Tran
he cleanup. With out the lock, we kept hitting multiple free problem. Regards, Quinn Tran On 12/8/15, 11:01 PM, "target-devel-ow...@vger.kernel.org on behalf of Hannes Reinecke" wrote: >>+ >> } >> >> static void tcm_qla2xxx_clear_sess_lookup(struct tcm_qla

Re: [PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

2015-12-09 Thread Quinn Tran
On 12/7/15, 6:37 PM, "target-devel-ow...@vger.kernel.org on behalf of Christoph Hellwig" wrote: >> -void qlt_abort_cmd(struct qla_tgt_cmd *cmd) >> +int qlt_abort_cmd(struct qla_tgt_cmd *cmd) >> { >> struct qla_tgt *tgt = cmd->tgt; >> struct scsi_qla_host *vha = tgt->vha; >> struc

Re: [PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer

2015-12-09 Thread Quinn Tran
On 12/7/15, 6:48 PM, "target-devel-ow...@vger.kernel.org on behalf of Christoph Hellwig" wrote: >> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c >>b/drivers/scsi/qla2xxx/tcm_qla2xxx.c >> index 842fcca..2e9c194 100644 >> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c >> +++ b/drivers/scsi/qla2xxx/tcm

Re: [PATCH 12/20] target/tmr: LUN reset cause cmd premature free.

2015-12-09 Thread Quinn Tran
Christoph, Understood. I was not sure which way the community is swinging. For what it¹s worth, this fix was required to stabilize one of our customer environment in the older kernel. Regards, Quinn Tran On 12/7/15, 6:48 PM, "target-devel-ow...@vger.kernel.org on behalf of Chri

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-27 Thread Quinn Tran
river defined binary", one alternative would be to translate QLA¹s private command state into se_cmd¹s new field. This new file would be modify by the fabric layer only. This would limit any regression with existing se_cmd field modification. Regards, Quinn Tran On 7/24/15, 11:29 PM, "

Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

2015-03-12 Thread Quinn Tran
If the intend is to test all adapters, then the error injection need to be move higher up into TCM driver. Regards, Quinn Tran On 3/7/15, 8:26 PM, "Laurence Oberman" wrote: >Hello > >I use target LIO for all my storage array test targets and customer >problem resolutio

Re: [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-01-14 Thread Quinn Tran
On 1/14/15, 2:05 AM, "Bart Van Assche" wrote: >The LIO and SCST SCSI target subsystems consist of the following >components: >* A core that processes SCSI commands and that provides common >functionality like persistent reservations, LUN masking and an interface >that allows configuration from

Re: [PATCH v1 3/3] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire

2014-06-11 Thread Quinn Tran
On 6/11/14 2:30 PM, "Nicholas A. Bellinger" wrote: >On Wed, 2014-06-11 at 10:24 +0300, Sagi Grimberg wrote: >> On 6/11/2014 12:17 AM, Quinn Tran wrote: >> >> >> >> > QT> Instead of using existing value within cmd->data_length, can we >&

Re: [PATCH v1 3/3] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire

2014-06-10 Thread Quinn Tran
All, Comments inline. Regards, Quinn Tran On 6/10/14 1:04 AM, "Nicholas A. Bellinger" wrote: >Hi Sagi & Co, > >On Sun, 2014-06-08 at 13:27 +0300, Sagi Grimberg wrote: >> In various areas of the code, it is assumed that >> se_cmd->data_length describes

Re: [PATCH] qla2xxx: Convert to percpu_ida session tag pre-allocation

2014-06-02 Thread Quinn Tran
Regards, Quinn Tran On 6/2/14 3:12 PM, "Nicholas A. Bellinger" wrote: >> >>Extra size note, the true value should be extracted from >>"ha->fw_xcb_count", if this field is set. Otherwise, default back to >>TCM_QLA2XXX_DEFAULT_TAGS. > >O

Re: [PATCH] qla2xxx: Convert to percpu_ida session tag pre-allocation

2014-05-29 Thread Quinn Tran
Nicholas, Answer is below. Regards, Quinn Tran On 5/23/14 7:33 PM, "Nicholas A. Bellinger" wrote: >Hi Qlogic folks, > >A question for you below.. > >On Sat, 2014-05-24 at 00:43 +, Nicholas A. Bellinger wrote: >> From: Nicholas Bellinger >> >>

Re: [PATCH 39/42] qla2xxx: ABTS cause double free of qla_tgt_cmd +.

2014-05-28 Thread Quinn Tran
Nicholas, At this point we can forgo this patch to stable tree. There are additional tweaks in this path during testing. We will update the stable tree with new findings. Thanks. Regards, Quinn Tran On 5/22/14 8:00 PM, "Nicholas A. Bellinger" wrote: >Hi Saurav + Quinn, >

Re: [PATCH 1/4] target/core: T10-Dif: check HW support capabilities

2014-04-02 Thread Quinn Tran
Regards, Quinn Tran On 4/2/14 11:20 AM, "Nicholas A. Bellinger" wrote: >On Wed, 2014-04-02 at 09:51 +0300, Sagi Grimberg wrote: >> On 4/1/2014 8:45 PM, Nicholas A. Bellinger wrote: >> > On Tue, 2014-04-01 at 20:27 +0300, sagi grimberg wrote: >> >>

Re: [PATCH 1/4] target/core: T10-Dif: check HW support capabilities

2014-03-31 Thread Quinn Tran
Regards, Quinn Tran On 3/28/14 6:24 PM, "sagi grimberg" wrote: >On 3/29/2014 3:53 AM, Quinn Tran wrote: >> + >> +if (dev->dev_attrib.pi_prot_type) { >> +uint32_t cap[] = { 0, >> +

Re: [PATCH 4/4] target/rd: T10-Dif: RAM disk is allocating more space than required.

2014-03-31 Thread Quinn Tran
Regards, Quinn Tran On 3/28/14 5:22 PM, "sagi grimberg" wrote: >On 3/29/2014 2:05 AM, Quinn Tran wrote: >> Ram disk is allocating 8x more space than required for diff data. >> For large RAM disk test, there is small potential for memory >> starvation. >>

Re: [PATCH 3/4] target/rd: T10-Dif: Add init/format support

2014-03-31 Thread Quinn Tran
Regards, Quinn Tran On 3/28/14 5:16 PM, "sagi grimberg" wrote: >On 3/29/2014 2:05 AM, Quinn Tran wrote: >> This patch is borrow code from >> >> commit 0f5e2ec46dd64579c0770f3822764f94db4fa465 >> Author: Nicholas Bellinger >> Date: Sat Jan 18

Re: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-31 Thread Quinn Tran
Regards, Quinn Tran On 3/28/14 5:12 PM, "sagi grimberg" wrote: >On 3/29/2014 2:05 AM, Quinn Tran wrote: >> Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) >> capabilities bits to let TCM core knows of HW/fabric capabilities. >> >&

Re: [PATCH 1/4] target/core: T10-Dif: check HW support capabilities

2014-03-28 Thread Quinn Tran
Answer in line. Regards, Quinn Tran On 3/28/14 5:05 PM, "sagi grimberg" wrote: >On 3/29/2014 2:05 AM, Quinn Tran wrote: >> Check lower layer/HW support of T10-dif capability. >> When the LUN is linked between the underlining fabric >> and back end device

Re: [PATCH RFC 0/4] add T10-Dif registration for tcm_qla2xxx

2014-03-28 Thread Quinn Tran
+Sagi +Martin Regards, Quinn Tran On 3/28/14 4:05 PM, "Quinn Tran" wrote: >Nicholas, > >Per our conversation at LSF, the following are the patch set >of bug fix/tweak found during T10-Dif testing and add ability >for QLogic FC driver to register with TCM its T10-P

[PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability

2014-03-28 Thread Quinn Tran
Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm) capabilities bits to let TCM core knows of HW/fabric capabilities. Signed-off-by: Nicholas Bellinger Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 23 +++ drivers/scsi/qla2xxx/tcm_q

[PATCH RFC 0/4] add T10-Dif registration for tcm_qla2xxx

2014-03-28 Thread Quinn Tran
them to target-devel and stable kernel. Quinn - Quinn Tran (4): target/core: T10-Dif: check HW support capabilities tcm_qla2xxx: T10-Dif set harware capability target/rd: T10-Dif: Add init/format support target/rd: T10-Dif: RAM disk is allocating more space than required. drivers

[PATCH 4/4] target/rd: T10-Dif: RAM disk is allocating more space than required.

2014-03-28 Thread Quinn Tran
Ram disk is allocating 8x more space than required for diff data. For large RAM disk test, there is small potential for memory starvation. Signed-off-by: Nicholas Bellinger Signed-off-by: Giridhar Malavali --- drivers/target/target_core_rd.c | 6 +- 1 file changed, 5 insertions(+), 1 deleti

[PATCH 3/4] target/rd: T10-Dif: Add init/format support

2014-03-28 Thread Quinn Tran
This patch is borrow code from commit 0f5e2ec46dd64579c0770f3822764f94db4fa465 Author: Nicholas Bellinger Date: Sat Jan 18 09:32:56 2014 + target/file: Add DIF protection init/format support This patch adds support for DIF protection init/format support into the FILEIO backend

[PATCH 1/4] target/core: T10-Dif: check HW support capabilities

2014-03-28 Thread Quinn Tran
Check lower layer/HW support of T10-dif capability. When the LUN is linked between the underlining fabric and back end device, the Protection Type(1,2,3) is check against each other to make sure both side are capable of supporting the same protection setting. ln -s /sys/kernel/config/target/core/r

Re: [PATCH 0/5] qla2xxx: NPIV target mode fixes for v3.14-rc

2014-02-20 Thread Quinn Tran
Nicholas, Will do. Thanks. Regards, Quinn Tran On 2/20/14 1:03 PM, "Nicholas A. Bellinger" wrote: >From: Nicholas Bellinger > >Hi Sawan, Quinn, & Co. > >The following series addresses a number of NPIV related bugs specific >to v3.14-rc code, mostly i

Re: [LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread Quinn Tran
Initiator implementation down to HW level. >- Discuss Current Limitations that T10-PI RDMA offload poses on iSCSI >protocol (ImmediateData, UnsolDataOut) and if/how > they can be solved. >- What-ever else comes to mind... +1 Would like to hear this discussion and see how this

Re: [PATCH] qla2xxx: Configure NPIV fc_vport via tcm_qla2xxx_npiv_make_lport

2014-01-16 Thread Quinn Tran
r FC, there is only 1 format (i.e. Association field = 1). Correct the format if you read it differently. [91:0:0:0] disk fc:naa.2111,t,0x610101 /dev/sdb Scsi name string = "naa.2111,t,0x610101" --- Regards, Quinn Tran _

Re: [PATCH] qla2xxx: Configure NPIV fc_vport via tcm_qla2xxx_npiv_make_lport

2014-01-15 Thread Quinn Tran
A2xxx generating it dynamically. Bullet 4) VPD Page 83h, SCSI name string. If you implying to use the WWPN as part of the "SCSI name string", the answer is the same as previous bullet. In this case, the setup up script would have to extract the data from configfs in order to generate t