abel and
retain reason for fall-through in comment as
requested by Michael Schmitz.
drivers/scsi/NCR5380.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 01c23d27f290..985d1c053578 100644
--- a/drivers/scsi
Christophe,
Am 30.12.2018 um 05:55 schrieb LEROY Christophe:
Michael Schmitz a écrit :
Hi Finn,
Am 29.12.2018 um 14:06 schrieb Finn Thain:
On Fri, 28 Dec 2018, LEROY Christophe wrote:
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index 89f5154c40b6..99e5729d910d
Tested-by: Christian T. Steigies
Acked-by: Michael Schmitz
---
This patch temporarily disables CONFIG_NVRAM on Atari, to prevent build
failures when bisecting the rest of this patch series. It gets enabled
again with the introduction of CONFIG_HAVE_ARCH_NVRAM_OPS, once the
nvram_* global functions
Hi Finn,
Am 29.12.2018 um 15:34 schrieb Finn Thain:
On Sat, 29 Dec 2018, Michael Schmitz wrote:
IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to suggest.
Or (really going out on a limb here):
IS_BUILTIN(CONFIG_NVRAM) ||
( IS_MODULE(CONFIG_ATARI_SCSI) && IS
Hi Finn,
Am 29.12.2018 um 14:06 schrieb Finn Thain:
On Fri, 28 Dec 2018, LEROY Christophe wrote:
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index 89f5154c40b6..99e5729d910d 100644
--- a/drivers/scsi/atari_scsi.c
+++ b/drivers/scsi/atari_scsi.c
@@ -755,9 +755,10 @@ static
Am 01.12.2018 um 09:12 schrieb Jens Axboe:
On 11/30/18 12:56 PM, Davidlohr Bueso wrote:
On Fri, 30 Nov 2018, Kees Cook wrote:
On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen
wrote:
In order to comply with the CoC, replace with a hug.
I hope this is some kind of joke. How would anyon
Gustavo,
Am 28.11.18 um 17:24 schrieb Gustavo A. R. Silva:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case, I replaced "Fall through to reject
> message"
> with a "fall through" annotation at
Am 26.11.2018 um 20:50 schrieb Christoph Hellwig:
On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote:
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
Documentation/scsi
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that
is the case.
Atari SCSI disables scatter/gather, so if that's sufficient to c
On 15/10/18 04:47, Christoph Hellwig wrote:
+ *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);
I think lp should always be non-NULL here.
That indeed appears to be the case these days.
So we can't rely on !lp to detect when probing the bus any longer. What
else would be a
ailed
command and a "DMA length is zero" error.
Fixes: 3109e5ae0311
Signed-off-by: Finn Thain
Cc: Michael Schmitz
Tested-by: Michael Schmitz
Reviewed-by: Michael Schmitz
---
drivers/scsi/zorro_esp.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/scs
+++
4 files changed, 201 insertions(+), 412 deletions(-)
For Amiga zorro-esp:
Tested-by: Michael Schmitz
Hi Finn,
Am 13.10.2018 um 17:09 schrieb Finn Thain:
On Sat, 13 Oct 2018, Michael Schmitz wrote:
Hi Finn,
Am 13.10.2018 um 13:51 schrieb Finn Thain:
Avoid function calls in the inner PIO loops. On a Centris 660av this
improves throughput for sequential read transfers by about 40% and
Hi Finn,
Am 13.10.2018 um 13:51 schrieb Finn Thain:
Avoid function calls in the inner PIO loops. On a Centris 660av this
improves throughput for sequential read transfers by about 40% and
sequential write by about 10%.
Unfortunately it is not possible to have method calls like esp_write8()
plac
Hi Martin,
thank you so much!
Ben - please drop the Amiga SCSI patch for Debian testing from kernel
version 4.18!
Cheers,
Michael
Am 19.04.2018 um 16:01 schrieb Martin K. Petersen:
>
> Michael,
>
>> Anything else needed for linux-scsi?
>
> Applied to 4.18/scsi-queue. Thanks!
>
Thanks guys!
Anything else needed for linux-scsi?
Cheers,
Michael
On Mon, Apr 16, 2018 at 10:34 PM, John Paul Adrian Glaubitz
wrote:
> On 04/16/2018 11:26 AM, Christian T. Steigies wrote:
>>
>> On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote:
>>>
&
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
Hi Geert,
On Wed, Apr 11, 2018 at 8:56 PM, Geert Uytterhoeven
wrote:
> Hi Michael,
>
> On Wed, Apr 11, 2018 at 10:36 AM, Michael Schmitz
> wrote:
>> From: Michael Schmitz
>>
>> New combined SCSI driver for all ESP based Zorro SCSI boards for
>> m68k A
Hi Geert, Christoph,
Am 11.04.2018 um 20:30 schrieb Geert Uytterhoeven:
> Hi Christoph,
>
> On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig
> wrote:
>> On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote:
That would be cool. Would that still be in time for the 4.17 merge
Hi Geert,
Am 11.04.2018 um 18:51 schrieb Geert Uytterhoeven:
> Hi Michael,
>
> On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz
> wrote:
>>>> Short of a complete rewrite of the Zorro driver support code to be
>>>> closer to what PCI does, I don&#x
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
Michael
On Tue, Apr 10, 2018 at 8:18 PM, Geert Uytterhoeven
wrote:
> Hi Michael,
>
> On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz wrote:
>> On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig wrote:
>>> On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote
ael
On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig wrote:
> On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote:
>> New combined SCSI driver for all ESP based Zorro SCSI boards for
>> m68k Amiga.
>>
>> Code largely based on board specific pa
ute kernel virtual address esp->cmd_block in PIO transfer call if
DMA address is esp->cmd_block_dma and phase is message in.
PIO code taken from mac_esp.c where the reselection timeout issue was
debugged and fixed first, with minor macro and function rename.
Signed-off-by: Michael Schmitz
Re
Hi Finn,
Am 07.04.2018 um 22:19 schrieb Finn Thain:
> On Sat, 7 Apr 2018, Michael Schmitz wrote:
>
>>>
>>> CHECK /home/fthain/src/kernel.org/linux/drivers/scsi/zorro_esp.c
>>> drivers/scsi/zorro_esp.c:274:14: warning: cast removes address space of
>>&g
Hi Finn,
Am 07.04.2018 um 12:59 schrieb Finn Thain:
> On Sat, 7 Apr 2018, Michael Schmitz wrote:
>
>> Changes since v5:
>>
>> Christoph Hellwig:
>>
>> - fix comment style
>> - drop initialization to zero in driver data init
>> - fix alignment in
ute kernel virtual address esp->cmd_block in PIO transfer call if
DMA address is esp->cmd_block_dma and phase is message in.
PIO code taken from mac_esp.c where the reselection timeout issue was
debugged and fixed first, with minor macro and function rename.
Signed-off-by: Michael Schmitz
Re
Hi Christoph,
thank you for taking the time to review and comment - my responses
inline below.
Am 03.04.2018 um 19:45 schrieb Christoph Hellwig:
> Just a few style comments:
>
>> +static int zorro_esp_irq_pending(struct esp *);
>> +static int cyber_esp_irq_pending(struct esp *);
>> +static int f
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
Hi Kars,
thanks, I've fixed that typo.
Cheers,
Michael
Am 19.03.2018 um 03:51 schrieb Kars de Jong:
> Hi Michael,
>
> 2018-03-17 2:16 GMT+01:00 Michael Schmitz :
>> From: Michael Schmitz
>>
>> New combined SCSI driver for all ESP based Zorro SCSI boar
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
in:
> On Wed, 14 Mar 2018, Michael Schmitz wrote:
>
>>> Please pass "addr" and "fifo" as macro parameters, too, so it's easier
>>> for the reviewer to notice they are used.
>> Yes, I can do that (meaning Finn would need to make the same change to
Hi Geert,
Am 14.03.2018 um 21:30 schrieb Geert Uytterhoeven:
> Hi Michael,
>
> On Wed, Mar 14, 2018 at 9:23 AM, Michael Schmitz wrote:
>> thanks for the review - largely uncontroversial except for the volatile...
>
> The presence of volatile in drivers is always con
; -Tuomas
>
> From: linux-m68k-ow...@vger.kernel.org on
> behalf of Michael Schmitz
> Sent: 12 March 2018 09:26:40
> To: linux-scsi@vger.kernel.org
> Cc: linux-m...@vger.kernel.org; da...@davemloft.net; ge...@linux-m68k.org;
> fth...@telegr
Hi Geert,
thanks for the review - largely uncontroversial except for the volatile...
Am 14.03.2018 um 20:49 schrieb Geert Uytterhoeven:
>> +/* Blizzard 1230 DMA interface */
>> +
>> +struct blz1230_dma_registers {
>> + volatile unsigned char dma_addr;/* DMA address [0x]
>>
Hi Finn,
Am 12.03.2018 um 22:04 schrieb Finn Thain:
>> +if (addr == esp->command_block_dma)
>> +addr = (u32) esp->command_block;
>
> Since you've removed the alternative branch and phys_to_virt(), I suggest
> you do this at function invocation... (see below)
Keeps it together w
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
Hi Finn, Geert,
> + /* We are passed DMA addresses i.e. physical addresses, but must
> use
> +* kernel virtual addresses here, so remap to virtual. This is
> easy
> +* enough for the case of residual bytes of an extended message in
> +* trans
Tuomas,
Am 06.03.2018 um 04:31 schrieb Tuomas Vainikka:
>>> I think you are talking about esp->regs? For esp->dma_regs, the
>>> ioremap is
>>> conditional on ent->id, but the unmap is not.
>> The details of the ioremap are conditional on the ID, but the fact
>> that the ioremap happens (and hence
Hi Geert,
fine, I'll rely on the base address and the z->rom.er_Type value to
pick the correct config data.
Cheers,
Michael
On Wed, Mar 7, 2018 at 9:06 PM, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Wed, Mar 7, 2018 at 8:55 AM, Michael Schmitz wrote:
>> OK, in
iable
to distinguish between Zorro II and Zorro III boards?
Cheers,
Michael
Am 06.03.2018 um 20:43 schrieb Geert Uytterhoeven:
> Hi Michael,
>
> On Tue, Mar 6, 2018 at 2:11 AM, Michael Schmitz wrote:
>> Index 1 should have been ZORRO_PROD_PHASE5_CYBERSTORM_MK_II, I've
Hi Finn,
Am 07.03.2018 um 13:54 schrieb Finn Thain:
> On Wed, 7 Mar 2018, Michael Schmitz wrote:
>
>> The major obstacle now seems to be dynamic allocation of the driver
>> private data and storing a pointer to that in a way that it can be
>> retrieved us
Hi Geert,
On Tue, Mar 6, 2018 at 8:48 PM, Geert Uytterhoeven wrote:
> BTW, please call the probe/remove functions zorro_esp_probe() resp.
> zorro_esp_remove().
Fair enough.
+ if (!host) {
+ pr_err(PFX "No host detected; board configuration
problem?\n");
onents/ncr/scsi/53CF94_96-2_Fast_SCSI_Controller_Data_Manual_Apr1993.pdf
Cheers,
Michael
On Tue, Mar 6, 2018 at 9:37 PM, Finn Thain wrote:
> On Tue, 6 Mar 2018, Michael Schmitz wrote:
>
>> The whole !write branch will never be executed, and I could just omit it
>> entirely
Hi Finn,
Am 06.03.2018 um 16:04 schrieb Finn Thain:
> On Tue, 6 Mar 2018, Michael Schmitz wrote:
>
>>>> +static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32
>>>> esp_count,
>>>> +u32 dma_count, int
Hi Geert,
thanks, will comment on a few points that were not already raised by Finn below.
On Tue, Mar 6, 2018 at 12:29 AM, Geert Uytterhoeven
wrote:
>> +static struct zorro_driver_data {
>> + const char *name;
>> + unsigned long offset;
>> + unsigned long dma_offset;
>> +
erent driver_data
contents?
Cheers,
Michael
On Mon, Mar 5, 2018 at 9:02 PM, Kars de Jong wrote:
> 2018-03-04 0:54 GMT+01:00 Michael Schmitz :
>> +static struct zorro_device_id zorro_esp_zorro_tbl[] = {
>> + {
>> + .id = ZORRO_PROD_PHASE
Hi Finn,
On Mon, Mar 5, 2018 at 2:01 PM, Finn Thain wrote:
> On Mon, 5 Mar 2018, Michael Schmitz wrote:
>
>> >> +fail_unmap_dma_regs:
>> >> + if (ioaddr > 0xff)
>> >> + iounmap(esp->dma_regs);
>> >
>> > I think
Hi Finn,
>> >> +#define ZORRO_ESP_GET_PRIV(esp) ((struct zorro_esp_priv *) \
>> >> + &zorro_esp_private_data[(esp->host->host_no)])
>> >> +
>> >
>> > How do you know that host_no won't exceed the array bounds?
>> > Why not use dev_{set,get}_drvdata(esp->dev)? -- much as ma
Hi Finn,
>> +/* zorro_esp.c: ESP front-end for Amiga ZORRO SCSI systems.
>> + *
>> + * Copyright (C) 1996 Jesper Skov (js...@cygnus.co.uk)
>> + *
>> + * Copyright (C) 2011,2018 Michael Schmitz (schm...@debian.org) for
>> + * migration to ESP SCS
Hi Finn,
thanks for your review!
Am 04.03.2018 um 15:55 schrieb Finn Thain:
> On Sun, 4 Mar 2018, Michael Schmitz wrote:
>
>> From: Michael Schmitz
>>
>> New combined SCSI driver for all ESP based Zorro SCSI boards for
>> m68k Amiga.
>>
>
> Nice wor
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed
after the 2.6 kernel series for lack of maintenance
From: Michael Schmitz
Add Kconfig option and Makefile entries for new Amiga Zorro ESP SCSI
driver (combining old blz1230, blz2060, cyberstorm and fastlane
SCSI drivers that were removed for lack of maintenance after 2.6)
Signed-off-by: Michael Schmitz
---
drivers/scsi/Kconfig | 16
At long last, revive the driver for m68k Amiga Zorro boards based on
the Qlogic ESP SCSI chip, which were in-tree as separate drivers
(blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c) until
the rewrite of the ESP core code after 2.6.x.
A previous rewrite of the Zorro ESP SCSI driver
Ondrej,
could this be a partial write (target did not transfer the last byte)?
One would suppose the chip posts a phase mismatch in that case ...
Cheers,
Michael
Am 27.06.2017 um 18:28 schrieb Ondrej Zary:
> On Monday 26 June 2017, Ondrej Zary wrote:
>> On Monday 26 June 2017 09:30:33
Hi Christian
Am 06.06.2017 um 07:17 schrieb Christian T. Steigies:
> On Mon, Jun 05, 2017 at 07:37:59PM +1200, Michael Schmitz wrote:
>> m68k_num_memory is unsuitable to test for the presence of FastRAM
>> on CT60 if the kernel is located in FastRAM: in arch/m68k/mm/motorola.c
>
.
Tested by Christian Steiges on his Falcon with kernel loaded in FastRAM
- could you please reply with your Tested-by tag, Christian?
Signed-off-by: Michael Schmitz
---
drivers/scsi/atari_scsi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/atari_scsi.c b
Martin,
looks good to me, so:
Reviewed-By: Michael Schmitz
Am 25.04.2017 um 10:29 schrieb Martin K. Petersen:
>
> Finn,
>
>> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips")
>> added mac_scsi_esp_intr() to handle the IRQ lines from
Hi Martin,
I must have missed that one - where was it posted to?
Cheers,
Michael
Am 25.04.2017 um 10:29 schrieb Martin K. Petersen:
>
> Finn,
>
>> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips")
>> added mac_scsi_esp_intr() to handle the IRQ lines from a pa
been tested as well.
No change in the weird behaviour of my SCSI-SATA adapter, but perhaps
that wasn't unexpected.
Targets: Disks Seagate ST34520W and IBM DORS-32160W, CD-ROM Plextor PX-40TS.
Tested-by: Michael Schmitz
>
>
> Finn Thain (6):
> ncr5380: Shorten host info str
Martin, Finn,
I'll get to that on the weekend - Auckland Anniversary Day coming up so
plenty of time.
Cheers,
Michael
Am 26.01.2017 um 12:25 schrieb Martin K. Petersen:
>> "Finn" == Finn Thain writes:
>
> Finn> Michael, Ondrej, can I get you to review/test please?
>
> Pretty plea
Hi Finn,
Am 01.11.2016 um 12:47 schrieb Finn Thain:
>
> On Tue, 1 Nov 2016, Michael Schmitz wrote:
>
>>> I had tried to set that bit in zorro_esp_slave_configure but had not
>>> done a proper job of it - I'd only set esp->config3 and forgot to set
>&
Hi Finn,
> I had tried to set that bit in zorro_esp_slave_configure but had not
> done a proper job of it - I'd only set esp->config3 and forgot to set
> tp->esp_config3. Time to retest this ...
I don't think it's quite that easy - the ESP_CONFIG3_TENB bit needs to
be set for all targets if at le
Hi Finn,
Am 30.10.2016 um 15:33 schrieb Finn Thain:
>
> On Sat, 29 Oct 2016, I wrote:
>
>>
>> On Sun, 13 Apr 2014, David Miller wrote:
>>
>>>
>>> But oddly in the NCR53CX docs:
>>>
>>>
>>> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
>>>
>>> it speaks as if E
t; scsi/ncr5380: Expedite register polling
> scsi/ncr5380: Use correct types for DMA routines
> scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message
Tested on Atari SCSI (Falcon) - no regressions.
Tested-by: Michael Schmitz
--
To unsubscribe from this list: sen
Christoph,
I test the atari_scsi front end - haven't got any ISA cards handy.
Probably no ISA slots on my PC main board either ...
Cheers,
Michael
Am 12.09.2016 um 05:12 schrieb Christoph Hellwig:
> Hi all,
>
> you seem to the currently active NCR580 cabal. Which frontends to NCR5380
Finn,
tested successfully on Atari Falcon, so:
Tested-by: Michael Schmitz
Am 14.03.2016 um 17:27 schrieb Finn Thain:
> This patch series has more macro elimination and some tweaks to the
> DMA hooks so that all the wrapper drivers can share the same core
> DMA algorithm. This res
Hi Geert,
On Mon, Jan 25, 2016 at 9:05 PM, Geert Uytterhoeven
wrote:
>>> Perhaps this is an ARAnyM quirk?
>
>> The MR_ARBITRATE bit should remain set until the driver clears it (or the
>> reset logic clears it). But it looks like aranym simply discards writes to
>> the mode register, such that r
Hi Finn,
I've tested this series thoroughly on my Atari Falcon - no regressions,
runs stable and is quite responsive. No SCSI lock-ups that had plagued
the old driver (before your rewrites).
Please add my
Tested-by: Michael Schmitz
Cheers,
Michael
Am 22.12.15 um 14:17 schrieb
I'd like to think that, too - probably true for the Atari TT SCSI case
(can do scatter-gather, can do more than one command per LUN). Worse
for the Falcon SCSI which is the only one I can test (no
scatter-gather, one command per LUN, interrupt shared with IDE and IDE
driver locked out while SCSI co
Hi Finn,
Am 19.11.2015 um 17:05 schrieb Finn Thain:
> w
> On Thu, 19 Nov 2015, Michael Schmitz wrote:
>
>> Hi Finn,
>>
>> Am 18.11.2015 um 21:35 schrieb Finn Thain:
>>
>>> The bus reset may raise an interrupt. That would be new behaviour for
>>>
Hi Finn,
Am 18.11.2015 um 21:35 schrieb Finn Thain:
> The bus reset may raise an interrupt. That would be new behaviour for
> atari_scsi only when CONFIG_ATARI_SCSI_RESET_BOOT=n. The ST DMA interrupt
> is not assigned to atari_scsi at this stage, so
> CONFIG_ATARI_SCSI_RESET_BOOT=y may well be pr
Hi Finn,
>>>
>>> I have compile-tested all patches to all NCR5380 drivers (x86, ARM,
>>> m68k) and regression tested mac_scsi and dmx3191d modules on suitable
>>> hardware. Testing the mac_scsi and dmx3191d modules provides only
>>> limited coverage. It would be good to see some testing of ISA
count to the ms * HZ / 1000 form was
overlooked.
As no change to the original (i,e. 1997 vintage) driver behaviour is
introduced, I don't think further testing is required.
Acked-by: Michael Schmitz
On 05/02/15 07:30, Nicholas Mc Guire wrote:
> Instances of var * HZ / 1000 are rep
Hi Nicholas,
>> The values for USLEEP_* are taken to be in units jiffies, according to
>> comments in NCR5380.c. Replacing them by the msecs_to_jiffies conversion
>> is in fact wrong.
>>
>> Please drop the changes to g_NCR5380.c for that reason.
>>
>
> right the comment indicates it should be jiff
Finn, Nicholas,
On Sat, 31 Jan 2015, Nicholas Mc Guire wrote:
This is only an API consolidation to make things more readable.
Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var).
... and some instances of "value" are replaced by
"msecs_to_jiffies(value)"
which seems to b
Finn,
Index: linux/drivers/scsi/atari_NCR5380.c
===
--- linux.orig/drivers/scsi/atari_NCR5380.c 2014-10-27 16:25:36.0
+1100
+++ linux/drivers/scsi/atari_NCR5380.c 2014-10-27 16:25:45.0
+1100
@@ -879,10 +879,10
stdma_others_waiting( void );
int stdma_islocked( void );
-void *stdma_locked_by( void );
+int stdma_is_locked_by(irq_handler_t);
void stdma_init( void );
/* End of Prototypes ******/
Acked-by: Michael Schmitz
Index: linux/d
Hi Finn,
>> Leaves the current instability - I did some work on the CT60 accelerator
>> (reflashed the firmware so I can use the CTPCI board). This might have
>> caused the system to become more unstable. Needs more investigation.
>
> I gather from the emails we've exchanged that the "current" ins
David, Geert,
my Falcon has some variant of this clock patch installed - it may not
be precisely the one described but reasonably close. It also has one
of the old 030 accelerator tricks (clock doubling of the 030 if the
CPU does not do bus cycles - named Skunk) fitted; the clock patch was
install
Hi Finn,
> Thanks for testing.
>
> "No regressions over v1" means "no regressions", right?
>
>
>
> Well, what would I compare the driver performance to? With your patches to
> sort out locking races, the driver is more stable than I've ever seen it in
> years. That's a definite win. Big improveme
sting on Sun 3, Atari ST and/or Atari TT would be nice
(I don't have the hardware).
Tested atari_scsi on Falcon / CT60 hardware - no regressions over v1
that I've seen.
Tested-by: Michael Schmitz
There are old bugs relating to exception handling and autosense in the
core NCR5380 d
Finn,
On Mon, 20 Oct 2014, Michael Schmitz wrote:
Hi Finn,
not certain it is related to this exact patch - the driver crashes
pretty much on the spot when selecting the first target on the bus.
If it isn't that exact patch then it will probably be one of the other
atari
Hi Finn,
>> not certain it is related to this exact patch - the driver crashes
>> pretty much on the spot when selecting the first target on the bus.
>
> If it isn't that exact patch then it will probably be one of the other
> atari_scsi patches. Most of the other relevant stuff was covered by my
Hi Finn,
not certain it is related to this exact patch - the driver crashes
pretty much on the spot when selecting the first target on the bus.
Panic log:
Atari SCSI: resetting the SCSI bus... done
scsi host0: Atari native SCSI, io_port 0x0, n_io_port 0, base 0x0, irq
0, can_queue 8, cmd_per_
Hi Finn,
Can these be handled through the platform_device's resources?
I don't know.
Should be possible - I've seen that used in the ISP116x HCD driver
(arch-dependent post-register access delay function passed via platform
data).
Yes, possible, but is it desir
Finn,
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
+ if (ATARIHW_PRESENT(TT_SCSI)) {
+ atari_scsi_reg_read = atari_scsi_tt_reg_read;
+ atari_scsi_reg_write = atari_scsi_tt_reg_write;
+ } else if (ATARIHW_PRESENT(ST_SCSI)) {
+ atari_scsi
Hi Geert,
> [sorry for the long delay]
Tell me about it :-) I haven't had a good idea how to address this
problem so rather kept mum about it.
> On Mon, Apr 14, 2014 at 10:51 AM, Michael Schmitz
> wrote:
>> Not sure my patch had ever made it into Geert's m68k-queue
Acked-by: Michael Schmitz
On Mon, May 5, 2014 at 5:35 PM, Finn Thain wrote:
>
> Signed-off-by: Finn Thain
> Cc: Michael Schmitz
>
> ---
>
> As requested:
> http://marc.info/?l=linux-arm-kernel&m=139853302724112&w=2
>
> diff --git a/MAINTAINERS b/MAINT
Finn Thain for the Sun3 part
and cleaning up the header files. After the header cleanup, the
initio.h include (!) can be dropped from sun3_scsi.h now.
Signed-off-by: Michael Schmitz
Signed-off-by: Finn Thain
Acked-by: Sam Creasey
Cc: Geert Uytterhoeven
Cc: James E.J. Bottomley
Cc: linux-scsi
Hi James,
Perhaps Michael and Sam would be interested in sharing the role, for atari
and sun3 NCR5380 drivers (?)
If you insist ...
(kidding - I"m OK with it if James thinks it's worth it)
As long as you understand how it works and how to fix it, the more the
merrier. It gives me more people
Finn,
On Tue, Apr 29, 2014 at 2:22 PM, Finn Thain wrote:
>
> On Sat, 26 Apr 2014, James Bottomley wrote:
>
>> OK, so this is a pretty big change to an unmaintained driver. I'll take
>> it if you're willing to maintain the driver afterwards ... in which case
>> I need another patch to add you to
Acked-by: MIchael Schmitz
Remove the unused (and divergent) debugging macro definitions from
the sun3_NCR5380 and atari_NCR5380 drivers. These drivers have been
converted to use the common macros in NCR5380.h.
Signed-off-by: Finn Thain
---
drivers/scsi/atari_scsi.h | 93
Acked-by: Michael Schmitz
All NCR5380 drivers already include the NCR5380.h header. Better to
adopt those macros rather than have three variations on them.
Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380
and sun3_NCR5380 versions are inflexible. For example, they
Acked-by: Michael Schmitz
All NCR5380 drivers already include the NCR5380.h header. Better to
adopt those macros rather than have three variations on them.
Moreover, the macros in NCR5380.h are preferable anyway: the atari_NCR5380
and sun3_NCR5380 versions are inflexible. For example, they
ter.
This should allow proper recognition of 3 byte reselection
on all esp100a and later chips.
Reported-by: Kars de Jong
Reported-by: Michael Schmitz
Signed-off-by: David S. Miller
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 55548dc..16f69e0 100644
--- a/drivers/scsi/
reselection
on all esp100a and later chips.
Reported-by: Kars de Jong
Reported-by: Michael Schmitz
Signed-off-by: David S. Miller
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 55548dc..16f69e0 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -2160,7
Hi Kars,
thanks for the PDFs!
> Bit 2 SCSI-2
>
> Setting this bit allows the FSC to support two new features adopted in
> SCSI-2: the 3-byte message exchange for Tagged-Queueing and Group 2
> commands. These features can also be set independently in the Config 3
> register.
>
> Tagged-Queueing
>
Hello Kars,
>> > I've never seen a formula for any ESP or FAS chip for the timeout
>> > other than the one mentioned in huge comment in
>> > esp_set_clock_params(), although I do see the 7668 instead of 8192
>> > factor being used in the old NCR53C9x driver.
>>
>> I haven't gone far enough back i
Hello Dave, Tuomas,
>> Also, looking at the timeout formulae in the old NCR53C9x.c driver,
>> the values would be different for FAS216. Why was this dropped from
>> the modern esp_scsi?
>
> I've never seen a formula for any ESP or FAS chip for the timeout
> other than the one mentioned in huge com
1 - 100 of 118 matches
Mail list logo
