-rc5.
Thanks,
Himanshu
Himanshu Madhani (1):
qla2xxx: Initialized mailbox to prevent driver load failure
Quinn Tran (1):
qla2xxx: Fix partial flash write of MBI
drivers/scsi/qla2xxx/qla_attr.c | 7 +++
drivers/scsi/qla2xxx/qla_mbx.c | 3 ++-
2 files changed, 5 insertions(+), 5 deletions
mb[0]=4005
mb[1]=37 mb[2]=20 mb[3]=8
[ 18.819596] cmd=2
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_mbx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 1cc6913f76c4
mit FLASH region write access
from SysFS")
Cc: sta...@vger.kernel.org # 5.2
Signed-off-by: Quinn Tran
Signed-off-by: Girish Basrur
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xx
Update maintainer's entries for qla2xxx driver now that
email addresses have been changed to Marvell.
Signed-off-by: Himanshu Madhani
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 783569e3c4b4..91f33522393a 100644
Hi Martin,
On 9/13/19, 5:37 PM, "Martin K. Petersen" wrote:
External Email
--
Hi Martin,
> I believe this patch should be tagged with
>
> Fixes: 5fa8774c7f38 (scsi: qla2xxx: Add 28xx fla
Hello Dr Greg,
On 9/16/19, 10:36 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Dr. G.W.
Wettstein" wrote:
On Sep 4, 3:03pm, Himanshu Madhani wrote:
} Subject: Re: [EXT] SRR response handling.
> Adding correct Quinn and removing qlogic.com email ID.
From: Quinn Tran
For MPI heartbeat stop Async Event, this patch would capture
MPI FW dump and chip reset. FW will tell which function to
capture FW dump for.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 4 +++-
drivers/scsi/qla2xxx
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index a8f2a953ceff..225e401b62fa 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
From: Quinn Tran
Add mailbox timeout checkout for ISP 27xx/28xx during FW dump
procedure. Without the timeout check, hardware lock can
be held for long period. This patch would shorten the dump
procedure, if a timeout condition is encountered.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_iocb.c | 95 +++--
1 file changed, 92 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 518eb954cf42..eeb526411536 100644
--- a/drivers
ff-by: Michael Hernandez
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 26 ++--
drivers/scsi/qla2xxx/qla_fw.h | 2 ++
drivers/scsi/qla2xxx/qla_gs.c | 42 ++---
drivers/scsi/qla2xxx/qla_init.c
move messages to verbose logging for scan thread
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 5b5ac09f38db
From: Quinn Tran
During driver unload, the remove flag will be set for all
scsi_qla_host/NPIV. This allows each NPIV to see the flag
instead of reaching for base_vha to search for it.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 30
From: Quinn Tran
For N2N, the NPort ID is assigned by driver in the PLOGI ELS.
According to FW Spec the byte order for SID is not the same as
DID.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_iocb.c | 7 ---
1 file changed, 4 insertions(+), 3
From: Quinn Tran
On driver unload, 'remove_one' thread was allow to
advance, while session cleanup still lag behind.
This patch ensure session deletion will finish before
remove_one can advance.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xx
From: Quinn Tran
There are instances, though rare, where a LOGO request
cannot be sent out and the thread in free session done
can wait indefinitely. Fix this by putting an upper
bound to sleep.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c
From: Quinn Tran
Fix stalled link recovery for N2N with FC-NVMe connection
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 3 +-
drivers/scsi/qla2xxx/qla_init.c | 107 +---
drivers/scsi/qla2xxx/qla_mbx.c
From: Quinn Tran
During link up/bounce, qla driver would do command flush as
part of cleanup. In this case, the flush can intefere with FW state.
This patch allows FW to be in control of link up.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_mbx.c
s series. Please hold off on merging that series until review is
complete.
changes from v1 -> v2
o Rebased series on updated 5.4/queue branch
Thanks,
Himanshu
Himanshu Madhani (3):
qla2xxx: Silence fwdump template message
qla2xxx: Improve logging for scan thread
qla2xxx: Update dri
From: Quinn Tran
In the case of NPIV port is being torn down, this patch will
set a flag to indicate VPORT_DELETE. This would prevent relogin
to be triggered.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 2 ++
drivers/scsi/qla2xxx
Print fwdt template is present or not, only
when ql2xextended_error_logging is enabled.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index
rnal Email
--
On Thu, Sep 12, 2019 at 08:19:42AM -0700, Himanshu Madhani wrote:
> From: Quinn Tran
>
> For N2N, the NPort ID is assigned by driver in the PLOGI ELS.
> According to FW Spec the byte order for
From: Quinn Tran
During driver unload, the remove flag will be set for all
scsi_qla_host/NPIV. This allows each NPIV to see the flag
instead of reaching for base_vha to search for it.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 30
From: Quinn Tran
For MPI heartbeat stop Async Event, this patch would capture
MPI FW dump and chip reset. FW will tell which function to
capture FW dump for.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 4 +++-
drivers/scsi/qla2xxx
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index a8f2a953ceff..225e401b62fa 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_iocb.c | 95 +++--
1 file changed, 92 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 5c279449ca1c..840c3bf2a364 100644
--- a/drivers
ff-by: Michael Hernandez
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 26 ++--
drivers/scsi/qla2xxx/qla_fw.h | 2 ++
drivers/scsi/qla2xxx/qla_gs.c | 42 ++---
drivers/scsi/qla2xxx/qla_init.c
move messages to verbose logging for scan thread
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index ad7f02a8f6d7
From: Quinn Tran
Add mailbox timeout checkout for ISP 27xx/28xx during FW dump
procedure. Without the timeout check, hardware lock can
be held for long period. This patch would shorten the dump
procedure, if a timeout condition is encountered.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu
From: Quinn Tran
In the case of NPIV port is being torn down, this patch will
set a flag to indicate VPORT_DELETE. This would prevent relogin
to be triggered.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 2 ++
drivers/scsi/qla2xxx
Print fwdt template is present or not, only
when ql2xextended_error_logging is enabled.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index
From: Quinn Tran
Fix stalled link recovery for N2N with FC-NVMe connection
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 3 +-
drivers/scsi/qla2xxx/qla_init.c | 107 +---
drivers/scsi/qla2xxx/qla_mbx.c
From: Quinn Tran
For N2N, the NPort ID is assigned by driver in the PLOGI ELS.
According to FW Spec the byte order for SID is not the same as
DID.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_iocb.c | 7 ---
1 file changed, 4 insertions(+), 3
From: Quinn Tran
During link up/bounce, qla driver would do command flush as
part of cleanup. In this case, the flush can intefere with FW state.
This patch allows FW to be in control of link up.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_mbx.c
From: Quinn Tran
On driver unload, 'remove_one' thread was allow to
advance, while session cleanup still lag behind.
This patch ensure session deletion will finish before
remove_one can advance.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xx
From: Quinn Tran
There are instances, though rare, where a LOGO request
cannot be sent out and the thread in free session done
can wait indefinitely. Fix this by putting an upper
bound to sleep.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c
s series. Please hold off on merging that series until review is
complete.
Thanks,
Himanshu
Himanshu Madhani (3):
qla2xxx: Silence fwdump template message
qla2xxx: Improve logging for scan thread
qla2xxx: Update driver version to 10.01.00.20-k
Michael Hernandez (1):
qla2xxx: Dual
Adding Correct Quinn. Please use "qut...@mavell.com"
We'll take a look at the series
On 9/12/19, 8:49 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Roman
Bolshakov" wrote:
On Thu, Sep 12, 2019 at 06:37:22AM +0100, Bart Van Assche wrote:
> On 9/12/19 1:39 AM, Roman Bolshakov wrote
Adding correct Quinn and removing qlogic.com email ID.
It's nice to hear from you Dr Greg __
We will look at the request and get back to you.
Thanks,
Himanshu
On 9/3/19, 3:39 PM, "Dr. G.W. Wettstein" wrote:
External Email
--
port.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 03f94eb372b6..dc0e36676313 100644
--- a/drivers/scsi
relogin.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 8161f08f3a4d..2bbadcf60295
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 0833546a1b43..a8f2a953ceff 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
HINT_MBX_INT_PENDING is not guaranteed to be cleared by
firmware. Remove check that prevent driver load with ISP82XX.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_mbx.c | 16 ++--
drivers/scsi/qla2xxx/qla_nx.c | 3 ++-
2 files changed, 4
From: Quinn Tran
Use adapter specific callback to read flash instead of ISP
adapter specific.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
drivers/scsi/qla2xxx/qla_nx.c | 1 +
drivers/scsi/qla2xxx/qla_sup.c | 8
3 files
allocated vectors. This is normal and
does not imply failure in driver.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index d81b5ecce24b
Hi Martin,
This series has few bug fixes for the driver.
Please apply this series to 5.4/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Himanshu Madhani (3):
qla2xxx: Fix message indicating vectors used by driver
qla2xxx: Fix driver reload for ISP82xx
qla2xxx: Update driver
series and did not see this
issue.
Tested-by: Himanshu Madhani
Reviewed-by: Himanshu Madhani
Thanks,
Himanshu
On 8/14/19, 10:25 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van
Assche"
wrote:
On 7/24/19 10:46 PM, Wang Xiayang wrote:
> As commit a86028f8e3ee ("staging: most: sound: replace snprintf
> with strscpy") suggested, using snprintf without a format specifier
> is p
e_host(struct
scsi_host_template *sht,
"Alloc failed for scan database.\n");
dma_free_coherent(&ha->pdev->dev, vha->gnl.size,
vha->gnl.l, vha->gnl.ldma);
+ vha->gnl.l = NULL;
scsi_remove_host(vha->host);
return NULL;
}
--
1.8.3.1
Thanks for resend Bill
Patch Looks Good.
Acked-by: Himanshu Madhani
>
> > Fixes: ad0a0b01f088 "scsi: qla2xxx: Fix Firmware dump size for
> > Extended
> > login and Exchange Offload"
> > Fixes: a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump
> > templates/segments"
>
quot;, str);
--
2.11.0
Looks Good.
Acked-by: Himanshu Madhani
e_host(struct
scsi_host_template *sht,
"Alloc failed for scan database.\n");
dma_free_coherent(&ha->pdev->dev, vha->gnl.size,
vha->gnl.l, vha->gnl.ldma);
+ vha->gnl.l = NULL;
scsi_remove_host(vha->host);
return NULL;
}
--
1.8.3.1
Looks Good.
Acked-by: Himanshu Madhani
--
2.22.0
Thanks for posting v2 of the series.
For the series,
Tested-by: Himanshu Madhani
Reviewed-by: Himanshu Madhani
Hi Bart,
> On Aug 1, 2019, at 12:55 PM, Bart Van Assche wrote:
>
> Hi Martin,
>
> The patches in this series improve the robustness of the QLogic Fibre Channel
> initiator and target drivers. These patches are a result of manual code
> inspection, analysis of Coverity reports and stress testi
Hi Bart,
> On Aug 1, 2019, at 12:55 PM, Bart Van Assche wrote:
>
> Hi Martin,
>
> The patches in this series improve the robustness of the QLogic Fibre Channel
> initiator and target drivers. These patches are a result of manual code
> inspection, analysis of Coverity reports and stress testi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index cd6bdf71e533..0833546a1b43 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
a2xxx]
#5 [8e2370297e20] process_one_work at b48bcfdf
#6 [8e2370297e68] worker_thread at b48bdca6
#7 [8e2370297ec8] kthread at b48c4f81
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 3 ---
1 file changed, 3 deletions(-)
di
allows IO to resume afterward.
Signed-off-by: Arun Easi
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index
From: Andrew Vasquez
Leverage the generic routine, qla24xx_update_fw_options(), for the
configuration of firmware options for ISP27xx/ISP28xx.
Signed-off-by: Andrew Vasquez
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Quinn Tran
For target mode, the default number of Q-Pairs allowed
to use is 2. If the number of Q-Pair allocated is
lower than the default Q-Pairs, then lower value should
be the set as default.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx
From: Quinn Tran
Firmware dump captured during LOOP Init error does not yield
any significant information. This patch removes call to
trigger firmware dump collection during Loop Initialization.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 1
From: Quinn Tran
Reject eh_{abort|device_reset|target_reset}, when rport is
being torn down or chip is down.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_os.c
1|2 login 1|2 fl 1
qla2xxx [:41:00.0]-28e9:3: qla24xx_handle_relogin_event 1666
21:00:00:24:ff:17:9e:91 post gidpn
qla2xxx [:41:00.0]-480e:3: Relogin end.
--8<--
Signed-off-by: Arun Easi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
1 file changed, 2 inser
From: Quinn Tran
when fabric scan thread encounters IOCB Q Full, schedule
a delayed work to retry fabric scan.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff
18 [99652fc03ff0] apic_timer_interrupt at 96575df2
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_iocb.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_
initialization.
- Release SCSI host reference when memory allocations fail.
Signed-off-by: Andrew Vasquez
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 4
drivers/scsi/qla2xxx/qla_os.c | 16 ++--
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a
ned-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 25 -
drivers/scsi/qla2xxx/qla_os.c | 1 +
drivers/scsi/qla2xxx/qla_target.c | 1 -
3 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/qla2xxx/ql
From: Quinn Tran
If an abort times out, the Abort IOCB completion and Abort
timer can race against each other. This patch provides
unique error code for timer path to allow proper cleanup
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1
: Fix inconsistent DMA mem alloc/free")
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 9f58e591666d..ebf223cfe
]
[28809.523964] One of leaked entries details: [device
address=0x0002aefe4000] [size=8208 bytes] [mapped with DMA_BIDIRECTIONAL]
[mapped as coherent]
Fix this by unmapping DMA memory.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_bsg.c | 4
1 file changed
initialization failures
qla2xxx: Use common update-firmware-options routine for ISP27xx+
Arun Easi (1):
qla2xxx: Fix failed NVME port discovery after a short device port loss
Himanshu Madhani (2):
qla2xxx: Fix DMA unmap leak
qla2xxx: Update driver version to 10.01.00.18-k
Quinn Tran (10):
qla2xxx
rt_work [qla2xxx]
[ 5631.004097] RIP: 0010:[] []
qla_nvme_abort_work+0x22/0x100 [qla2xxx]
[ 5631.004109] Call Trace:
[ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0
[ 5631.004117] [] process_one_work+0x17f/0x440
[ 5631.004120] [] worker_thread+0x126/0x3c0
Signed-off-by: Quinn Tran
Signed-off-by: H
From: Quinn Tran
- on session delete or chip reset, reject all NVME commands.
- on NVME command submission error, free srb resource.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 28 +++-
1 file changed, 19 insertions
protected, and when a remoteport_delete callback is called, driver
traverses the list and crashes.
Actually, the list could be removed and driver could traverse the main
fcport list instead. Fix does exactly that.
Signed-off-by: Arun Easi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx
Hi Martin,
This series fixes crash during abort handling with FC-NVMe devices.
Also, we discovered race condition between nvme command and ls completion
with FC-NVMe devices.
Please apply this series to 5.3/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Changes from v2 -> v3
o Chang
rt_work [qla2xxx]
[ 5631.004097] RIP: 0010:[] []
qla_nvme_abort_work+0x22/0x100 [qla2xxx]
[ 5631.004109] Call Trace:
[ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0
[ 5631.004117] [] process_one_work+0x17f/0x440
[ 5631.004120] [] worker_thread+0x126/0x3c0
Signed-off-by: Quinn Tran
Signed-off-by: H
protected, and when a remoteport_delete callback is called, driver
traverses the list and crashes.
Actually, the list could be removed and driver could traverse the main
fcport list instead. Fix does exactly that.
Signed-off-by: Arun Easi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx
Hi Martin,
This series fixes crash during abort handling with FC-NVMe devices.
Also, we discovered race condition between nvme command and ls completion
with FC-NVMe devices.
Please apply this series to 5.3/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Changes from v1 -> v2
o Remov
From: Quinn Tran
- on session delete or chip reset, reject all NVME commands.
- on NVME command submission error, free srb resource.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 20 +---
1 file changed, 13 insertions(+), 7
during session deletion.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
Hi Martin,
we found one more issue where NVMe IO would be stuck while doing a
port toggle or lip_reset test case. This patch fixes issue by flushing
IO before unregistering NVMe session.
This patch depends on
Hi Bart,
On 6/14/19, 3:24 PM, "Bart Van Assche" wrote:
External Email
--
On 6/14/19 3:10 PM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> This patch uses kref to pro
From: Quinn Tran
- on session delete or chip reset, reject all NVME commands.
- on NVME command submission error, free srb resource.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 20 +---
1 file changed, 13 insertions(+), 7
Hi Martin,
This series fixes crash during abort handling with FC-NVMe devices.
Also, we discovered race condition between nvme command and ls completion
with FC-NVMe devices.
Please apply this series to 5.3/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Arun Easi (1):
qla2xxx: Fix
rt_work [qla2xxx]
[ 5631.004097] RIP: 0010:[] []
qla_nvme_abort_work+0x22/0x100 [qla2xxx]
[ 5631.004109] Call Trace:
[ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0
[ 5631.004117] [] process_one_work+0x17f/0x440
[ 5631.004120] [] worker_thread+0x126/0x3c0
Signed-off-by: Quinn Tran
Signed-off-by: H
protected, and when a remoteport_delete callback is called, driver
traverses the list and crashes.
Actually, the list could be removed and driver could traverse the main
fcport list instead. Fix does exactly that.
Signed-off-by: Arun Easi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx
[qla2xxx]
[436194.66] pci_device_remove+0x3b/0xb0
Fixes: 219d27d7147e (scsi: qla2xxx: Fix race conditions in the code for
aborting SCSI commands)
Cc: sta...@vger.kernel.org # 5.2
Signed-off-by: Arun Easi
Signed-off-by: Himanshu Madhani
---
Hi Martin,
This patch fixes issue we found during
Hello Bart,
> On Jun 11, 2019, at 12:27 PM, Bart Van Assche wrote:
>
> On 6/11/19 11:12 AM, Himanshu Madhani wrote:
>> I am running into issue with this series applied on my tree while executing
>> abort path.
>>
>> Investigating if the issue is
Hi Martin,
> On Jun 6, 2019, at 2:57 PM, Martin K. Petersen
> wrote:
>
>
> Himanshu,
>
>> Sorry for delay. I need bit more time. I will let my automation work
>> thru weekend and will respond in early next week
>
> OK, thanks!
>
I am running into issue with this series applied on my tree
Hi Martin,
> On Jun 5, 2019, at 7:05 PM, Martin K. Petersen
> wrote:
>
> External Email
>
> --
>
> Himanshu,
>
>> Thanks for the series. We will provide ACK after these patches have
>> gone through our internal testing.
>
port->logout_on_delete = 1;
> - fcport->login_retry = vha->hw->login_retry_count;
> fcport->n2n_chip_reset = fcport->n2n_link_reset_cnt = 0;
>
> switch (vha->hw->current_topology) {
> --
> 2.12.3
>
>
Hi Bart,
Thanks for the series. We will provide ACK after these patches have gone
through our internal testing.
Thanks,
Himanshu
> On May 29, 2019, at 1:28 PM, Bart Van Assche wrote:
>
> Hi Martin,
>
> This patch series is the result of code review, inspection of the Coverity
> output and a
Hi Ewan,
On 5/8/19, 8:36 AM, "Ewan D. Milne" wrote:
External Email
--
See below.
On Mon, 2019-05-06 at 13:52 -0700, Himanshu Madhani wrote:
> From: Quinn Tran
>
>
Hi Martin,
This series fixes issue with driver's EEH handling and NULL pointer access
while accessing optrom.
Please apply these patches to 5.2/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Quinn Tran (2):
qla2xxx: Fix Crash due to NULL pointer access in
qla2x00_sysfs_read_opt
RSP
[3130734.630487] CR2:
Fixes: c7702b8c2271 ("scsi: qla2xxx: Get mutex lock before checking
optrom_state")
Cc: sta...@vger.kernel.org # 4.10
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 3 ++-
1 file chan
abled due to PCIe error.
This patch does cleanup for EEH recovery code path and prevents
adapter from getting disabled.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 221 --
1 file changed, 82 insertions(+)
Hi Martin,
Please add for the series,
Acked-by: Himanshu Madhani
On 4/29/19, 10:59 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Martin K.
Petersen" wrote:
Himanshu,
> Still reviewing it. About half way done. Will ACK if no issues found
>
Hi Bart,
Still reviewing it. About half way done. Will ACK if no issues found during
testing.
Thanks,
Himanshu
On 4/25/19, 3:04 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van
Assche"
wrote:
On Wed, 2019-04-17 at 14:44 -0700, Bart Van Assche wrote:
> This patch serie
Hi Martin,
These patches fix small issue where device stays in blocked
state due to driver not marking port offline and moving
debug message to correct verbose level.
Please apply to 5.2/scsi-queue branch for inclusion at your
earliest convenience.
Thanks,
Himanshu
Himanshu Madhani (1
ELS IOCB done message should be moved to verbose logging
to prevent confusion about the error case v/s sucessful
submission case.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c
n
Cc: sta...@vger.kernel.org #4.19
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_target.c
index 57cdd762230d..fc8914dd9dde 100644
--- a/dr
1 - 100 of 1324 matches
Mail list logo
