RE: [patch] Revert "block: remove artifical max_hw_sectors cap"

2015-07-29 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Jeff Moyer > Sent: Wednesday, July 29, 2015 11:53 AM > To: Christoph Hellwig > Cc: Jens Axboe ; linux-ker...@vger.kernel.org; > dmilb...@redhat.com Adding linux-scs

RE: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Spencer Baugh > Sent: Thursday, July 23, 2015 5:28 PM > To: Christoph Hellwig ; Spencer Baugh > ... > Subject: Re: [PATCH] target: add support for START_STOP_UNIT S

RE: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Spencer Baugh > Sent: Wednesday, July 22, 2015 5:08 PM > Subject: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn > increment ... > diff --git a/drivers/targ

RE: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of James Bottomley > Sent: Friday, April 17, 2015 4:43 PM > To: Christoph Hellwig > Cc: linux-scsi@vger.kernel.org; ax...@kernel.dk > Subject: Re: [PATCH, RFC] scsi: use host

RE: [PATCH v4 42/43] hpsa: add PMC to copyright

2015-04-16 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Don Brace > Sent: Thursday, April 16, 2015 8:51 AM > Subject: [PATCH v4 42/43] hpsa: add PMC to copyright > > need to add PMC to copyright notice and update the Hewlett-P

RE: smp_processor_id warning in megasas driver on 3.19.3

2015-04-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Andy Lutomirski > Sent: Wednesday, April 8, 2015 1:27 PM > To: James Bottomley > Cc: Kashyap Desai; Sumit Saxena; Uday Lingala; > megaraidlinux@avagotech.com; Linux SC

RE: [PATCH] [RESEND] aic7xxx: replace kmalloc/memset by kzalloc

2015-03-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, March 24, 2015 3:57 PM > To: Michael Opdenacker > Cc: Hannes Reinecke; jbottom...@parallels.com; Elliott, Robert (Server > Storage); linux-scsi@vger.kernel.org; linux-ker...@vger.kernel

RE: [PATCH] scsi_debug: rework resp_report_luns

2015-02-25 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Winkler, Tomas > Sent: Wednesday, February 25, 2015 1:54 AM > To: dgilb...@interlog.com; James E.J. Bottomley" > Cc: linux-scsi@vger.kernel.org > Subject: RE: [PATCH] sc

RE: Device removal lockup with mptsas + scsi-mq

2015-02-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Tony Battersby > Sent: Wednesday, 04 February, 2015 12:39 PM > To: linux-scsi; Jens Axboe; Christoph Hellwig > Cc: Sreekanth Reddy > Subject: Device removal lockup with

RE: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

2015-01-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Thursday, January 08, 2015 12:44 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH

RE: [PATCH 3/5] scsi: add support for COMPARE_AND_WRITE

2014-12-17 Thread Elliott, Robert (Server Storage)
I haven't reviewed the whole patch, but noticed one thing: > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of micha...@cs.wisc.edu > Sent: Thursday, 16 October, 2014 12:37 AM ... > @@ -635,6 +646,54 @@ static void sd_prot

RE: Tagged overlapped commands

2014-12-17 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Andrew Brooks > Sent: Tuesday, 16 December, 2014 4:23 AM ... > > On 8 December 2014 at 07:02, James Bottomley > wrote: > > > > The error message likely means that the ta

RE: [PATCH 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2014-12-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Sreekanth Reddy > Sent: Tuesday, 09 December, 2014 6:17 AM > To: martin.peter...@oracle.com; j...@kernel.org; h...@infradead.org ... > Change_set: > 1. Added affinity_hint

RE: [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM

2014-12-05 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Thursday, 06 November, 2014 11:08 PM > To: linux-scsi@vger.kernel.org; linux-...@vger.kernel.org; linux- > fsde...@vger.kernel.org; ne...@suse

RE: [PATCH] scsi_scan: Send TEST UNIT READY to LUN0 before LUN scanning

2014-12-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Thursday, 04 December, 2014 10:39 AM ... > /** > + * scsi_test_lun - waiting for a LUN to become ready > + * @sdev:scsi_device to test > + *

RE: [BUG] kzalloc overflow in lpfc driver on 6k core system

2014-12-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Alex Thorlton > Sent: Tuesday, 02 December, 2014 3:58 PM ... > We've recently upgraded our big machine up to 6144 cores, and we're > shaking out a number of bugs related

RE: [PATCHv2 00/10] scsi logging update: the real thing

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:30 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject:

RE: [PATCH 10/10] scsi: Do not display buffer pointers in scsi_log_send()

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATC

RE: [PATCH 09/10] scsi: Conditionally compile in constants.c

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subjec

RE: [PATCH 08/10] scsi: use per-cpu buffer for formatting scsi_print_result()

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM ... > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c ... > diff --git a/drivers/scsi/scsi_logging.c > b/drivers/scsi/scsi_logging.c > index 065792a3..e7e7cab 100644 > --- a

RE: [PATCH 07/10] scsi: use per-cpu buffer for formatting sense

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM ... > diff --git a/drivers/scsi/scsi_logging.c ... > @@ -249,3 +255,146 @@ void scsi_print_command(struct scsi_cmnd *cmd) > } > } > EXPORT_SYMBOL(scsi_print_command); >

RE: [PATCH 01/10] scsi: Rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATC

RE: [PATCH 06/10] libata: use __scsi_format_command()

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke; linux- > i...@

RE: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Barto > Sent: Wednesday, November 12, 2014 9:28 PM > To: Guenter Roeck; Bjorn Helgaas > Cc: linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org; Joe > Perches >

RE: [PATCH 05/10] scsi: use external buffer for command logging

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [P

RE: [PATCH 03/10] scsi: Implement per-cpu logging buffer

2014-11-12 Thread Elliott, Robert (Server Storage)
Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 03/10] scsi: Implement per-cpu logging buffer > > +++ b/drivers/scsi/scsi_logging.c > @@ -0,0 +1,119 @@ ... > +static DEFINE_PER_CPU(struct scsi_log_buf, scs

RE: making the queue_type attribute read only, was: Re: tag handling refactor V2

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, 12 November, 2014 11:42 AM > To: Christoph Hellwig > Cc: linux-scsi@vger.kernel.org; James Bottomley; Elliott, Robert > (Server Storage); Hannes Reinecke; Martin K. Petersen;

RE: [PATCH 04/10] scsi: log request tag for scmd_printk()

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [P

RE: [PATCH 02/10] scsi: Add SPC-3 command definitions

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH

RE: [PATCH 01/10] scsi: Use real functions for logging

2014-11-11 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, 04 November, 2014 2:07 AM ... > diff --git a/drivers/scsi/scsi_logging.c > b/drivers/scsi/scsi_logging.c ... > @@ -0,0 +1,119 @@ > +/* > + * scsi_logging.c > + * > + * Copyright (C) 2014 SUSE Linux Product

RE: UNMAP command parameter list

2014-11-07 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Andras Kovacs > Sent: Friday, 07 November, 2014 5:30 PM > To: linux-scsi@vger.kernel.org > Subject: UNMAP command parameter list > > > Hi all, > > I'm trying to s

RE: absurdly high "optimal_io_size" on Seagate SAS disk

2014-11-07 Thread Elliott, Robert (Server Storage)
> commit 87c0103ea3f96615b8a9816b8aee8a7ccdf55d50 > Author: Martin K. Petersen > Date: Thu Nov 6 12:31:43 2014 -0500 > > [SCSI] sd: Sanity check the optimal I/O size > > We have come across a couple of devices that report crackpot > values in the optimal I/O size in the Block Lim

RE: [PATCH 5/6] osst: call scsi_set_medium_removal directly

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 5/6] osst: call scsi_set_medium_removal directly

RE: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 4/6] st: call scsi_set_medium_removal directly

RE: [PATCH 2/6] scsi: split scsi_nonblockable_ioctl

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 2/6] scsi: split scsi_nonblockable_ioctl > >

RE: [PATCH 6/6] scsi: return EAGAIN when resetting a device under EH

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 6/6] scsi: return EAGAIN when resetting a

RE: [PATCH 3/6] sd: fix up ->compat_ioctl

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 3/6] sd: fix up ->compat_ioctl > > No nee

RE: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage)

RE: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-11-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Tuesday, November 04, 2014 6:15 AM > To: Bart Van Assche; Elliott, Robert (Server Storage); Christoph Hellwig > Cc: Jens Axboe; Sagi Grimberg; Sebastian Parschauer; Ming

RE: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-11-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Sunday, November 02, 2014 7:03 AM > To: Bart Van Assche; Christoph Hellwig > Cc: Jens Axboe; Sagi Grimberg; Sebastian Parschauer; Elliott, Robert > (Server Storage); Ming Lei; linux-sc

RE: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Sudip Mukherjee > Sent: Thursday, October 30, 2014 12:55 AM > To: Fabian Frederick > Cc: linux-ker...@vger.kernel.org; Stephen M. Cameron; James E.J. > Bottomley; iss_st

RE: blk-mq problem on proliant DL380 G3 (cciss)

2014-10-29 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Meelis Roos > Sent: Wednesday, 29 October, 2014 10:38 AM > To: Jens Axboe > Cc: linux-scsi@vger.kernel.org; Christoph Hellwig > Subject: Re: blk-mq problem on proliant D

RE: [PATCH 26/27] scsi: correct return values for .eh_abort_handler implementations

2014-10-28 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, 24 October, 2014 7:27 AM > To: James Bottomley > Cc: Christoph Hellwig; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; Hannes Reinecke; sta...@vger.kernel.org >

RE: [PATCH 25/27] scsi: check for correct return code in scsi_eh_abort_cmds()

2014-10-28 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, 24 October, 2014 7:27 AM > To: James Bottomley > Cc: Christoph Hellwig; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 25/27] sc

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-28 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Tuesday, 28 October, 2014 12:57 PM > To: Elliott, Robert (Server Storage) > Cc: Hannes Reinecke; James Bottomley; Christoph Hellwig; linux- > s...@vger.kernel.org > Subject: R

RE: [PATCH 2/2] scsi: TUR path is down after adapter gets reset in multipath configuration(scsi_dh_alus.c)

2014-10-27 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of wenxi...@linux.vnet.ibm.com > Sent: Monday, 27 October, 2014 1:02 PM > To: james.bottom...@hansenpartnership.com > Cc: h...@infradead.org; linux-scsi@vger.kernel.org; > br

RE: [PATCH 1/2] scsi: TUR path is down after adapter gets reset in multipath configuration(scsi_error.c)

2014-10-27 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of wenxi...@linux.vnet.ibm.com > Sent: Monday, 27 October, 2014 1:02 PM > To: james.bottom...@hansenpartnership.com > Cc: h...@infradead.org; linux-scsi@vger.kernel.org; > br

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, 24 October, 2014 7:27 AM > To: James Bottomley > Cc: Christoph Hellwig; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 27/27] scsi

RE: [PATCH v2 10/12] IB/srp: Use block layer tags

2014-10-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 23, 2014 3:48 AM > To: Elliott, Robert (Server Storage) > Cc: Bart Van Assche; Jens Axboe; Sagi Grimberg; Sebastian Parschauer; > Ming Lei; linux-scsi@vger.kernel.org;

RE: [PATCH 6/6] scsi: use dev_printk variants where possible

2014-10-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Tuesday, 03 June, 2014 6:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 6/6]

RE: [PATCH v2 10/12] IB/srp: Use block layer tags

2014-10-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Bart Van Assche [mailto:bvanass...@acm.org] > Sent: Tuesday, 07 October, 2014 8:07 AM ... > @@ -1927,7 +1931,7 @@ static int srp_queuecommand(struct Scsi_Host > *shost, struct scsi_cmnd *scmnd) > > cmd->opcode = SRP_CMD; > cmd->lun= cpu_to_be64(

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Elliott, Robert (Server Storage) ... > With scsi_logging_level --set --error=5, there are: > * 10 "FAILED Result" prints > * the first

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Monday, 20 October, 2014 1:53 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 27/27] scsi

RE: [PATCH 0/5] block/scsi/lio support for COMPARE_AND_WRITE

2014-10-16 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Douglas Gilbert > Sent: Thursday, 16 October, 2014 3:02 PM ... > On 14-10-16 12:39 PM, Douglas Gilbert wrote: ... > > The COMPARE AND WRITE command may fail for other re

RE: [PATCH] aic7xxx: replace kmalloc/memset by kzalloc

2014-10-16 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Michael Opdenacker > Sent: Thursday, 16 October, 2014 2:31 PM ... > On 10/16/2014 09:28 PM, Joe Perches wrote: > > On Thu, 2014-10-16 at 21:14 +0200, Michael Opdenacker wr

RE: Concurrent SG_SCSI_RESET ioctls

2014-10-15 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, 15 October, 2014 8:26 AM ... > On Tue, Oct 14, 2014 at 12:42:26PM -0400, Douglas Gilbert wrote: > > I don't mind if you change it. However I plan to release > > sg3_utils-1.40 in the next 2 or 3

SG_SCSI_RESET ioctl reset escalation

2014-10-13 Thread Elliott, Robert (Server Storage)
Currently, if you request a reset through ioctl and it fails, the kernel escalates like it does for scsi_abort_eh_cmnd: bus device reset -> target reset -> bus reset -> host reset This is from scsi_error.c scsi_ioctl_r

RE: Concurrent SG_SCSI_RESET ioctls

2014-10-11 Thread Elliott, Robert (Server Storage)
> > From: Christoph Hellwig [mailto:h...@infradead.org] > > Sent: Saturday, 11 October, 2014 11:11 AM ... > > > > Hi Robert, > > > > can you take a look at the patches at: > > > > http://git.infradead.org/users/hch/scsi.git/shortlog/refs/heads/scsi-ioctl > > > > and confirm if they fix your issue

RE: Concurrent SG_SCSI_RESET ioctls

2014-10-11 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Saturday, 11 October, 2014 11:11 AM > To: Elliott, Robert (Server Storage) > Cc: James Bottomley (jbottom...@parallels.com); Christoph Hellwig; > dgilb...@interlog.com; linux-scsi@vg

Concurrent SG_SCSI_RESET ioctls

2014-10-10 Thread Elliott, Robert (Server Storage)
The sg3_utils command sg_reset --device /dev/sda invokes an ioctl with SG_SCSI_RESET, an argument of SG_SCSI_RESET_DEVICE, on a device opened with O_NDELAY. The call chain is like this: sd_ioctl[sd.c] scsi_nonblockable_ioctl [scsi_i

RE: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, 07 October, 2014 4:03 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 21/26] scsi: si

RE: [PATCH V6 01/18] scsi: fixing the "type" for well known LUs

2014-10-03 Thread Elliott, Robert (Server Storage)
rg; linux-arm- > m...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani; Sujit Reddy > Thumma; Elliott, Robert (Server Storage); Martin K. Petersen > Subject: Re: [PATCH V6 01/18] scsi: fixing the "type" for well known LUs > > Robert, I guess this version is okay with you? &g

RE: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-10-03 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, 25 September, 2014 7:13 AM > To: Douglas Gilbert > Cc: SCSI development list; linux-kernel; James Bottomley; Christoph Hellwig; > Mil

RE: [PATCH 24/24] scsi_error: document scsi_try_to_abort_cmd

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 24/24]

RE: [PATCH 22/24] scsi: fixup logging messages in scsi_error.c

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index 554f885..7e1e190 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -1156,9 +1156,10 @@ int scsi_eh_get_sense(st

RE: [PATCH 21/24] scsi: simplify scsi_log_(send|completion)

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 21/24] scs

RE: [PATCH 20/24] sd: Cleanup logging

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c ... > @@ -3328,9 +3319,19 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp, >sshdr->asc, sshdr->ascq); > } > > -static void sd_

RE: [PATCH 18/24] scsi: Remove scsi_print_command when calling abort

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATC

RE: [PATCH 17/24] scsi: remove last argument from print_opcode_name()

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 17/

RE: [PATCH 16/24] scsi: consolidate opcode lookup in scsi_opcode_sa_name()

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c ... > @@ -332,21 +340,20 @@ static void print_opcode_name(unsigned char * cdbp, int > cdb_len) > len = cdb_len; > } > > - if (

RE: [PATCH 15/24] scsi: merge print_opcode_name()

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > +struct sa_name_list { > + int cmd; > + const struct value_name_pair *arr; > + int arr_sz; > +}; The suggestion to rename cmd to opcode in patch 14 would follow the movements here. ... > @@ -273,7 +292,7 @@

RE: [PATCH 14/24] Implement scsi_opcode_sa_name

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > +struct sa_name_list { > + int cmd; > + const struct value_name_pair *arr; > + int arr_sz; > +}; cmd usually refers to a whole structure and is usually a pointer variable. grep searches will be easier

RE: [PATCH 12/24] scsi: use 'bool' as return value for scsi_normalize_sense()

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 12/24

RE: [PATCH 08/24] fas216: Update logging messages

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > @@ -2079,12 +2078,12 @@ fas216_std_done(FAS216_Info *info, struct scsi_cmnd > *SCpnt, unsigned int result) > break; > > default: > - printk(KERN_ERR "scsi%d.%c

RE: [PATCH 05/24] scsi: Use sdev as argument for sense code printing

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > @@ -1369,49 +1372,53 @@ scsi_extd_sense_format(unsigned char asc, unsigned > char ascq) { > EXPORT_SYMBOL(scsi_extd_sense_format); > > void > -scsi_show_extd_sense(unsigned char asc, unsigned char ascq) > +scsi_sh

RE: [PATCH 03/24] aha152x: Debug output update and whitespace cleanup

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c > index e77b72f..e1aba73 100644 > --- a/drivers/scsi/aha152x.c > +++ b/drivers/scsi/aha152x.c ... > @@ -345,10 +311,10 @@ CMD_INC_RESID(struct scsi_cmnd *cmd

RE: [PATCH 20/24] sd: Cleanup logging

2014-10-02 Thread Elliott, Robert (Server Storage)
> From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 848b17d..2cc8703 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -116,7 +116,7 @@ static int sd_eh_action(struct scsi_cmnd *, int); > static void sd_read_capacity(struct s

RE: [PATCHv5 00/24] scsi logging update (the boring part)

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, 01 October, 2014 1:23 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCHv5 00/24] scs

RE: [PATCH 04/24] scsi: introduce sdev_prefix_printk()

2014-10-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] ... > diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h > index 4c3ab83..c01dc89 100644 > --- a/drivers/scsi/sd.h > +++ b/drivers/scsi/sd.h > @@ -103,9 +103,10 @@ static inline struct scsi_disk *scsi_disk(struct gendisk > *

RE: [PATCH] block: remove artifical max_hw_sectors cap

2014-10-01 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Wednesday, 01 October, 2014 8:08 AM > To: Jens Axboe; linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org; Wu > Fengguang > Subject: Re: [

RE: [PATCH] scsi: add a CONFIG_SCSI_MQ_DEFAULT option

2014-09-30 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig ... > Add a Kconfig option to enable the blk-mq path for SCSI by default > to ease testing and deployment in setups that know they benefit > from blk-m

RE: Question: request tag usage

2014-09-26 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, September 26, 2014 3:21 AM > To: Christoph Hellwig > Cc: Elliott, Robert (Server Storage); SCSI Mailing List; Jens Axboe > Subject: Re: Question: request tag usage > > On 09/26/

RE: [PATCH V5 01/17] scsi: fixing the "type" for well known LUs

2014-09-24 Thread Elliott, Robert (Server Storage)
> From: Christoph Hellwig [mailto:h...@infradead.org] ... > On Wed, Sep 24, 2014 at 06:13:57PM +0300, Dolev Raviv wrote: > > From: Subhash Jadavani > > > > Some devices may respond with wrong type for well-known logical units. > > This patch forces well-known type for devices which doesn't report

RE: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Wednesday, September 24, 2014 5:32 AM > To: 'linux-scsi@vger.kernel.org' > Cc: Elliott, Robert (Server Storage); steve.came...@hp.com; Christoph > Hellwig; Handzik, Joe > Subject

RE: [Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler -> general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-09-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of bugzilla-dae...@bugzilla.kernel.org > Sent: Tuesday, 23 September, 2014 4:56 PM > To: linux-scsi@vger.kernel.org > Subject: [Bug 81861] Oops by mvsas v0.8.16: sas: ataX:

RE: boot stall regression due to blk-mq: use percpu_ref for mq usage count

2014-09-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Tejun Heo > Sent: Tuesday, 23 September, 2014 1:12 AM > To: Christoph Hellwig > Cc: Jens Axboe; linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org > Subject: R

RE: [PATCH 20/22] scsi: align logging messages

2014-09-18 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] ... > > scmd ties the messages together so you can tell which command > > has gotten to which state. grep works. > > Can we just print the tag instead, that would be a much more human > readable number normally.

RE: blk-mq timeout handling fixes

2014-09-17 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Saturday, 13 September, 2014 6:40 PM > To: Jens Axboe > Cc: Elliott, Robert (Server Storage); linux-scsi@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: blk-mq timeout handling f

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] > How do you mean? > > strncpy zeroes throughout the remainder of the string "from" until the > length off to_length, or otherwise guaranteed trailing zero characters > and a warning is print

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Rickard Strandqvist ... > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c ... > static void scsi_strcpy_devinfo(char *name, char *to, size_t to_l

RE: [PATCH 20/20] scsi_error: format abort error message

2014-09-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Friday, 05 September, 2014 7:33 PM > Subject: Re: [PATCH 20/20] scsi_error: format abort error message > > On Wed, Sep 03, 2014 at 12:06:15PM +0

RE: lk 3.17-rc4 blk_mq large write problems

2014-09-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Jens Axboe > Sent: Wednesday, September 10, 2014 9:00 PM > To: dgilb...@interlog.com; Christoph Hellwig > Cc: SCSI development list > Subject: Re: lk 3.17-rc4 blk_mq lar

RE: [PATCH 18/21] uas: Use scsi_print_command

2014-09-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hans de Goede > Sent: Wednesday, 10 September, 2014 6:47 AM > To: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org; > sta...@vger.kernel.or

RE: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-10 Thread Elliott, Robert (Server Storage)
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Sumit Saxena > > >From: Tomas Henzl [mailto:the...@redhat.com] > > > >With several controllers in a system this may take a lot memory, > > could you also in case when a kdump kernel is running lower

RE: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-09 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Tomas Henzl > Sent: Tuesday, 09 September, 2014 10:54 AM > Subject: Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature > support > > On 09/06/2014 03:25 PM, s

RE: [PATCH 0/6] blk-mq: initialize pdu of flush req explicitly

2014-09-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Ming Lei > Sent: Monday, 08 September, 2014 11:55 AM > To: Christoph Hellwig > Cc: Jens Axboe; Linux Kernel Mailing List; Linux SCSI List > Subject: Re: [PATCH 0/6] blk-

RE: scsi-mq and 3.17rc1

2014-09-07 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, 25 August, 2014 9:51 AM > To: Elliott, Robert (Server Storage) > Cc: linux-scsi@vger.kernel.org > Subject: Re: scsi-mq and 3.17rc1 > > On Mon, Aug 25, 2014 at 02:31:58P

RE: [PATCH V2] hpsa: refine the pci enable/disable handling

2014-09-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Tomas Henzl ... > + /* kdump kernel is loading, we don't know in which state is > + * the pci interface. The dev->enable_cnt is equal zero > + * so we cal

RE: [PATCH 21/22] scsi: reduce messages for command failure

2014-08-31 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Sunday, 31 August, 2014 5:29 PM > To: Hannes Reinecke > Cc: James Bottomley; Ewan Milne; Christoph Hellwig; linux- > s...@vger.kernel.org; Hoff

RE: [PATCH 20/22] scsi: align logging messages

2014-08-31 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Sunday, 31 August, 2014 5:26 PM ... > On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote: > > Always use 'scmd 0x%p' when logging

  1   2   >