> -----Original Message----- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@vger.kernel.org; Hannes Reinecke > Subject: [PATCH 02/10] scsi: Add SPC-3 command definitions > > SPC-3 defines SERVICE ACTION IN(12), SERVICE_ACTION OUT(12), > SERVICE ACTION OUT(16), and SERVICE ACTION BIDIRECTIONAL. > And READ MEDIA SERIAL NUMBER has long since been deprecated. > So update callers to refer to the new cdb name. > > Reviewed-by: Christoph Hellwig <h...@lst.de> > Signed-off-by: Hannes Reinecke <h...@suse.de> > --- > drivers/scsi/constants.c | 4 ---- > drivers/target/target_core_pr.c | 2 +- > include/scsi/scsi.h | 6 +++++- > tools/lib/traceevent/plugin_scsi.c | 5 ++++- > 4 files changed, 10 insertions(+), 7 deletions(-) > ... > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index b354c0d..df00fd1 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -128,8 +128,10 @@ enum scsi_timeouts { > #define MOVE_MEDIUM 0xa5 > #define EXCHANGE_MEDIUM 0xa6 > #define READ_12 0xa8 > +#define SERVICE_ACTION_OUT_12 0xa9 > #define WRITE_12 0xaa > -#define READ_MEDIA_SERIAL_NUMBER 0xab > +#define READ_MEDIA_SERIAL_NUMBER 0xab /* Obsolete with SPC-2 */ > +#define SERVICE_ACTION_IN_12 0xab
That needs one more space before 0xab to line up with the others. ... > diff --git a/tools/lib/traceevent/plugin_scsi.c > b/tools/lib/traceevent/plugin_scsi.c > index c699f47..63aba97 100644 > --- a/tools/lib/traceevent/plugin_scsi.c > +++ b/tools/lib/traceevent/plugin_scsi.c > @@ -85,8 +85,9 @@ typedef unsigned int u32; > #define MOVE_MEDIUM 0xa5 > #define EXCHANGE_MEDIUM 0xa6 > #define READ_12 0xa8 > +#define SERVICE_ACTION_out_12 0xa9 ... out should be capitalized Reviewed-by: Robert Elliott <elli...@hp.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
