Re: [PATCH] mptsas: fix undefined behaviour of a shift of an int by more than 31 places

2019-05-09 Thread Colin Ian King
On 09/05/2019 16:42, James Bottomley wrote: > On Thu, 2019-05-09 at 17:30 +0200, Hannes Reinecke wrote: >> On 5/8/19 4:24 PM, James Bottomley wrote: >>> On Wed, 2019-05-08 at 14:07 +0100, Colin Ian King wrote: >>>> On 05/05/2019 04:34, James Bottomley wrote: >>&

Re: [PATCH] mptsas: fix undefined behaviour of a shift of an int by more than 31 places

2019-05-08 Thread Colin Ian King
On 05/05/2019 04:34, James Bottomley wrote: > On Sat, 2019-05-04 at 17:40 +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently the shift of int value 1 by more than 31 places can result >> in undefined behaviour. Fix this by making the 1 a ULL value be

Re: [PATCH] scsi: qedf: replace memset/memcpy with safer strscpy

2019-04-12 Thread Colin Ian King
chwork.kernel.org/patch/10874565/ > > On 2019/4/12 17:05, Colin King wrote: >> From: Colin Ian King >> >> Currently the qedf_dbg_* family of functions can overrun the end >> of the source string if it is less than the destination buffer >> length because of t

Re: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller

2018-10-04 Thread Colin Ian King
Hi, Static analysis from CoverityScan (CID#114178 "Operands don't affect result") detected an issue in drivers/scsi/pmcraid.c, function pmcraid_init_res_table with the following check: if (pinstance->cfg_table->flags & MICROCODE_UPDATE_REQUIRED) pmcraid_err("IOA requires m

NAK: [PATCH] scsi: lpfc: fix spelling mistake: "mabilbox" -> "mailbox"

2018-05-03 Thread Colin Ian King
On 03/05/18 10:19, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in lpfc_printf_log log message > > Signed-off-by: Colin Ian King Ignore this, I've found more issues, sending a V2. > --- > drivers/scsi/lpfc/lpfc_init.c | 4 ++-- >

Re: [PATCH] isci: Fix infinite loop in while loop

2018-04-20 Thread Colin Ian King
On 20/04/18 10:45, James Bottomley wrote: > On Fri, 2018-04-20 at 10:03 +0100, Colin King wrote: >> From: Colin Ian King >> >> In the case when the phy_mask is bitwise anded with the >> phy_index bit is zero the continue statement currently jumps >> to the nex

re: scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-13 Thread Colin Ian King
Hi, minor nit-pick on the following commit: scsi: sg: fix SG_DXFER_FROM_DEV transfers SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set it to NULL for the old sg_io read/write interface, but must have a length bigger than 0. This fixes a regression introduced by commit 28676

NAK: [PATCH] scsi: snic: fix a couple of spelling mistakes/typos

2017-06-30 Thread Colin Ian King
Incorrect commit message, I'll resend. On 30/06/17 14:54, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes/typos: > > "Allodating" -> "Allocating" > "incative" -> "inactive" > >

Re: [PATCH] scsi: lpfc: fix spelling mistake "entrys" -> "entries"

2017-06-01 Thread Colin Ian King
On 01/06/17 15:35, Dan Carpenter wrote: > On Fri, May 26, 2017 at 11:11:37AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in debugfs message >> > > Are you using a tool to find all these spelling mistakes? Yep, I'

Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static

2017-05-11 Thread Colin Ian King
On 11/05/17 14:55, Bart Van Assche wrote: > On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote: >> From: Colin Ian King >> >> Making target_parse_xcopy_cmd static fixes sparse warning: >> >> "warning: symbol 'target_parse_xcopy_cmd' was not

Re: [PATCH] scsi: fcoe: sanity check string size for store_ctrl_mode option

2017-03-22 Thread Colin Ian King
On 22/03/17 19:39, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 02:01:37PM +, Colin King wrote: >> From: Colin Ian King >> >> Reading and writing to mode[count - 1] implies the count should not >> be less than 1 so add a sanity check for this. >> >>

Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

2017-02-07 Thread Colin Ian King
On 07/02/17 11:37, Dan Carpenter wrote: > On Tue, Feb 07, 2017 at 11:27:38AM +, Colin King wrote: >> From: Colin Ian King >> >> The check on rcode >= 0 is always true because rcode is unsigned >> and can never be less than zero. Remove the redundant check. >&

Re: [PATCH v1] scsi: ufs: fix arguments order some trace calls

2017-01-11 Thread Colin Ian King
On 11/01/17 00:48, Subhash Jadavani wrote: > Colin Ian King reported that with > commit 7ff5ab473633 ("scsi: ufs: add tracing support") static analysis > is reporting that we may have swapped arguments on calls to: > trace_ufshcd_runtime_resume, > tra