This patch removes dead code spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_isr.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
--- linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c.old2008-02-19
This patch makes theneedlessly global lpfc_disable_node() static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_crtn.h|1 -
drivers/scsi/lpfc/lpfc_hbadisc.c |2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
c3ed441728e0116d0e545837d84cbe3377
This patch contains the following cleanups:
- static functions in .c files shouldn't be marked inline
- make needlessly global code static
- remove the unused aic94xx_seq.c:asd_unpause_lseq()
- #if 0 other unused code
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch ha
This patch #if 0's the unused ses_match_host()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/ses.c |2 ++
1 file changed, 2 insertions(+)
a9b8c5789924c15d23282da4b2e6bf8fa98449a2 diff --git a/drivers/scsi/ses.c
b/drivers/scsi/ses.c
index 2a6e4f4..9125486 1
This patch makes the following needlessly global functions static:
- __iscsi_unblock_session()
- iscsi_session_state_name()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c |4 ++--
1 file changed, 2 insertions(+), 2 del
This patch makes the needlessly global scsi_end_bidi_request() static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
48e50a33ee11afb02eadc790ae2d9542b0805608
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index b12fb31..148c8b0 100644
--- a/drivers/scsi/scsi_lib.c
On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote:
> On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following
> > compile error:
> >
> > <-- snip -->
>
Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following
compile error:
<-- snip -->
...
CC drivers/scsi/arm/fas216.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In
function 'fas216_std_done':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/a
On Tue, Feb 05, 2008 at 09:06:23PM +0100, Sam Ravnborg wrote:
> On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote:
> > On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote:
> > > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx
On Tue, Feb 05, 2008 at 12:30:56PM -0600, James Bottomley wrote:
>
> On Tue, 2008-02-05 at 20:24 +0200, Adrian Bunk wrote:
> > On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote:
> > >
> > > On Tue, 2008-02-05 at 19:40 +0200, Adr
On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote:
>
> On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote:
> > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx
> > compilation:
> >
> > <-- snip -->
> >
> > $ make
Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx
compilation:
<-- snip -->
$ make O=../out/x86-full
...
SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h
SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h
CC drivers/scsi/aic7xxx/aic79xx_core.o
gcc: drivers/scsi/aic7xxx/aic79xx_core.c:
On Thu, Jan 31, 2008 at 09:45:26AM -0800, Chris Wedgwood wrote:
> On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote:
>
> > > cpuhotplug is required for suspend/resume.
> >
> > Not on UP computers.
>
> those are less and less common now, most mode
On Thu, Jan 31, 2008 at 09:07:49AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 18:21:42 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote:
> > > On Thu, 31 Jan 2008 09:57:31 -0600
> >
On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote:
> On Thu, 31 Jan 2008 09:57:31 -0600
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > No-one seems to see much value in these, and they cause about 90% of
> > our problems with __init/__exit markers, so simply eliminate them.
> >
On Wed, Jan 30, 2008 at 03:41:35PM -0600, James Bottomley wrote:
> On Wed, 2008-01-30 at 22:20 +0100, Sam Ravnborg wrote:
> > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote:
>...
> > > __init is possibly justifiable with a few hundred k savings on boot.
> > > __devinit and the rest
On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote:
>
> On Wed, 2008-01-30 at 22:03 +0200, Adrian Bunk wrote:
> > This patch fixes the following section mismatches:
> >
> > <-- snip -->
> >
> > ...
> > WARNING: drivers/scsi/qlo
On Wed, Jan 30, 2008 at 10:20:11PM +0100, Sam Ravnborg wrote:
> On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote:
>...
> To my understanding Adrian just fixed a potential oops.
> You have a driver that surely are thought to be hotplugable -
> otherwise qpti_sbus_probe() would not hav
nction
.init.text:qpti_map_queues()
WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x780): Section mismatch in
reference from the function qpti_sbus_probe() to the function
.init.text:qpti_chain_add()
...
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/
__iscsi_complete_pdu() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/libiscsi.c |5 ++---
include/scsi/libiscsi.h |2 --
2 files changed, 2 insertions(+), 5 deletions(-)
4d4f211556f92590bfc32a243f562853c499b314
diff --git a/driver
James, can you review and apply this patch?
TIA
Adrian
- Forwarded message from Frederik Deweerdt <[EMAIL PROTECTED]> -
Date: Wed, 16 Jan 2008 17:19:08 +0100
From: Frederik Deweerdt <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: [trivial patch] scsi/ultrastor:
On Mon, Dec 17, 2007 at 08:28:00PM -0800, Andrew Morton wrote:
>...
> I'd suggest that you find out if Adrian is still running the trivial tree
> and if so, patchbomb him.
I do.
Simply Cc [EMAIL PROTECTED] for trivial patches and they might
magically appear in Linus' tree during the next merge w
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n:
<-- snip -->
...
WARNING: vmlinux.o(.init.text.20+0xb3061): Section mismatch: reference to
.exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'ips_insert_device')
...
<-- snip -->
Si
On Mon, Nov 05, 2007 at 11:43:35AM -0800, Darrick J. Wong wrote:
> On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote:
> > This patch contains the following cleanups:
> > - static functions in .c files shouldn't be marked inline
> > - make needlessly global code
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n:
<-- snip -->
...
WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to
.init.data:_asc_def_iop_base (between 'advansys_isa_remove' and
'exit_this_scsi_driver')
...
<-- sni
megaraid_remove_one() can become __devexit.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
b7d71f38d1c1aa66311e862b58f36aa34c888f98
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 66c6520..765c24d 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/mega
Commit 2e0fef85e098f6794956b8b80b79fbb4cbb7 added the folowing code
to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be
dead code:
<-- snip -->
...
lpfc_state_show(struct class_device *cdev, char *buf)
{
...
switch (vport->port_state) {
ove_one (between 'qla2xxx_pci_error_detected' and
'qla2x00_stop_timer')
...
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_os.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
764ebbed3c09f765963c20a3a326cf651685a81a
diff --gi
AFAIR, this was the nsp32_msg() James wanted to keep, and the patch
should therefore be dropped.
cu
Adrian
On Wed, Nov 21, 2007 at 03:12:15PM -0800, [EMAIL PROTECTED] wrote:
> From: Adrian Bunk <[EMAIL PROTECTED]>
>
> The Coverity checker noted that we'll anyway Oops la
()
- remove the unused exports
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_crtn.h| 19 ---
drivers/scsi/lpfc/lpfc_els.c | 18 ++
drivers/scsi/lpfc/lpfc_hbadisc.c | 13 +
drivers/scsi/lpfc/lpfc_init.c
()
- qla_os.c: remove some unneeded function prototypes
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_attr.c |6 +++---
drivers/scsi/qla2xxx/qla_dbg.c |2 ++
drivers/scsi/qla2xxx/qla_gbl.h | 25 -
drivers/scsi/qla2xxx/qla
This patch contains the following cleanups:
- static functions in .c files shouldn't be marked inline
- make needlessly global code static
- #if 0 unused code
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/aic94xx/aic94xx_dev.c |8 +++---
drivers/s
This patch removes obviously dead code.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/seagate.c |2 --
1 file changed, 2 deletions(-)
c0807bbefb65ef679b7d2ec13d14c35f2e927404
diff --git a/drivers/scsi/seagate.c b/drivers/scsi/seagate.c
index b113244..2d31ed4
On Wed, Oct 24, 2007 at 12:41:12PM -0400, James Bottomley wrote:
> On Wed, 2007-10-24 at 18:25 +0200, Adrian Bunk wrote:
> > The Coverity checker noted that we'll anyway Oops later when we ran into
> > this condition - and the error check didn't prevent that.
> >
This patch does some additional cleanups after the 53c7xx removal.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
Documentation/dontdiff|2
Documentation/m68k/kernel-options.txt | 60 --
Documentation/scsi/00-INDEX
After the APUS removal, some code can be removed.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
arch/m68k/amiga/chipram.c |2
drivers/ide/ide-probe.c |8 +--
drivers/isdn/hisax/avm_pci.c|8 ---
drivers/scsi/a2091.c
check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 23 Jul 2007
drivers/scsi/nsp32.c |4
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/drivers/scsi/nsp32.c.old 2007-07-23
19:38:58.0 +0200
+++ linux-2.6.22-rc6-mm1
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
ad7c16573cd33555f4136c50fa35d1fb2c3669ca
diff --git a/drivers/scsi/advansys.c b/driver
This patch fixes a typo introduced by
commit bbfbbbc1182f8b44c8cc4c99f4a3f3a512149022.
It wasn't a compile error since CONFIG_LPFC_DEBUG_FS is not (yet?)
available as an option.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
74e14a2a4ed066aa8fedd557a6768fdfec5eb883
diff --gi
Commit bbfbbbc1182f8b44c8cc4c99f4a3f3a512149022 accidentally reversed
the logic of this NULL check.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
ee645f41f64ebeb782a0ca2e724dff929f854b68
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx
xbd0102): Section mismatch: reference to
.init.text.20:gdth_enable_int (between 'gdth_pci_probe_one' and
'gdth_start_timeout')
...
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c |
On Sat, Oct 13, 2007 at 02:09:35PM -0500, Rob Landley wrote:
> On Thursday 11 October 2007 6:56:59 pm Adrian Bunk wrote:
> > On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote:
> > > On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote:
> > > > I assum
On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote:
> On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote:
> > I assume you have the full .config in your build directory, and could
> > have taken it from there?
>
> Actually I don't. (The extracted sou
On Thu, Oct 11, 2007 at 08:30:38AM -0500, James Bottomley wrote:
> On Thu, 2007-10-11 at 08:17 -0500, Rob Landley wrote:
> > On Thursday 11 October 2007 6:05:55 am Adrian Bunk wrote:
> > > On Thu, Oct 11, 2007 at 05:52:48AM -0500, Rob Landley wrote:
> > > > CONFIG_SCS
On Thu, Oct 11, 2007 at 08:17:22AM -0500, Rob Landley wrote:
> On Thursday 11 October 2007 6:05:55 am Adrian Bunk wrote:
> > On Thu, Oct 11, 2007 at 05:52:48AM -0500, Rob Landley wrote:
> > > CONFIG_SCSI_SUNESP=y breaks the build in 2.6.23:
> > >
> > > LD
On Thu, Oct 11, 2007 at 05:52:48AM -0500, Rob Landley wrote:
> CONFIG_SCSI_SUNESP=y breaks the build in 2.6.23:
>
> LD vmlinux
> `scsi_esp_unregister' referenced in section `__ksymtab' of
> drivers/built-in.o:
> defined in discarded section `.exit.text' of drivers/built-in.o
> make: *** [
On Thu, Oct 04, 2007 at 09:28:34AM +0200, Jens Axboe wrote:
>...
> Tomo, this is the patch I added.
Please excuse my comment in case this was already clear:
You are aware that this bug is a regression in 2.6.23-rc and the patch
should therefore go to Linus ASAP and not after the release of 2.6.2
Cc's added, the complete bug report is at
http://lkml.org/lkml/2007/10/2/243
On Tue, Oct 02, 2007 at 12:48:26PM -0400, Burton Windle wrote:
> 2.6.23-rc9 fails to boot for me; 2.6.22.9 works fine.
>
> System is a Dell Poweredge with PERC 2/DC with RAID1 volume.
>...
Thanks for your report.
Diff
On Sat, Sep 15, 2007 at 05:27:24PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> > On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote:
> >> Perfect is in the eye of the beholder. You would consequently have to
> >> add such options into all menus w
On Sat, Sep 15, 2007 at 11:44:59AM -0400, Jeff Garzik wrote:
> Stefan Richter wrote:
>> Adrian Bunk wrote:
>>> On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote:
>>>> Perfect is in the eye of the beholder. You would consequently have to
>>>
On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> > On Sat, Sep 15, 2007 at 03:20:06PM +0200, Stefan Richter wrote:
> >> It still doesn't entirely clarify whether users need sd, sr, st, and
> >> whether thy need sd for the disk w
On Sat, Sep 15, 2007 at 03:20:06PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> >>> There should first be the lowlevel SCSI, SATA, USB etc. drivers, these
> >>> drivers should select CONFIG_SCSI, and then the menu offering support
> >>> for disk, C
On Fri, Sep 14, 2007 at 11:14:21PM +0200, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
> ---
>
> And one more update:
> There is SAS too, and I forgot 'is' in "on a disk which __ accessed via".
>
> drivers/scsi/Kconfig | 67 ++---
On Sat, Sep 15, 2007 at 02:24:17PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
>...
> >> # drivers/Kconfig
> >>
> >> +source "drivers/scsi/Kconfig"
> >> +
> >> menu "Device Drivers"
> >>
> &g
On Fri, Sep 14, 2007 at 10:01:18PM +0200, Stefan Richter wrote:
> On 14 Sep, Adrian Bunk wrote:
> > On Fri, Sep 14, 2007 at 09:00:33PM +0200, Sam Ravnborg wrote:
> >> Hi Stefan.
> >>
> >> Such a patch really calls for some minimal unif
On Fri, Sep 14, 2007 at 09:00:33PM +0200, Sam Ravnborg wrote:
> Hi Stefan.
>
> Such a patch really calls for some minimal unifacation among
> the architectures.
>
> >
> > arch/alpha/Kconfig|2
> > arch/arm/Kconfig |2
> > arch/avr32/Kconfig|2
On Fri, Sep 14, 2007 at 05:37:37PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> > On Fri, Sep 14, 2007 at 04:54:07PM +0200, Stefan Richter wrote:
> >> The patch which is discussed here is specifically targeted towards users
> >> who are convinced that they can m
On Fri, Sep 14, 2007 at 04:54:07PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> > On Sun, Sep 09, 2007 at 05:11:44PM -0400, Jeff Garzik wrote:
> >> Let's step back a moment and consider the actual scale and impact of the
> >> problem at hand.
> >
On Sun, Sep 09, 2007 at 05:11:44PM -0400, Jeff Garzik wrote:
> Andi Kleen wrote:
>>> I can see where you're coming from, but logically, this is wrong.
>>> There's a huge slew of enterprise machines that only have DVD on SATA.
>> ... and enterprise systems don't really care about a few KB more of co
On Tue, Sep 04, 2007 at 04:16:26PM +0200, Bernhard Walle wrote:
> This patch just makes the version number in ips.c and ips.h consistent. It
> seems that this has been forgotten in
> a60768e2d43eb30a1adb8a119aeac35dc0d03ef6.
A better fix would be to no longer have two different places defining a
The Coverity checker spotted that we have already oops'ed if "cmd"
was NULL.
Since "cmd" being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
On Sun, Aug 26, 2007 at 04:21:30PM +0100, Denys Vlasenko wrote:
> On Saturday 25 August 2007 22:57, Arjan van de Ven wrote:
>...
> > Did you run the find static
> > script or are you waiting for Adrian to do that ;-)
>
> $ find -name '*find*static*'
> $
make namespacecheck
> vda
cu
Adrian
--
On Fri, Aug 10, 2007 at 09:03:52PM -0400, James Bottomley wrote:
> On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote:
> > From: Adrian Bunk <[EMAIL PROTECTED]>
> >
> > The Coverity checker noted that we'll anyway Oops later when we ran into
> > this
On Fri, Aug 10, 2007 at 09:01:59PM -0400, James Bottomley wrote:
> On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote:
> > From: Adrian Bunk <[EMAIL PROTECTED]>
>
> You're not just removing the 2.4 code ... you're also removing the rcs
> tags ... that&#
The Coverity checker spotted that we have already oops'ed if "cmd"
was NULL.
Since "cmd" being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/dri
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 24 Mar 2007
drivers/scsi/constants.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/scsi/constants
Every file should #include the headers containing the prototypes for
its global functions (in this case for scsi_schedule_eh()).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28
17:10:48.0 +0200
+++ linux-2.6.
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +ata-ahci-alpm-expose-power-management-policy-option-to-users.patch
>...
> ata things
>...
scsi_host_link_pm_policy() can become static.
Signed-off-by: Adrian B
On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
> Of the machines we test releases on automatically this only compiles on
> NUMA-Q and does not boot there (some PCI issue).
>
>
> ppc64 (beavis):
>
> drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add':
> : undefined re
check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/nsp32.c |4
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/drivers/scsi/nsp32.c.old 2007-07-23
19:38:58.0 +0200
+++ linux-2.6.22-rc6-mm1/drivers/scsi/nsp32.c 2007-07-23 20:1
The Coverity checker spotted the following inconsequent NULL checking in
drivers/message/fusion/mptscsih.c:
<-- snip -->
...
int
mptscsih_qcmd(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *))
{
...
if (vdev
&& (vdev->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
The Coverity checker spotted the following off-by-10
in drivers/scsi/lpfc/lpfc_sli.c:
<-- snip -->
...
static int
lpfc_sli_process_unsol_iocb(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
struct lpfc_iocbq *saveq)
{
...
saveq->context3
On Fri, Jul 20, 2007 at 11:48:57AM -0500, James Bottomley wrote:
> On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote:
> > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff)
> > wd33c93 SCSI needs on m68k
> >
> > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset':
> >
On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm2:
>...
> git-scsi-misc.patch
>...
> git trees
>...
<-- snip -->
...
LD drivers/built-in.o
drivers/isdn/built-in.o: In function `check_reset': (.text+0xab974):
multiple definition of `chec
Not converted to the 2.6 kconfig system and no code in the tree.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc4-mm2/drivers/scsi/Kconfig.old 2007-06-18
15:22:55.0 +0200
+++ linux-2.6.22-rc4-mm2/drivers/scsi/Kconfig 2007-06-18 15:23:04.0
i/lpfc/lpfc_init.c:1419:
warning: unused variable ‘retval’
...
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.21-rc7-mm2/drivers/scsi/lpfc/lpfc_init.c.old 2007-04-28
15:20:42.0 +0200
+++ linux-2.6.21-rc7-mm2/drivers/scsi/lpfc/lpfc_init.c
On Fri, Apr 27, 2007 at 10:55:54AM -0400, Robert P. J. Day wrote:
> On Thu, 26 Apr 2007, James Bottomley wrote:
>
> > Personally, I don't like to see 2.4 and 2.6 in a new driver, and
> > will tend to try to force it to be 2.6 only. For an existing
> > driver, I tend to be much more tolerant: remo
On Thu, Apr 26, 2007 at 07:59:57PM -0400, Robert P. J. Day wrote:
> On Fri, 27 Apr 2007, Adrian Bunk wrote:
>
> > This patch removes kernel 2.4 code.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> >
> > ---
> >
> > This patch has
This patch removes kernel 2.4 code.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 26 Mar 2007
drivers/scsi/nsp32.c | 109 +--
1 file changed, 13 insertions(+), 96 deletions(-)
--- linux-2.6.21-rc4-mm1/driver
This patch removes some kernel 2.4 code.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 26 Mar 2007
drivers/scsi/ips.c | 145 +
drivers/scsi/ips.h | 44 -
2 files changed, 20 insertions(+
This patch removes kernel 2.4 code and some ancient CVS tags.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 26 Mar 2007
drivers/scsi/pcmcia/nsp_cs.c | 159 +--
drivers/scsi/pcmcia/nsp_cs.h |8 -
2 files chan
This email lists some known regressions in Linus' tree compared to 2.6.20
with patches available.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any ot
This email lists some known regressions in Linus' tree compared to 2.6.20.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way
possibly involv
On Mon, Mar 26, 2007 at 03:33:46PM -0700, Andrew Morton wrote:
> On Mon, 26 Mar 2007 14:50:51 -0700
> [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=8266
> >
> >Summary: Exabyte 1x10 autoloader breaks on upgrade
> > Kernel Version: 2.6.20.4
> >
This patch removes kernel 2.4 code.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/nsp32.c | 109 +--
1 file changed, 13 insertions(+), 96 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/scsi/nsp32.c.old 2007-03-25
This patch removes some kernel 2.4 code.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/ips.c | 145 +
drivers/scsi/ips.h | 44 -
2 files changed, 20 insertions(+), 169 deletions(-)
--- linux-2.6.21-rc4-mm1/d
This patch removes kernel 2.4 code and some ancient CVS tags.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/pcmcia/nsp_cs.c | 159 +--
drivers/scsi/pcmcia/nsp_cs.h |8 -
2 files changed, 5 insertions(+), 162 deletions(-)
--- linux-
On Sat, Mar 24, 2007 at 12:11:05PM -0400, Douglas Gilbert wrote:
> Adrian Bunk wrote:
> > On Mon, Mar 19, 2007 at 08:56:23PM -0800, Andrew Morton wrote:
> >> ...
> >> Changes since 2.6.21-rc3-mm1:
> >> ...
> >> git-scsi-misc.patch
> >> ...
&
On Mon, Mar 19, 2007 at 08:56:23PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc3-mm1:
>...
> git-scsi-misc.patch
>...
> git trees
>...
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
driv
The Coverity checker spotted the following inconsequent NULL checking in
drivers/message/fusion/mptsas.c:
<-- snip -->
...
static void
mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
{
...
if (port_info->phy_info &&
(!(port_info->phy_info[0].identify.device_inf
The Coverity checker spotted the following inconsequent NULL checking in
drivers/message/fusion/mptscsih.c:
<-- snip -->
...
int
mptscsih_qcmd(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *))
{
...
if (vdev
&& (vdev->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
still
present in the older kernel releases.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 21 Jan 2007
- 6 Jan 2007
Due to it's size, the compressed patch is attached.
drivers/scsi/arm/Kconfig| 29
drivers/scsi/arm/Makefile |
can now become static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/aacraid/aacraid.h |3 +++
drivers/scsi/aacraid/linit.c |2 --
drivers/scsi/aacraid/nark.c|3 ---
drivers/scsi/aacraid/rkt.c |3 ---
drivers/scsi/aacraid/rx.c |2 +-
5 files
On Thu, Feb 01, 2007 at 08:07:12PM -0800, Andrew Morton wrote:
> On Fri, 2 Feb 2007 03:33:43 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Feb 01, 2007 at 06:21:47PM -0800, Andrew Morton wrote:
> > > On Fri, 2 Feb 2007 00:07:52 +0100 Luca Tettamanti <[
tain preceeding text which
would have to be parsed. The idea of sysfs files is that the file name
is the description and the contents is a simple value.
Fix up arcmsr to conform to this standard.
Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Adrian
On Mon, Jan 22, 2007 at 03:18:41PM +, Alan wrote:
> On Sun, 21 Jan 2007 20:13:00 +0100
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > Using assembler code for performance in drivers might have been a good
> > idea 15 years ago when this code was written,
still
present in the older kernel releases.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 6 Jan 2007
Due to it's size, the compressed patch is attached.
drivers/scsi/arm/Kconfig| 29
drivers/scsi/arm/Makefile |3
drive
lternative.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 6 Jan 2007
drivers/scsi/Makefile |2
drivers/scsi/seagate.c | 148 -
2 files changed, 1 insertion(+), 149 deletions(-)
--- linux-2.6.20-rc3-
seagate_st0x_detect() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 6 Jan 2007
--- linux-2.6.20-rc3-mm1/drivers/scsi/seagate.c.old 2007-01-05
22:53:13.0 +0100
+++ linux-2.6.20-rc3-mm1/drivers/scsi/seagate.c 2007-01-05
This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 unused functions
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/qla4xxx/ql4_dbg.c |4
drivers/scsi/qla4xxx/ql4_glbl.h |9 -
drivers/scsi/qla4xxx/ql4_
1 - 100 of 172 matches
Mail list logo
