[PATCH 00/57] Convert files to ReST

2019-04-15 Thread Mauro Carvalho Chehab
This series convert lots of files to be properly parsed by Sphinx as ReST files. As it touches on lot of stuff, the series is based on linux-next. I have a separate patch series with do the actual rename and adjustment of references. I opted to submit this first, as it sounds easier to merge this

[PATCH 34/57] docs: target: convert it to ReST format

2019-04-15 Thread Mauro Carvalho Chehab
Convert the TCM docs to ReST format and add them to the bookset. This has a mix of userspace-faced and Kernelspace faced docs. Still, it sounds a better candidate to be added at the kernel API set of docs. Signed-off-by: Mauro Carvalho Chehab --- Documentation/target/tcm_mod_builder.txt | 200 +

Re: [PATCHv2] scsi: core: set result when the command cannot be dispatched

2019-04-15 Thread Martin K. Petersen
Jaesoo, > When SCSI blk-mq is enabled, there is a bug in handling errors in > scsi_queue_rq. Specifically, the bug is not setting result field of > scsi_request correctly when the dispatch of the command has been > failed. Since the upper layer code including the sg_io ioctl expects > to receiv

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-15 Thread Kento.A.Kobayashi
Hi, >On Mon, 15 Apr 2019, Alan Stern wrote: > >> On Mon, 15 Apr 2019 kento.a.kobaya...@sony.com wrote: >> >> > Hi >> > >> > >The unbind happens from inside the SCSI EH callback. If that really is >> > >not allowed, we'll need to change it. Or we can just change it >> > >regardless, since the

Re: [RFC PATCH v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-04-15 Thread Martin K. Petersen
Li, > commit 84961f28e9d1 ("[SCSI] Don't add scsi_device for devices that > return PQ=1, PDT=0x1f") returns SCSI_SCAN_TARGET_PRESENT if inquiry > returns PQ=1, and PDT = 0x1f. However, from the scsi spec, it seemed > setting PQ=1, and PDT to the type it is capable to support, can also > mean the

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread TomK
On 4/15/2019 3:35 PM, Laurence Oberman wrote: On Mon, 2019-04-15 at 08:39 -0700, Bart Van Assche wrote: On Mon, 2019-04-15 at 08:55 -0400, Laurence Oberman wrote: On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: Hey All, I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 motherboard that I'

Re: [PATCH -next] scsi: megaraid_sas: Make megasas_host_device_list_query() static

2019-04-15 Thread Martin K. Petersen
Yue, > Fix sparse warning: > > drivers/scsi/megaraid/megaraid_sas_base.c:4652:1: warning: > symbol 'megasas_host_device_list_query' was not declared. Should it be > static? Applied to 5.2/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: ufs: Print real incorrect request response code

2019-04-15 Thread Martin K. Petersen
Stanley, > If UFS device responds an unknown request response code, we can not > know what it was via logs because the code is replaced by "DID_ERROR > << 16" before log printing. > > Fix this to provide precise request response code information for > easier issue breakdown. Applied to 5.2/scsi

Re: [PATCH] scsi: cxgb4i: fix incorrect spelling "reveive" -> "receive"

2019-04-15 Thread Martin K. Petersen
Varun, Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libcxgbi: update route finding logic

2019-04-15 Thread Martin K. Petersen
Varun, > To support vlan and bridge devices first find route using ifindex 0, > if route is not found through net device associated with input scsi > host then find route using ifindex of net device. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libcxgbi: find cxgbi device by MAC address

2019-04-15 Thread Martin K. Petersen
Varun, > If cxgbi_device_find_by_netdev() returns NULL then find cxgbi device > by MAC address. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V5 9/9] SCSI: don't hold device refcount in IO path

2019-04-15 Thread Martin K. Petersen
Ming, > This patch doesn't depend on patch 1~8, so please take it via scsi > tree if you are fine. Applied, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix read offset in qla24xx_load_risc_flash()

2019-04-15 Thread Martin K. Petersen
Himanshu, > This patch fixes regression introduced by commit f8f97b0c5b7f ("scsi: > qla2xxx: Cleanups for NVRAM/Flash read/write path") where flash > read/write routine cleanup left out code which resulted into checksum > failure leading to use-after-free stack during driver load. Applied to 5.

Re: [PATCH 00/10] Improve qla2xxx coding style

2019-04-15 Thread Martin K. Petersen
Bart, > While preparing a few bug fixes for the qla2xxx driver I noticed > several stylistic issues in that driver. I'm sending the patches with > stylistic improvements ahead to avoid having to post too many patches > at once (another 20 patches will follow at a later time). Please > consider t

Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up

2019-04-15 Thread Martin K. Petersen
John, > This patchset introduces some minor improvements and tidy-up, including: > - fix PHY info in sysfs for PHY events > - min pathway rate programming improvement > - some other tidy-up and neatening Applied to 5.2/scsi-queue, thanks! One thing that always bugged me is the ambiguous "ex" p

Re: [PATCH 0/9] hisi_sas: Some misc patches

2019-04-15 Thread Martin K. Petersen
John, > The patchset introduces improvements, more minor fixes, and new features > for the driver, including: > - Host reset interface > - Switch all HW error handling to MSI > - Give SATA disk unique (fake) SAS address for v3 hw > - Some error handling fixes > - Some tidy-up Applied to 5.2/scs

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread Laurence Oberman
On Mon, 2019-04-15 at 08:39 -0700, Bart Van Assche wrote: > On Mon, 2019-04-15 at 08:55 -0400, Laurence Oberman wrote: > > On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: > > > Hey All, > > > > > > I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 > > > motherboard > > > that > > > I've got a

Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-04-15 Thread Wei Xu
Hi Manivannan, On 2/20/2019 2:21 PM, Martin K. Petersen wrote: > > Hi Thierry, > >> it looks like you picked this up into the SCSI tree (perhaps >> inadvertently). It's been causing linux-next to fail to build since >> Monday (next-20190218) because it references a phandle (&crg_rst) >> that's n

Re: [RFC PATCH v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-04-15 Thread Bart Van Assche
On Mon, 2019-04-15 at 13:20 +0800, Li Zhong wrote: > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > index 53380e07b40e..058079f915f1 100644 > --- a/drivers/scsi/scsi_scan.c > +++ b/drivers/scsi/scsi_scan.c > @@ -1129,7 +1129,8 @@ static int scsi_probe_and_add_lun(struct scsi_tar

Re: [PATCH 00/10] Improve qla2xxx coding style

2019-04-15 Thread Himanshu Madhani
On 4/11/19, 2:53 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: Hi Martin, While preparing a few bug fixes for the qla2xxx driver I noticed several stylistic issues in that driver. I'm sending the patches with stylistic improvements ahead to a

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread Bart Van Assche
On Mon, 2019-04-15 at 08:55 -0400, Laurence Oberman wrote: > On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: > > Hey All, > > > > I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 motherboard > > that > > I've got a QLE2464 card in as a target (FC). The kernel has been > > crashing / panick

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-15 Thread Alan Stern
On Mon, 15 Apr 2019, Alan Stern wrote: > On Mon, 15 Apr 2019 kento.a.kobaya...@sony.com wrote: > > > Hi > > > > >The unbind happens from inside the SCSI EH callback. If that really is > > >not allowed, we'll need to change it. Or we can just change it > > >regardless, since the effort requir

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-15 Thread Alan Stern
On Mon, 15 Apr 2019 kento.a.kobaya...@sony.com wrote: > Hi > > >The unbind happens from inside the SCSI EH callback. If that really is not > >allowed, we'll need to change it. Or we can just change it regardless, > >since the effort required is pretty small. > > > >Kento, please try the patch

RE: [PATCH 1/1] scsi: ufs: Print real incorrect request response code

2019-04-15 Thread Winkler, Tomas
> On 4/15/19 5:23 AM, Stanley Chu wrote: > > If UFS device responds an unknown request response code, we can not > > know what it was via logs because the code is replaced by "DID_ERROR > > << 16" before log printing. > > > > Fix this to provide precise request response code information for > > ea

Re: [PATCH 1/1] scsi: ufs: Print real incorrect request response code

2019-04-15 Thread Bart Van Assche
On 4/15/19 5:23 AM, Stanley Chu wrote: > If UFS device responds an unknown request response code, > we can not know what it was via logs because the code > is replaced by "DID_ERROR << 16" before log printing. > > Fix this to provide precise request response code information > for easier issue bre

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread Laurence Oberman
On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: > Hey All, > > I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 motherboard > that > I've got a QLE2464 card in as a target (FC). The kernel has been > crashing / panicking in the last 1-2 months about once a > week. Before > that, it was r

[PATCH 1/1] scsi: ufs: Print real incorrect request response code

2019-04-15 Thread Stanley Chu
If UFS device responds an unknown request response code, we can not know what it was via logs because the code is replaced by "DID_ERROR << 16" before log printing. Fix this to provide precise request response code information for easier issue breakdown. Signed-off-by: Stanley Chu --- drivers/s

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread Alastair D'Silva
> -Original Message- > From: David Laight > Sent: Monday, 15 April 2019 9:04 PM > To: 'Alastair D'Silva' ; 'Petr Mladek' > > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lend

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:45 ... > > Although I think you'd want a 'no hex' flag to suppress the hex. > > > > Probably more useful flags are ones to suppress the address column. > > This is already supported by the prefix_type parameter - are you proposing > that we eliminat

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-15 Thread Alastair D'Silva
> From: Alastair D'Silva > > Sent: 15 April 2019 11:29 > ... > > I do, and I believe the choice of the output length should be in the > > hands of the caller. > > > > On further thought, it would make more sense to remove the hardcoded > > list of sizes and just enforce a power of 2. The function s

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-15 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:29 ... > I do, and I believe the choice of the output length should be in the hands > of the caller. > > On further thought, it would make more sense to remove the hardcoded list of > sizes and just enforce a power of 2. The function shouldn't dictat

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2019-04-15 Thread David Disseldorp
[replying to an old thread] On Sun, 8 Apr 2018 11:57:18 +0800, Zhang Zhuoyu wrote: > > On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > > > > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > > > +CONFIGFS_ATTR_RO(

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread Alastair D'Silva
> -Original Message- > From: David Laight > Sent: Monday, 15 April 2019 8:21 PM > To: 'Alastair D'Silva' ; 'Petr Mladek' > > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lend

RE: [PATCH 2/4] lib/hexdump.c: Optionally suppress lines of filler bytes

2019-04-15 Thread Alastair D'Silva
> > > On Wed 2019-04-10 13:17:18, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > Some buffers may only be partially filled with useful data, while > > > > the rest is padded (typically with 0x00 or 0xff). > > > > > > > > This patch introduces flags which allow lines of padd

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-15 Thread Alastair D'Silva
> > > On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > With modern high resolution screens, we can display more data, > > > > which makes life a bit easier when debugging. > > > > > > I have quite some doubts about this feature. > > > > > > We are

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:07 ... > In the above example the author only wants the hex output, while in other > situations, both hex & ASCII output is desirable. If you just want ASCII > output, the caller should just use a printk or one of it's wrappers. Hexdump will 'sanitis

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread Alastair D'Silva
> -Original Message- > From: Petr Mladek > Sent: Monday, 15 April 2019 7:24 PM > To: Alastair D'Silva > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lendacky' ; 'David S. Mil

Re: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-15 Thread Petr Mladek
On Sat 2019-04-13 09:31:27, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Saturday, 13 April 2019 12:12 AM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Ka

Re: [PATCH 2/4] lib/hexdump.c: Optionally suppress lines of filler bytes

2019-04-15 Thread Petr Mladek
On Sat 2019-04-13 09:28:03, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Saturday, 13 April 2019 12:04 AM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Ka

Re: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-15 Thread Petr Mladek
On Sat 2019-04-13 09:22:05, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Friday, 12 April 2019 11:48 PM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Kars