> -----Original Message----- > From: David Laight <david.lai...@aculab.com> > Sent: Monday, 15 April 2019 8:21 PM > To: 'Alastair D'Silva' <alast...@d-silva.org>; 'Petr Mladek' > <pmla...@suse.com> > Cc: 'Alastair D'Silva' <alast...@au1.ibm.com>; 'Jani Nikula' > <jani.nik...@linux.intel.com>; 'Joonas Lahtinen' > <joonas.lahti...@linux.intel.com>; 'Rodrigo Vivi' <rodrigo.v...@intel.com>; > 'David Airlie' <airl...@linux.ie>; 'Daniel Vetter' <dan...@ffwll.ch>; 'Karsten > Keil' <i...@linux-pingi.de>; 'Jassi Brar' <jassisinghb...@gmail.com>; 'Tom > Lendacky' <thomas.lenda...@amd.com>; 'David S. Miller' > <da...@davemloft.net>; 'Jose Abreu' <jose.ab...@synopsys.com>; 'Kalle > Valo' <kv...@codeaurora.org>; 'Stanislaw Gruszka' <sgrus...@redhat.com>; > 'Benson Leung' <ble...@chromium.org>; 'Enric Balletbo i Serra' > <enric.balle...@collabora.com>; 'James E.J. Bottomley' > <j...@linux.ibm.com>; 'Martin K. Petersen' <martin.peter...@oracle.com>; > 'Greg Kroah-Hartman' <gre...@linuxfoundation.org>; 'Alexander Viro' > <v...@zeniv.linux.org.uk>; 'Sergey Senozhatsky' > <sergey.senozhat...@gmail.com>; 'Steven Rostedt' > <rost...@goodmis.org>; 'Andrew Morton' <a...@linux-foundation.org>; > intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; > ath...@lists.infradead.org; linux-wirel...@vger.kernel.org; linux- > s...@vger.kernel.org; linux-fb...@vger.kernel.org; > de...@driverdev.osuosl.org; linux-fsde...@vger.kernel.org > Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in > hex_dump_to_buffer with flags > > From: Alastair D'Silva > > Sent: 15 April 2019 11:07 > ... > > In the above example the author only wants the hex output, while in > > other situations, both hex & ASCII output is desirable. If you just > > want ASCII output, the caller should just use a printk or one of it's > wrappers. > > Hexdump will 'sanitise' the ASCII. >
This is functionality that doesn't exist in the current hexdump implementation (you always get the hex version). I think a better option would be to factor out the sanitisation and expose that as a separate function. > Although I think you'd want a 'no hex' flag to suppress the hex. > > Probably more useful flags are ones to suppress the address column. This is already supported by the prefix_type parameter - are you proposing that we eliminate the parameter & combine it with flags? > I've also used flags to enable (or disable) suppression of multiple lines of > zeros of constant bytes. > In that case you may want hexdump to return the flags for the next call when > a large buffer is being dumped in fragments. I'm afraid I don't quite follow here, hex_dump_to_buffer doesn't alter the flags, so the caller already knows it. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alast...@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece
