Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Addition of support for if_type=6 missed several checks for interface
type, resulting in the failure of several key management features
such as firmware dump and loopback testing.
Correct the checks on the if_type so that both SLI4 IF_TYPE's 2 and 6
are supported.
Signed-off-by: Dick Kennedy
Sig
Addition of support for if_type=6 missed several checks for interface
type, resulting in the failure of several key management features
such as firmware dump and loopback testing.
Correct the checks on the if_type so that both SLI4 IF_TYPE's 2 and 6
are supported.
Signed-off-by: Dick Kennedy
Sig
On Thu, Dec 06, 2018 at 07:52:51AM -0800, Christoph Hellwig wrote:
> This allows the host driver to indicate the maximum supported
> segment size in a nice an easy way, so that the driver doesn't
> have to worry about DMA-layer imposed limitations.
>
> Signed-off-by: Christoph Hellwig
> ---
> dr
Clang warns:
drivers/scsi/pcmcia/nsp_cs.c:1137:27: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) {
~~~^~~
drivers/scsi/pcmcia/nsp_cs.c:1137
Clang warns:
drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
variable of type 'unsigned char' to itself [-Wself-assign]
offset = offset;
~~ ^
Signed-off-by: Nathan Chancellor
---
drivers/scsi/nsp32.c | 1 -
1 file changed, 1 deletion(-)
diff -
From: Colin Ian King
Variable 'status' is declared but not used, remove it.
Cleans up warning:
warning: unused variable ‘status’ [-Wunused-variable]
Signed-off-by: Colin Ian King
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi
The event_wait semaphore has completion semantics, so we can
change it over to the completion interface for clarity without
changing the behavior.
Signed-off-by: Arnd Bergmann
---
drivers/scsi/aacraid/aacraid.h | 3 ++-
drivers/scsi/aacraid/commctrl.c | 1 -
drivers/scsi/aacraid/commsup.c |
The wait_sem member is used like a completion, so we should
use the respective API. The behavior is unchanged.
Signed-off-by: Arnd Bergmann
---
drivers/scsi/aacraid/aacraid.h | 2 +-
drivers/scsi/aacraid/commctrl.c | 4 ++--
drivers/scsi/aacraid/commsup.c | 4 ++--
3 files changed, 5 insertion
On Mon, 2018-12-10 at 22:28 +0100, Arnd Bergmann wrote:
> On Mon, Dec 10, 2018 at 10:01 PM Bart Van Assche
> wrote:
> >
> > On Mon, 2018-12-10 at 21:51 +0100, Arnd Bergmann wrote:
> > > In what seems to be a mismatch between the scsi-fixes branch and
> > > the scsi-mkp/for-next branch, a newly in
On Mon, Dec 10, 2018 at 10:01 PM Bart Van Assche wrote:
>
> On Mon, 2018-12-10 at 21:51 +0100, Arnd Bergmann wrote:
> > In what seems to be a mismatch between the scsi-fixes branch and
> > the scsi-mkp/for-next branch, a newly introduced variable from
> > one patch got obsoleted in another one:
>
On Mon, 2018-12-10 at 21:51 +0100, Arnd Bergmann wrote:
> In what seems to be a mismatch between the scsi-fixes branch and
> the scsi-mkp/for-next branch, a newly introduced variable from
> one patch got obsoleted in another one:
>
> drivers/scsi/qla2xxx/qla_os.c: In function '__qla2x00_abort_all_
In what seems to be a mismatch between the scsi-fixes branch and
the scsi-mkp/for-next branch, a newly introduced variable from
one patch got obsoleted in another one:
drivers/scsi/qla2xxx/qla_os.c: In function '__qla2x00_abort_all_cmds':
drivers/scsi/qla2xxx/qla_os.c:1791:11: error: unused variab
Hi Martin,
This series adds support for NPIV on FC-NVMe enabled ports.
Please apply this series to 4.21/scsi-misc at your earliest convenience.
Thanks,
Himanshu
Anil Gurumurthy (1):
qla2xxx: Enable FC-NVME on NPIV ports
Giridhar Malavali (1):
qla2xxx: Fix for FC-NVMe discovery for NPIV po
From: Giridhar Malavali
This patch fixes NVMe discovery by setting SKIP_PRLI flag, so that
PRLI is driven by driver and is retried when the NPIV port is detected
to have NVMe capability.
Signed-off-by: Giridhar Malavali
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 2
From: Anil Gurumurthy
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_mid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
index d620f4bebcd0..099d8e9851cb 100644
--- a/drivers/scsi
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 12bafff71a1a..ca7945cb959b 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
This patch fixes issues with NPIV port with FC-NVMe. Clean up
code for remoteport delete and also call nvme_delete when
deleting VPs.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 16 +++-
drivers/scsi/qla2xxx/qla_os.c | 2 ++
2 files changed, 5 insertions(
On Mon, 10 Dec 2018 11:19:59 -0800, Bart Van Assche wrote:
> Embedding SCSI properties like the unit serial number in a file system path
> seems wrong to me.
I completely agree, but unfortunately that's where we currently stand.
> I think the path in which these properties are stored
> should be
On Mon, 2018-12-10 at 14:36 +0100, David Disseldorp wrote:
> Ping - any feedback on this change?
>
> On Thu, 22 Nov 2018 14:38:00 +0100, David Disseldorp wrote:
>
> > Block ALUA and PR state storage if any of the dynamic subdirectory
> > components include a path separator.
> >
> > Fixes: c66ac9
On Wed, Dec 05, 2018 at 12:09:40PM -0800, Lee Duncan wrote:
> I recently found what I believe is a bug, and I'd appreciate feedback
> on if that is correct, and if so how to proceed.
...
> I used the same system for both the iSCSI initiator (using open-iscsi)
> and the iscsi target (using target
Thanks, Brian. Great point. Even for AER, it looks like in-flight
error handler completion is not guaranteed on
pci_disable_pcie_error_reporting call, so the crash is still possible.
It looks like we need to maintain per-pci_dev context and keep track
of in-flight callbacks to make a clean fix. I w
https://bugzilla.kernel.org/show_bug.cgi?id=201953
Bug ID: 201953
Summary: System freeze/hang during shutdown/restart (at " sd
0:0:0:0: [sda] Stopping disk")
Product: SCSI Drivers
Version: 2.5
Kernel Version: 4.* ish (i checked
Ping - any feedback on this change?
On Thu, 22 Nov 2018 14:38:00 +0100, David Disseldorp wrote:
> Block ALUA and PR state storage if any of the dynamic subdirectory
> components include a path separator.
>
> Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
> Signed-off-by: D
25 matches
Mail list logo
